› › ›

[ControlP5 + Serial] Serial input to textfield controller

Blad2021Blad2021
edited August 2019 in Arduino

Hi all,

So going to do my best to describe this, it might sound a bit more complicated then intended. I'm trying to set the value of a textfield controller (using ControlP5 library) with input from the Serial. I could do this now by using a bunch of if statements but thats not very attractive therefore I want a function. I have everything setup on my serial to ouput the following:

SEN.x.y

"SEN" being what it reads for to determine the function.
(x) - The textfield ID to change (y) - The value to change the textfield to.

My code so far:

import processing.serial.*;
import controlP5.*;

Serial myPort;  // Create object from Serial class**
String inByte;**
String s;**
ControlP5 cp5;
String temp;
String endchar = "\n";
Textarea consoletext;
Textfield Timer1;
Println console;
//Variables
boolean firstContact = false;
boolean globalState [] = {false, false, false, false, false, false, false, false};
int pin [] = {22, 24, 26, 28, 30, 32, 34, 36};

void setup() 
{  
  size(800,500);
  cp5 = new ControlP5(this);
  cp5.enableShortcuts();

  cp5.addTextfield("console")
    .setSize(360,35)
    .setCaptionLabel("Console Injection Module")
    .setPosition(20,430)
    .setFont(createFont("arial",14))
    .setAutoClear(true)
    ;

  cp5.addTextfield("Timer1")
    .setId(1)
    .setPosition(20,70)
    .setSize(200,35)
    .setFont(createFont("arial",12))
    .setAutoClear(true)
    .setCaptionLabel("EEPROM: Timer 1")
    ;
  cp5.addTextfield("Timer2")
    .setId(2)
    .setPosition(20,130)
    .setSize(200,35)
    .setFont(createFont("arial",12))
    .setAutoClear(true)
    .setCaptionLabel("EEPROM: Timer 2")
    ;
  cp5.addTextfield("Timer3")
    .setId(3)
    .setPosition(20,190)
    .setSize(200,35)
    .setFont(createFont("arial",12))
    .setAutoClear(true)
    .setCaptionLabel("EEPROM: Timer 3")
    ;
  cp5.addTextfield("Timer4")
    .setId(4)
    .setPosition(20,250)
    .setSize(200,35)
    .setFont(createFont("arial",12))
    .setAutoClear(false)
    .setCaptionLabel("EEPROM: Timer 4")
    ;
  cp5.addTextfield("Timer5")
    .setId(5)
    .setPosition(20,310)
    .setSize(200,35)
    .setFont(createFont("arial",12))
    .setAutoClear(false)
    .setCaptionLabel("EEPROM: Timer 5")
    ;
  cp5.addTextfield("Timer6")
    .setId(6)
    .setPosition(20,370)
    .setSize(200,35)
    .setFont(createFont("arial",12))
    .setAutoClear(false)
    .setCaptionLabel("EEPROM: Timer 6")
    ;
  cp5.addButton("button1")
    .setSize(60,20)
    .setCaptionLabel("LED On")
    .setPosition(235,70)
    ;
  cp5.addButton("button2")
    .setSize(60,20)
    .setCaptionLabel("LED Off")
    .setPosition(235,100)
    ;
  cp5.addButton("button4")
    .setSize(60,20)
    .setCaptionLabel("Relays On")
    .setPosition(235,130)
    ;
  cp5.addButton("button3")
    .setSize(60,20)
    .setCaptionLabel("Relays Off")
    .setPosition(235,160)
    ;
  cp5.addBang("Relay1")
     .setPosition(310,50)
     .setId(1)
     .setSize(60,30)
     .setCaptionLabel("relay1")
     ;

  cp5.addBang("Relay2")
     .setPosition(310,95)
     .setSize(60,30)
     .setId(2)
     .setCaptionLabel("Relay 2")
     ;

  cp5.addBang("Relay3")
     .setPosition(310,140)
     .setSize(60,30)
     .setId(3)
     .setCaptionLabel("Relay 3")
     ;

  cp5.addBang("Relay4")
     .setPosition(310,185)
     .setSize(60,30)
     .setId(4)
     .setCaptionLabel("Relay 4")
     ;

  cp5.addBang("Relay5")
     .setPosition(310,230)
     .setSize(60,30)
     .setId(5)
     .setCaptionLabel("Relay 5")
     ;
  cp5.addBang("Relay6")
     .setPosition(310,275)
     .setSize(60,30)
     .setId(6)
     .setCaptionLabel("Relay 6")
     ;
  cp5.addBang("Relay7")
     .setPosition(310,320)
     .setSize(60,30)
     .setId(7)
     .setCaptionLabel("Relay 7")
     ;
  cp5.addBang("Relay8")
     .setPosition(310,365)
     .setSize(60,30)
     .setId(8)
     .setCaptionLabel("Relay 8")
     ;
consoletext = cp5.addTextarea("txt")
  .setPosition(440,20)
  .setSize(350, 465)
  .setFont(createFont("", 12))
  .setLineHeight(14)
  .setColor(color(255, 255, 255, 255))
  .setColorBackground(color(100, 100))
  .setColorForeground(color(255, 100));
  ;
  cp5.addTextlabel("ctext")
    .setText("Console")
    .setPosition(436,3)
    .setColorValue(255)
    .setFont(createFont("Arial",14));
  cp5.addTextlabel("stitle")
    .setText("Machine Serial")
    .setPosition(10,10)
    .setColorValue(color(200, 17, 0, 255))
    .setFont(createFont("Arial",24));
  cp5.addTextlabel("subtitle")
    .setText("Control Panel")
    .setPosition(30,35)
    .setColorValue(200)
    .setFont(createFont("Arial",16));

  console = cp5.addConsole(consoletext);


  //change the 0 to a 1 or 2 etc. to match your port
  myPort = new Serial(this, "COM3", 9600);
  myPort.bufferUntil('\n');

}

void draw() {
  background(0);
  fill(255);
  for (int i=0;i<globalState.length;i++){
    if (globalState[i] == false){
      fill(color(200, 20, 0, 255));
      rect(385, 50+i*45, 30, 30);
    }
    else{
      fill(color(123, 255, 0, 255));
      rect(385, 50+i*45, 30, 30);
    }
  }
}
void controlEvent(ControlEvent test) {
  if(test.isAssignableFrom(Textfield.class)){
    if("console".equals(test.getName())){
      temp = test.getStringValue();
      if("LED On".equals(temp)){
        myPort.write("2");
        println("Sent: LED ON");
      }else if("LED Off".equals(temp)){
        myPort.write("1");
        println("Sent: LED OFF");
      }else if("help".equals(temp)){
        println("Help:");
        println("/  Commands:");
        println("/  - Update.x.y - Updates control pin layout.");
        println("     (x) - Array location  (y) - PIN");
        println("    Starts at 0!");
        println("/  - EEPROM.x.y - Updates EEPROM address (x) with value (y)");
        println("/  - PIN.x.y - Updates PIN (x) with value of (y)"); 
        println("/    [ Value should be 0 or 1 ONLY!]");
        println("/  - Call.x - Calls current value of position (x) in array");
        println("/  - Varu.x.y - Updates the position (x) with value of (y) in array");
        println("/");
        println("/");
        println("/  Timer values should stay within value of 5100");
        println("/");
      }else {
        String result = temp.substring(0,6);
      //if(temp.contains("Update"){
        if("Update".equals(result)){
          String apple = temp.substring(7,8);
          String pear = temp.substring(9,temp.length());
          int orange = Integer.parseInt(apple);
          int grape = Integer.parseInt(pear);
          pin[orange] = grape;
        } else {
          myPort.write(temp.toUpperCase() + '\n');
          println("Sent: " +temp.toUpperCase());
        }
      }
    }
    boolean StrTest = test.getName().startsWith("Timer");

    if(StrTest == true){
      println("Sending EEPROM Update to controller");
      println("Updating Timer: " +test.getId() +" to Value: " +test.getStringValue());
      Timefunc(test.getId()-1, test.getStringValue());
    }
  }
}
public void button1(){
  println("Sent: pin.10.1");
  myPort.write("PIN.10.1" +endchar);
}
public void button2(){
  println("Sent: pin.10.0");
  myPort.write("PIN.10.0" +endchar);
}
public void button3(){
  println("SYSTEM: Relays On");
  myPort.write("PIN.22.0" +endchar);
  myPort.write("PIN.24.0" +endchar);
  myPort.write("PIN.26.0" +endchar);
  myPort.write("PIN.28.0" +endchar);
  myPort.write("PIN.30.0" +endchar);
  myPort.write("PIN.32.0" +endchar);
  myPort.write("PIN.34.0" +endchar);
  myPort.write("PIN.36.0" +endchar);
}
public void button4(){
  println("SYSTEM: Relays Off");
  myPort.write("PIN.22.1" +endchar);
  myPort.write("PIN.24.1" +endchar);
  myPort.write("PIN.26.1" +endchar);
  myPort.write("PIN.28.1" +endchar);
  myPort.write("PIN.30.1" +endchar);
  myPort.write("PIN.32.1" +endchar);
  myPort.write("PIN.34.1" +endchar);
  myPort.write("PIN.36.1" +endchar);
}
public void Relay1(){
  RelayControl(pin[0], !globalState[0]);
}
public void Relay2(){
  RelayControl(pin[1], !globalState[1]);
}
public void Relay3(){
  RelayControl(pin[2], !globalState[2]);
}
public void Relay4(){
  RelayControl(pin[3], !globalState[3]);
}
public void Relay5(){
  RelayControl(pin[4], !globalState[4]);
}
public void Relay6(){
  RelayControl(pin[5], !globalState[5]);
}
public void Relay7(){
  RelayControl(pin[6], !globalState[6]);
}
public void Relay8(){
  RelayControl(pin[7], !globalState[7]);
}
public void RelayControl(int Id, boolean Flag){
  byte status = 0;
  if(Flag == true){
    status = 1;
  } else {
    status = 0;
  }
  myPort.write("PIN." +Id +'.' +status +endchar);
}

void SensorCheck(int value){
 myPort.write("SC." +value +endchar);
}

public void Timefunc(int Id, String value){
  byte overboard = 0;
  int control = Integer.parseInt(value);
  if(control > 5100){
    control=5100; 
  }
  control = control/10;
  if(control >= 256){
    overboard = 1;
  }
  if(overboard == 0){
    myPort.write("EEPROM." +Id +'.' +control +endchar);
    Id++;
    myPort.write("EEPROM." +Id +'.' +"0" +endchar);
  }
  if(overboard == 1){
    control = control - 255;
    myPort.write("EEPROM." +Id +'.' +"255" +endchar);
    Id++;
    myPort.write("EEPROM." +Id +'.' +control +endchar);
  }
}

void serialEvent(Serial myPort) {
  inByte = myPort.readStringUntil('\n');
  if (inByte != null){
    inByte = trim(inByte);
    println("Recieved: " +inByte);
    if(inByte.contains("PIN.")){
      String result = inByte.substring(4,6);
      char state = inByte.charAt(7);
      boolean isOn;
      if(state == '1'){
        isOn = true;
      }
      else{
       isOn = false; 
      }
      int endresult = parseInt(result);
      for(int i = 0;i<pin.length;i++){
        if (endresult == pin[i]){
          globalState[i] = isOn;
        }
      }
      delay(10);
    }//End of PIN Function
    if(inByte.contains("SEN.")){
      char firstvalue = inByte.charAt(5);
      char secondvalue = inByte.charAt(7);
      int fvresult = parseInt(firstvalue);
      int svresult = parseInt(secondvalue);
      cp5.getId(fvresult);
    }

    if (firstContact == false) {
      if (inByte.equals("<Controller is ready>")) {
        myPort.clear();
        firstContact = true;
        //myPort.write("A");
        println("SYSTEM: Contact Made");
        delay(100);
        println("Control ready!");
      }
    }
  }
}

The issue resides with this line: cp5.getId(fvresult);

How can I format this to send the information to the Textfield controller when it doesn't go thorugh the ControlEvent function?

edit: fixed spelling mistakes.

edit: I have a working example below. Its just not a "universal" function:

if(inByte.contains("SEN.")){
  char firstvalue = inByte.charAt(5);
  String secondvalue = inByte.substring(6,inByte.length());
  //int fvresult = Integer.parseInt(firstvalue);
  int svresult = Integer.parseInt(secondvalue);
  println(svresult);
  Timer1.setText(secondvalue);
}
Tagged:

Answers

  • Blad2021Blad2021
    edited April 2017

    I feel I may have made progress but i'm not out of the woods yet. Heres my updated code:

    if(inByte.contains("SEN.")){
  char firstvalue = inByte.charAt(4);
  String secondvalue = inByte.substring(6,inByte.length());
  int fvresult = Character.getNumericValue(firstvalue);
  int svresult = Integer.parseInt(secondvalue);
  String fvstring = "Timer" + firstvalue;
  println("FirstValue String =" +fvstring);
  Controller controlledtest = cp5.getController(fvstring);
  controlledtest.setText(secondvalue);
  switch (fvresult) {
    case 1:
      Timer1.setText(secondvalue);
    break;
    case 2:
      Timer2.setText(secondvalue);
    break;
    default:
    println("SYSTEM: Value recieved was irregular");
    break;
  }
}

    The switch does work, but like before, to me its robust and ugly. I got the string to append the text I needed but the controller isn't being recognized or something.

    controlledtest gets assigned Timer1 for instance. but the next line, controlledtest.setText(string) does not work.

    I have a textfield called "Timer1" so this should work right?

  • kfrajerkfrajer

    Combine line 11 and 32 from your first post:

    Timer1 = cp5.addTextfield("Timer1")

    Then

    if(inByte.contains("SEN.")){
  char firstvalue = inByte.charAt(4);
  String secondvalue = inByte.substring(6,inByte.length());

  int fvresult = Character.getNumericValue(firstvalue);
  int svresult = Integer.parseInt(secondvalue);

  switch (fvresult) {
    case 1:
      Timer1.setText(secondvalue);
    break;
    case 2:
      Timer2.setText(secondvalue);
    break;
    default:
    println("SYSTEM: Value recieved was irregular");
    break;
  }
}

    Notice it is a good and encourage habit to use the first letter of variable and object names in lower case. Name of classes's first letters in upper case. So Timer1 should be timer1.

    Kf

  • kfrajerkfrajer

    Based on provided examples, you can also do:

    cp5.get(Textfield.class,"Timer1").setText(secondvalue);

    I tested your code in the last post:

    Controller controlledtest = cp5.getController("textValue");
((Textfield)controlledtest).clear();

    Kf

  • Blad2021Blad2021
    edited April 2017

    @kfrajer My apologies. I already corrected the first mistake but forgot to update it here. Thanks for noticing it though.

    I'm not sure my issue is fixed or if there is a fix other then the switch. I'm trying to get rid of the switch statement in my post above and replace it with a simple function that receives the Controller ID from serial. Then forward that to set the value.

    So serial sends SEN.1.200

    1 being the ID of the controller to change. 200 being the value to change it to.

    It does work with the switch statement if I have a case for each controller but that's just a lot of code vs maybe a slightly complicated function to process it. Maybe i'm just being too picky.

    I'm looking for something similar to below. I'll add comments to try to help explain. (The version below does not work)

    Note that line 32 does contain timer1 = cp5.addtextfield..... and so on.

    I do appreciate your response and look forward to hearing more! Thank you, - Matt

    //Inside Main serial function
    if (inByte.contains("SEN.")) {
      //firstvalue determines what controller to EDIT.
      char firstvalue = inByte.charAt(4);
      //secondvalue determines what value to change the controller from first value.
      String secondvalue = inByte.substring(6, inByte.length());

      //IGNORE.  Used for switch.
      //int fvresult = Character.getNumericValue(firstvalue);

      //Assign the character from firstvalue to string labeled "timer" to change the string to timer1, timer2, timer3, etc.
      String fvstring = "timer" + firstvalue;
      //Process a controller to control a controller??????? Sounds like time travel....
      Controller jess = cp5.getController("fvstring");
      //Store value into a temporary variable for testing.
      float o = jess.getValue();
      println(o);

      //IGNORE.  Switch used for testing only.  Switch won't exist if function is working.
      /*
      switch (fvresult) {
      case 1:
        Timer1.setText(secondvalue);
        break;
      case 2:
        Timer2.setText(secondvalue);
        break;
      default:
        println("SYSTEM: Value recieved was irregular");
        break;
      }*/
    }
  • Blad2021Blad2021
    edited April 2017

    Oh...... Wow..... I see! From your previous post I got it to work!

    Posting working code below for future viewers. Thank you very much kfrajer!

        if (inByte.contains("SEN.")) {
      //firstvalue determines what controller to EDIT.
      char firstvalue = inByte.charAt(4);
      //secondvalue determines what value to change the controller from first value.
      String secondvalue = inByte.substring(6, inByte.length());

      //Assign the character from firstvalue to string labeled "timer" to change the string to timer1, timer2, timer3, etc.
      String fvstring = "timer" + firstvalue;
      cp5.get(Textfield.class,fvstring).setText(secondvalue);
    }

    Edit: Attaching second example to show transferring data to array.

    if (inByte.contains("SOL.")) {
      //firstvalue determines what controller to EDIT.
      char firstvalue = inByte.charAt(4);
      //secondvalue determines what value to change the controller from first value.
      String secondvalue = inByte.substring(6, inByte.length());

      //Assign the character from firstvalue to string labeled "timer" to change the string to timer1, timer2, timer3, etc.
      String fvstring = "relayPin" + firstvalue;
      int firstint = Character.getNumericValue(firstvalue);
      int secondint = Integer.parseInt(secondvalue);
      relayArray[firstint]=secondint;
      cp5.get(Textfield.class,fvstring).setText(secondvalue);
    }

    Can a moderator please tag his/her post as answer if you see this,
    thanks,
    Matt

Sign In or Register to comment.