In reference to David Heubners vector class:
http://www.millbridge.de/processing/Vector.pde

Found through an earlier post of mine:
http://processing.org/discourse/yabb_beta/YaBB.cgi?board=Contribution_3DOpenGL;action=display;num=1116270837

I hope the author doesn't mind me publically discussing this, but I had a few open questions/comments about the class.

For a start, I added my own method to the end:
Code:

  public Vector clone() {
    return new Vector(x[0], x[1], x[2]);
  } 

This creates a new copy of the clone in memory, which I've found useful. And then I noticed, the class has highly similar methods e.g. rotateZ() and rotateMeZ(). I presume the intention was that you could produce a new vector by rotating the existing vector (rotateZ()) or simply rotate the vector changing its space in memory (rotateMeZ()).

The rotateZ method looks wrong to me because you're not creating a copy of the vector on the line Vector result = this;, you're just assigning an alias so when the rotation is performed you are actually damaging the vector and returning another alias?

And so, I think the code for rotateZ() (and similar functions) should read:
Quote:

The other thing I wanted to add about this class is, would it be possible to have some documentation on this? Lastly, to TomC's comment (in the other post) about renaming it - I don't mind it being called Vector if it has the same functionality as the original plus the extra features. I'm including as needed for the moment.

Ok, well the new FVector class seems to work fine, it fulfills all the features of the previous one any how. I replaced the other Vector class in one of my programs. It took me a while to find/replace all the Vector variables and replace them with FVector, and also change the vect.x[0] access with vect.e[0] access (used in a few of your methods).

Heres a bit of documentation I found on how the clone method is supposed to be implemented. http://java.sun.com/docs/books/tutorial/java/javaOO/objectclass.html
I disagree that you chose cloneMe() instead of clone() since what else are you going to clone?

I have strange things when I use rotateMeX. x[i] is changed and then called on the second line.

Code:

public void rotateMeX(float val) {
    double cosval = cos(val);
    double sinval = sin(val);
    x[1] = (float)(x[1]*cosval - x[2]*sinval);     <----(1)
    x[2] = (float)([b]x[1][/b]*sinval + x[2]*cosval);   <-----(2)
  } 

Should it be:
Code:

public void rotateMeX(float val) {
    double cosval = cos(val);
    double sinval = sin(val);
    double tmp1 = (x[1]*cosval - x[2]*sinval);
    double tmp2 = (x[1]*sinval + x[2]*cosval);
    x[1] = (float) tmp1 ;
    x[2] = (float) tmp2;
  } 

?

there might be another problem (maybe not) but I think you mean:

Code:

cVector = cVector.rotateX(radians(30)); 

instead of:

Code:

cVector = cVector.rotateX(degrees(30)); 

since degrees() converts from radians to degrees and 30 seems a value used in degrees.

Wich one is more rapid?   Code:

float x[0], x[1], x[2], x[3]; 

or   Code:

float x, y, z, w; 

With a lot of calls it should be slower with an array? In other way, It's nice to keep them homogenous.

Arguably, whos going to need a 4, or 5 point vector? Perhaps it would be a better idea to write an optimized class with fix memory variables.

I would assume it only gets heavy if you have many vectors as apposed to processing the same vector over and over again.

Ok, bugs have been sorted.
I also included a rotation around a given axis and some minor changes.