hello,

three days ago i had my first contact with processing.
and well -  i like it.

at the moment i try to change sketches i found in the web.
and until yet this was no bad idea - i've learned a lot.

but with this project i need help.
i try to change following code into classes on two tabs
and make it as simple as possible
(get rid of everything i don't need to get the same result)
it's a very simple program...
three lines move with different speed on the y-axis
and two of them changes color from red to yellow/cyan
the slowest is always yellow.


beyond this i'm asking myself
on how many ways you can write this
by getting the same result?
what is the simplest way to do it?

this is the state of play

Code:

// Declare and construct tree objects (h1, h2, h3) from the class HLine 
// Objects habe different kind of color behavior.
HLine h1 = new HLine(color(255), color(0), color(0), -100, 2.0); 
HLine h2 = new HLine(color(255), color(0), color(0), -30, 2.5); 
HLine h3 = new HLine(color(0), color(255), color(0), -30, 0.4); 

void setup() 
{
  size(255, 255);
  frameRate(24);
  smooth();
}

void draw() { 
  background(170);
  h1.update(); 
  h2.update();  
  h3.update();  
  h1.tempColor01();
  h2.tempColor02();
  h3.tempColor03();
} 

class HLine { 
  color r, g, b;
  float ypos, speed;

  HLine (color tempR, color tempG, color tempB, float y, float s) {  
    r = tempR;
    g = tempG;
    b = tempB;
    ypos = y; 
    speed = s; 

  } 
  void update() { 
    ypos += speed; 
    if (ypos > width) { 
	ypos = 0; 
    } 

    line(0, ypos, width, ypos); 
  }

  void tempColor01() { 

    float g = ypos; 
    if (g > height) { 
	g = (0); 
    } 
    stroke(255,g,b);
    strokeWeight(4);
    line(0, ypos, width, ypos); 

  }

  void tempColor02() { 

    float b = ypos; 
    if (b > height) { 
	b = (0); 
    } 
    stroke(255-b,b,b);
    strokeWeight(2);
    line(0, ypos, width, ypos); 

  }
  void tempColor03() { 

    stroke(255,255,0);
    strokeWeight(0);
    line(0, ypos, width, ypos); 

  }

}

 

and it looks like this with two tabs... but it does not work yet.  

Code:

HLine myh1; 
HLine myh2;
HLine myh3; 




void setup(){

  size(255, 255);
  frameRate(24);
  smooth();
  
}

void draw() { 
  background(170);
  myh1.update(); 
  myh1.display(); 
  myh2.update();  
  myh2.display(); 
  myh3.update();  
  myh3.display(); 

float c = color();
  
  myh1 = new HLine(color(255, c, c), -100, 2.0); 
  myh2 = new HLine(color(255-c, c, c), -30, 2.5); 
  myh3 = new HLine(color(255, 255, 0), -30, 0.4); 


} 


 

and the 2nd tab named HLine"
Code:

class HLine{ 

  color c;
  float ypos, speed;


  HLine(color tempC, float y, float s) {  

    c = tempC = color();
    ypos = y; 
    speed = s; 
  } 


  void display() {
    fill (c);
    line(0, ypos, width, ypos); 
    stroke (s);
  }


  void update() { 
    ypos += speed; 
    if (ypos > width) { 
	ypos = 0; 

    }
  }

}

 

Chrisir wrote on Jan 17^th, 2010, 11:58am:



@Chrisir
that doesn't work... but thank you for this hint.

mmh, better.

but the lines are still black...
is it possible to work with "int c" when "c" is a variable defined in the class for the color of the lines?


Code:

HLine myh1; 
HLine myh2;
HLine myh3; 




int c;


void setup(){

  size(255, 255);
  frameRate(24);
  smooth();

  
  myh1 = new HLine(color(255, c, c), -100, 2.0); 
  myh2 = new HLine(color(255-c, c, c), -30, 2.5); 
  myh3 = new HLine(color(255, 255, 0), -30, 0.4); 

  
}


void draw() { 
  background(170);
  myh1.update(); 
  myh1.display(); 
  myh2.update();  
  myh2.display(); 
  myh3.update();  
  myh3.display(); 


} 
  

hey Chrisir,


it was the attempt to make the class more easy simple

and to work with the variable "c" in the color definition part of


Code:

myh1 = new HLine(color(255, c, c), -100, 2.0);    
 myh2 = new HLine(color(255-c, c, c), -30, 2.5);   
 myh3 = new HLine(color(255, 255, 0), -30, 0.4); 
 

cheers

thank u chrisir,

you are absolutely right with the s(peed)
what i realy wanted was a strokeWeight

now this code here works much better than the one before
the lines are colored
but the color is still not changin yet...

tab_01:

Code:

HLine myh1; 
HLine myh2;
HLine myh3; 

int c;


void setup(){

  size(255, 255);
  frameRate(25);
  smooth();
  
  myh1 = new HLine(color(255, c, c), -100, 2.0, 4); 
  myh2 = new HLine(color(255-c, c, c), -30, 2.5, 2); 
  myh3 = new HLine(color(255, 255, 0), -30, 0.4, 0); 

  
}


void draw() { 
  background(170);

  myh1.update(); 
  myh1.display(); 
  myh2.update();  
  myh2.display(); 
  myh3.update();  
  myh3.display(); 


} 

 

tab_02

Code:

class HLine{ 

  color c;
  float ypos, speed;
  float s;
  float sw;



  HLine(color tempC, float y, float s, float sweight) {  

    c = tempC;
    ypos = y; 
    speed = s; 
    sw = sweight;
  } 

  void update() { 
    ypos += speed; 
    if (ypos > height) { 
	ypos = 0;
    }
    stroke (c);
    strokeWeight (sw);
    line(0, ypos, height, ypos); 
  }


  void display() {
    c = color (c);
	stroke (c);
    strokeWeight (sw);
    line(0, ypos, height, ypos); 
  }




}
 

sorry, that doesn't work...

basically this should look like the code
i've posted first but with the function "c" in this part of the code
Code:

 myh1 = new HLine(color(255, c, c), -100, 2.0);    
 myh2 = new HLine(color(255-c, c, c), -30, 2.5);   
 myh3 = new HLine(color(255, 255, 0), -30, 0.4); 
 

to change the color of the lines according to there y position

hey chrisir,

i've tried nearly everything now
and i don't know what to do anymore...


i haven't figured out yet how to get a variable argument "ypos"
inside of the constructor method.


Code:

  myh1 = new HLine(color(255,  ypos, ypos), -100, 2.0, 0); 
  myh2 = new HLine(color(255-ypos, ypos, ypos), -30, 2.5, 2); 
  myh3 = new HLine(color(0, 255, 0), -30, 0.4, 5);  

this is the actual state of the code.

tab_01
Code:

HLine myh1; 
HLine myh2;
HLine myh3; 

float ypos, speed;


void setup(){

  size(255, 255);
  frameRate(25);
  smooth();
  colorMode(RGB);
 
  
  myh1 = new HLine(color(255,  ypos, ypos), -100, 2.0, 0); 
  myh2 = new HLine(color(255-ypos, ypos, ypos), -30, 2.5, 2); 
  myh3 = new HLine(color(0, 255, 0), -30, 0.4, 5); 


}


void draw() { 
  background(170);
  
  
  myh1.update(); 
  myh1.display();
  myh2.update();  
  myh2.display(); 
  myh3.update();  
  myh3.display(); 

} 


 

and tab_02
Code:

class HLine{ 

  color c;
  float ypos, speed;
  float sw;
  float r, g, b;



  HLine(color tempC,  float y, float s, float sweight) {  

    c = tempC;
    ypos = y; 
    speed = s; 
    sw = sweight;
  } 
  


  void update() { 
    ypos += speed; 
    if (ypos > height) { 
	ypos = 0;
    }
    stroke (c);
    strokeWeight (sw);
    line(0, ypos, height, ypos); 

  }
  
  void display() {

    stroke (c);
    strokeWeight (sw);
    line(0, ypos, height, ypos); 
  }



}






 

hello once again,

Quote:

         

unfortunately this was not the solution

with c=pos;

i ger the error "cannot convert from float to int"

with float c = pos;

it doesn't work as well


but thank u allredy for your patience
this is a more challenging peace of code than i've had expected

cheers