Good afternoon!
I am trying to load a big data set to perform some calculations based on the values contained in certain columns. I built this code using a simple data set and it worked on most columns, but I noticed that (for some reason it loops over certain columns twice! I can't seem to figure out why!
For example if I had a spread sheet where the 9th column contained only 2 values ('blue' and 'red')
I should see this:
1
2
Red is 20
Blue is 27

but the output that  I am seeing is more like this:
1
2
1
2
Red is 40
Blue is 54

Has anyone seen anything like this before? Do I have a glaring mistake in my code?? I am open to (and grateful for) any suggestions that you might have.
Many thanks!



import processing.pdf.*;
Table t;
HashMap myMap;
int rowCount, labelCount;
int count;

void setup(){
 t = new Table("wf08-09.tsv");
 rowCount = t.getRowCount(  );

 myMap = new HashMap();
 crunchData();
 size(200, 200, PDF, "filename.pdf");
 displayMapContents(myMap);
}

void crunchData(){
 for (int i = 1; i < rowCount; i++) { // Start at 1 to skip the col title
   String value = t.getString(i, 8);
   if(myMap.containsKey(value)){
     count = (Integer)myMap.get(value);
     myMap.put(value,++count);
   }
   else if(!myMap.containsKey(value)){
     myMap.put(value,count); // DEBUGGING
     println(i);
   }    
 }  
}

void displayMapContents(HashMap hm){
 Iterator i = hm.entrySet().iterator();  // Get an iterator

 while (i.hasNext()){
   Map.Entry me = (Map.Entry)i.next();
   print(me.getKey() + " is ");
   println(me.getValue());
 }
}

Thank you very much for that reminder!
I have taken your advice and cleaned up the code just a little bit. As I have advanced the program I am now encountering another issue: here is the output that I am expecting to see (on a Column that contained values 'M' or 'E')

2923 Total lines
------------------------------------
46.0% M[1335]
54.0% E[1585]
------------------------------------

which looks good, but adding the two gives me 2920.
Then I am getting other print outs like this (for a column that contained letters 'P','S','G' & 'M'):

2923 Total lines
------------------------------------
10.0% P[289]
93.0% S[2720]
22.0% G[651]
10.0% M[287]
------------------------------------
As you can see, the numbers don't add up to the total and the % = 135%!

Is my code really that sloppy? I can understand the data being less than perfect but if my row count is consistent and I am restraining the loop to that count... how is it that the totals and % are off?

Any other ideas or suggestions on how to make this code more reliable?
I am very grateful for any helpful responses!
Thanks!

import processing.pdf.*;
Table t;

HashMap myMap;
int rowCount, labelCount;
int count;
float percent;

void setup(){
 size(200, 200, PDF, "out.pdf");  

 t = new Table("wf08-09.tsv");
 rowCount = t.getRowCount(  );
 println(rowCount+" Total lines");
 println("------------------------------------");
 myMap = new HashMap();
 crunchData();
 displayMapContents(myMap);
 println("------------------------------------");  
}

void displayMapContents(HashMap hm){
 Iterator i = hm.entrySet().iterator();  // Get an iterator
 while (i.hasNext()){
   Map.Entry me = (Map.Entry)i.next();
   Integer value = (Integer)me.getValue();
   percent = ((float)value/(float)rowCount)*100 ;
   float f = (float)Math.round(percent);
   print(f+"% ");
   println(me.getKey()+"["+me.getValue()+"]");
 }
}

void crunchData(){
 for (int i = 1; i < rowCount; i++) { // Start at 1 to skip the col title
   String value = t.getString(i, 8);
   
   if(myMap.containsKey(value)){
     count = (Integer)myMap.get(value);
     myMap.put(value,++count);
   }
   else if(!myMap.containsKey(value)){
     myMap.put(value,count);
     // println(i); //DEBUGGING
   }    
 }  
}  

Thanks Koogy (and PhiLho)!
I didn't understand it at first but now I got it, and looking back it was a dumb oversight, thank you for your assistance in my debugging- I am a lone programmer in a big office and it is nice to get another programmer to review your code.
Thank you!!!!

BTW: would you guys know of a quick way to re-order the HashMap in descending order?

Feralo wrote on Oct 1^st, 2009, 11:03am:
As koogy said, just don't use a HashMap, unordered by design, use a TreeMap.
At least if you want to sort it by its keys.