Tips on making an ear trainer

curiousman

Re: Tips on making an ear trainer

2 years ago

Hello,

I got a brain wave but I am able to get it working kinda how I like but I feel I need a better way to control the frequencies chosen for sine wave 1 and sine wave 2.

Currently s1 and s2 are a random frequency between two points. If s1 and s2 lay withen a certain range of the center frequency which is 500hz s1 and/or s2 are changed.
Also if s1 and s2 are too close to eachother they are changed again but as the tester progresses I end up with getting randomly spaced s1 and s2 instead of slowly converging s1 and s2's.

Any tips?
Controls are "s" to play the two tones and "1" and "2" to choose which tone was higher pitched.

import ddf.minim.*;
import ddf.minim.signals.*;

Minim minim;
AudioOutput out;
SineWave sine;
SineWave sine2;
int corefreq = 500;
int high = 100;
int low = 100;
float s1;
float s2;
int c;
int d;
int e;
int mx;
int mn;
//float s1 = random((corefreq - 100), (corefreq - 50));
//float s2 = random((corefreq + 50), (corefreq + 100));

void setup()
{
size(512, 200, P2D);
mx = 600;
mn = 400;
println("Max value: " + mx);
println("Min value: " + mn);
println(" ");
s1 = random(mn, mx);
s2 = random(mn, mx);
c = 50;
d = 100;
e = 0;
println("S1 and S2 before if changes:");
println("S1 = " + s1);
println("S2 = " + s2);
println(" ");
println("d adds a value to S1 and S1 if they lay inside a range above and below core freq which decreases an amount of e per level:");
println("d = " + d);
println("e = " + e);
    println(" ");
// If S1 is within +/- of core freq
if (s1 <= 580 - e ) {
if (s1 >= 420 + e) {
s1 = s1 - d;
}
}
if (s2 <= 580 ) {
if (s1 >= 420) {
s2 = s2 + d;
}

}
println("S1 and S2 after if changes, if any");
println("S1 = " + s1);
println("S2 = " + s2);
    println(" ");

s1 = int(s1);
s2 = int(s2);

println("S1 and S2 after float to int changes, if any");
println("S1 = " + s1);
println("S2 = " + s2);
    println(" ");


// If S1 and S2 are too close, c is added to them. Default value of c is 50. As levels progress c decreases by 5.
if (s1 - s2 <= 20) {
s1 = s1 - c;
s2 = s2 + c;
}

println("S1 and S2 after proximity changes, if any");
println(s1);
println(s2);

minim = new Minim(this);
out = minim.getLineOut(Minim.STEREO);
    println("Welcome to the pitch trainer app. The aim of this is to train your ears to detect tiny differences in pitch. Please press 'S' to start");
}

void draw()
{
background(0);
stroke(255);

if(keyPressed) {
    if (key == 's' || key == 'S') {
       sine = new SineWave(s1, 0, out.sampleRate());
       sine2 = new SineWave(s2, 0, out.sampleRate());
out.addSignal(sine);
out.addSignal(sine2);
sine.setAmp(0.5);
delay(1500);
sine.setAmp(0);
delay(800);
sine2.setAmp(0.5);
delay(1500);
sine2.setAmp(0);
println("Which tone was higher in pitch? The 1st or 2nd? Use the 1 and 2 keys to choose.");
println(s1);
println(s2);
    println(" ");
    }
} else {

}

}
void keyPressed(){

if(keyPressed) {
    if (key == '1') {

    if(s1 > s2) {
    println("Correct. Moving to next level");
     s1 = random(mn + 10, mx - 10);
     s2 = random(mn + 10, mx - 10); // As levels progress the max and min freq become closer together
     c = c - 5;
     e = e + 10;
     d = d - 10;
     println("after correct");
println("Max value: " + mx);
println("Min value: " + mn);
println(" ");
    println("S1 and S2 before if changes:");
println("S1 = " + s1);
println("S2 = " + s2);
println(" ");
println("d adds a value to S1 and S1 if they lay inside a range above and below core freq which decreases an amount of e per level:");
println("d = " + d);
println("e = " + e);
    println(" ");
println(" ");

} else {
    println("Nay");
}


    }
}

   if(keyPressed) {
    if (key == '2') {
       if(s2 > s1) {
    println("Correct. Moving to next level");
s1 = random(mn + 10, mx - 10);
     s2 = random(mn + 10, mx - 10); // As levels progress the max and min freq become closer together
    c = c - 5;
    e = e + 10;
    d = d - 10;

    println("after correct");
println("Max value: " + mx);
println("Min value: " + mn);
println(" ");
    println("S1 and S2 before if changes:");
println("S1 = " + s1);
println("S2 = " + s2);
println(" ");
println("d adds a value to S1 and S1 if they lay inside a range above and below core freq which decreases an amount of e per level:");
println("d = " + d);
println("e = " + e);
    println(" ");
println(" ");
} else {
    println("Nay");
}

    }
}

}

void stop()
{
out.close();
minim.stop();

super.stop();
}

curiousman

Re: Tips on making an ear trainer

2 years ago

I have since changed it a lot!

Any optimisations to be had or big errors in it?

I need to make a basic GUI next.

import ddf.minim.*;
import ddf.minim.signals.*;

Minim minim;
AudioOutput out;
SineWave sine;
SineWave sine2;

float n1;
float n2;
float s1;
float s2;
int lowmin;
int lowmax;
int highmin;
int highmax;
int a;
int b;
int c;
int d;
float low;
float high;
int level;

void setup()
{
size(512, 200, P2D);

low = 400;
high = 600;
println("Void Setup");
println("Low = " + low);
println("High = " + high);

println(" ");
n1 = low;
n2 = high;

float[] sinesource = new float [2];
sinesource[0] = n1;
sinesource[1] = n2;

s1 = sinesource[int(random(0,2))];
println("Sine Source 1 " + s1);

if(s1 == n1) {
    s2 = n2;
}
else {
    s2 = n1;
}

println("Sine Source 2 " + s2);

minim = new Minim(this);
out = minim.getLineOut(Minim.STEREO);
// println("Welcome to the pitch trainer app. The aim of this is to train your ears to detect tiny differences in pitch. Please press 'S' to start");
}

void draw()
{
background(0);
stroke(255);
if(keyPressed) {
    if (key == 's' || key == 'S') {
      println("Void Draw");
      println("Low = " + low);
      println("High = " + high);
      println("LEVEL " + level);
      println(" ");
      n1 = low;
      n2 = high;

      float[] sinesource = new float [2];
      sinesource[0] = n1;
      sinesource[1] = n2;

      s1 = sinesource[int(random(0,2))];
      println("Sine Source 1 " + s1);

      if(s1 == n1) {
        s2 = n2;
      }
      else {
        s2 = n1;
      }

      println("Sine Source 2 " + s2);

      sine = new SineWave(s1, 0, out.sampleRate());
      sine2 = new SineWave(s2, 0, out.sampleRate());
      out.addSignal(sine);
      out.addSignal(sine2);
      sine.setAmp(0.5);
      delay(1500);
      sine.setAmp(0);
      delay(800);
      sine2.setAmp(0.5);
      delay(1500);
      sine2.setAmp(0);
    }
}
else {
}
}

void keyPressed() {

if(key == '1') {
    if(s1 > s2) {
      println("Yay 1");
      level = level + 1;

      if (level == 2) {
        low = 494;
        high = 506;
      }

      if (level == 3) {
        low = 497;
        high = 503;
      }

      if (level == 4) {
        low = 497;
        high = 503;
      }
      if (level == 5) {
        low = 497;
        high = 503;
      }

      if (level == 6) {
        low = 498.5;
        high = 501.5;
      }

      if (level == 7) {
        low = 498.5;
        high = 501.5;
      }

      if (level == 8) {
        low = 498.5;
        high = 501.5;
      }
      if (level == 9) {
        low = 499.25;
        high = 500.75;
      }

      if (level == 10) {
        low = 499.25;
        high = 500.75;
      }

      if (level == 11) {
        low = 499.25;
        high = 500.75;
      }

      if (level == 12) {
        low = 499.8125;
        high = 500.1875;
      }

      if (level == 13) {
        low = 499.8125;
        high = 500.1875;
      }

      if (level == 14) {
        low = 499.8125;
        high = 500.1875;
      }
    }
    else {
      println("Nay 1");
      level = level - 1;
    }
}
else {
    if(key == '2') {
      if(s1 < s2) {
        println("Yay 2");
        level = level + 1;

        if (level == 2) {
          low = 494;
          high = 506;
        }

        if (level == 3) {
          low = 497;
          high = 503;
        }

        if (level == 4) {
          low = 497;
          high = 503;
        }
        if (level == 5) {
          low = 497;
          high = 503;
        }

        if (level == 6) {
          low = 498.5;
          high = 501.5;
        }

        if (level == 7) {
          low = 498.5;
          high = 501.5;
        }

        if (level == 8) {
          low = 498.5;
          high = 501.5;
        }
        if (level == 9) {
          low = 499.25;
          high = 500.75;
        }

        if (level == 10) {
          low = 499.25;
          high = 500.75;
        }

        if (level == 11) {
          low = 499.25;
          high = 500.75;
        }

        if (level == 12) {
          low = 499.8125;
          high = 500.1875;
        }

        if (level == 13) {
          low = 499.8125;
          high = 500.1875;
        }

        if (level == 14) {
          low = 499.8125;
          high = 500.1875;
        }
      }
      else {
        println("Nay 2");
        level = level - 1;
      }
    }
}
}

void stop()
{

out.close();
minim.stop();

super.stop();
}

curiousman

Re: Tips on making an ear trainer

2 years ago

Final draft
A wee spelling mistake when you finish all 16 levels.

import ddf.minim.*;
import ddf.minim.signals.*;
Minim minim;
AudioOutput out;
SineWave sine;
SineWave sine2; // Audio setup

PFont font;
PFont font2;
PFont font3;

float n1;
float n2;
float s1;
float s2;
float low;
float high; // sets up floats for low sine and high sine wave information below

int level;
int levelview; // Sets up level progression information

void setup()
{
size(800, 500,P2D);
background(0);

levelview = level + 1; // As level starts from 0, this adds 1 for user interface

font = loadFont("CenturyGothic-Italic-32.vlw");
font2 = loadFont("CenturyGothic-Italic-24.vlw");
font3 = loadFont("CenturyGothic-Italic-16.vlw"); // Loads fonts of 3 different sizes

textFont(font);
fill(0, 102, 153);
text("Welcome to the pitch tester application.", 0, 0, 800, 100);
textFont(font2);
fill(234, 12, 12);
text("This app is designed to test your ability to tell the which of two tones is higher pitched then the other.", 0, 105, 800, 800);
fill(255);
text("How to use:", 0, 170, 800, 100);
text("S - Press this to play the tone at the start of a new level. Use as much as you need during each level.", 0, 190, 800, 100);
fill(134);
text("To choose which tone is higher in pitch, press 1 or 2 for the 1st or 2nd.", 0, 247, 800, 100);
textFont(font2);
fill(255, 21, 0);
text("Press E to exit.", 600, 450, 250, 50);
fill(12,229,234);
text("This is level " + levelview, 0, 310, 800, 100);

low = 400;
high = 600;
println("Void Setup");
println("Low = " + low);
println("High = " + high); // prints low and high frequency information

println(" ");
n1 = low;
n2 = high; // turns low and high to n1 and s2 for the inital set of sine frequecies values

float[] sinesource = new float [2];
sinesource[0] = n1;
sinesource[1] = n2; // n1 and n2 are placed in an array where they are randomly chosen to supply the frequency for sine 1 (s1) and sine2 (s2)

s1 = sinesource[int(random(0,2))];
println("Sine Source 1 " + s1);

if(s1 == n1) {
    s2 = n2;
}
else {
    s2 = n1;
} // when one piece of information has been taken out of the array to supply one sine wave, this insures the other is the unchosen value from the array.
// this has the effect of randomising the s1 and s2 values so low or high are not always played in the same order.

println("Sine Source 2 " + s2);

minim = new Minim(this);
out = minim.getLineOut(Minim.STEREO, 4048); // final audio output setup
}

void draw()
{
stroke(255);
if(keyPressed) {

    if(key == 'e' || key == 'E') { // exit, reset and continue where left off features are here.
      exit();
    }
    if(key == 'r' || key == 'R') {
      level = 0;
      levelview = level;

      background(0);

      textFont(font);
      fill(0, 102, 153);
      text("Welcome to the pitch tester application.", 0, 0, 800, 100);
      textFont(font2);
      fill(234, 12, 12);
      text("This app is designed to test your ability to tell the which of two tones is higher pitched then the other.", 0, 105, 800, 800);
      fill(255);
      text("How to use:", 0, 170, 800, 100);
      text("S - Press this to play the tone at the start of a new level. Use as much as you need during each level.", 0, 190, 800, 100);
      fill(134);
      text("To choose which tone is higher in pitch, press 1 or 2 for the 1st or 2nd.", 0, 247, 800, 100);
      textFont(font2);
      fill(255, 21, 0);
      text("Press E to exit.", 600, 450, 250, 50);
      fill(12,229,234);
      text("This is level " + levelview, 0, 310, 800, 100);
    }

    if(key == 'c' || key == 'C') {
      level = level;

      background(0);

      textFont(font);
      fill(0, 102, 153);
      text("Welcome to the pitch tester application.", 0, 0, 800, 100);
      textFont(font2);
      fill(234, 12, 12);
      text("This app is designed to test your ability to tell the which of two tones is higher pitched then the other.", 0, 105, 800, 800);
      fill(255);
      text("How to use:", 0, 170, 800, 100);
      text("S - Press this to play the tone at the start of a new level. Use as much as you need during each level.", 0, 190, 800, 100);
      fill(134);
      text("To choose which tone is higher in pitch, press 1 or 2 for the 1st or 2nd.", 0, 247, 800, 100);
      textFont(font2);
      fill(255, 21, 0);
      text("Press E to exit.", 600, 450, 250, 50);
      fill(12,229,234);
      text("This is level " + levelview, 0, 310, 800, 100);
    }

    if (key == 's' || key == 'S') { // this plays the sound whenever the user wants.

      n1 = low;
      n2 = high; // This takes the new low and high values from the if statements below and converts them to n1 and n2 for clarity as above.

      float[] sinesource = new float [2];
      sinesource[0] = n1;
      sinesource[1] = n2;
      s1 = sinesource[int(random(0,2))];
      println("Sine Source 1 " + s1);

      if(s1 == n1) {
        s2 = n2;
      }
      else {
        s2 = n1;
      } // randomiser as seen above

      println("Sine Source 2 " + s2);

      sine = new SineWave(s1, 0, out.sampleRate()); // this plays the sine waves s1 and s2
      sine2 = new SineWave(s2, 0, out.sampleRate()); // Note there is no amplitude
      out.addSignal(sine);
      out.addSignal(sine2);
      sine.setAmp(0.5);

      delay(1500);
      sine.setAmp(0); // the first sinewave is raised and lowered in volume

      delay(800);
      sine2.setAmp(0.5);
      delay(1400); // as is the second sine wave

      fill(59,234,12);
      text("Which tone was higher in pitch?", 0, 400, 800, 100);
      text("Please choose 1 or 2", 0, 450, 800, 100);
      delay(100);
      sine2.setAmp(0); // User is given the choice. For visual integrety I have chosen the writing to come up 1 tenth of a second before sine2 is ramped down in amp.
    }
}
}

void keyPressed() { // if the first sine was higher in pitch
if(key == '1') {
    if(s1 > s2) { // checkes if true

      println("Yay 1"); // the following updates level information and resets the screen graphics while updating elements like the level counter.

      level = level + 1;
      levelview= level + 1;

      font = loadFont("CenturyGothic-Italic-32.vlw");
      font2 = loadFont("CenturyGothic-Italic-24.vlw");

      background(0);

      font = loadFont("CenturyGothic-Italic-32.vlw");
      font2 = loadFont("CenturyGothic-Italic-24.vlw");

      textFont(font);
      fill(0, 102, 153);
      text("Welcome to the pitch tester application.", 0, 0, 800, 100);
      textFont(font2);
      fill(234, 12, 12);
      text("This app is designed to test your ability to tell the which of two tones is higher pitched then the other.", 0, 105, 800, 800);
      fill(255);
      text("How to use:", 0, 170, 800, 100);
      text("S - Press this to play the tone at the start of a new level. Use as much as you need during each level.", 0, 190, 800, 100);
      fill(134);
      text("To choose which tone is higher in pitch, press 1 or 2 for the 1st or 2nd.", 0, 247, 800, 100);
      textFont(font2);
      fill(255, 21, 0);
      text("Press E to exit.", 600, 450, 250, 50);
      fill(12,229,234);
      text("This is level " + levelview + ".", 0, 310, 800, 100);

      if (level == 1) { // low and high sine freq information spanning the levels.
        low = 450;
        high = 550;
      }
      if (level == 2) {
        low = 480;
        high = 520;
      }
      if (level == 3) {
        low = 490;
        high = 510;
      }
      if (level == 4) {
        low = 494;
        high = 506;
      }
      if (level == 5) {
        low = 497;
        high = 503;
      }
      if (level == 6) {
        low = 498.5;
        high = 501.5;
      }
      if (level == 7) {
        low = 498.5;
        high = 501.5;
      }
      if (level == 8) {
        low = 498.5;
        high = 501.5;
      }
      if (level == 9) {
        low = 499.25;
        high = 500.75;
      }
      if (level == 10) {
        low = 499.25;
        high = 500.75;
      }
      if (level == 11) {
        low = 499.25;
        high = 500.75;
      }
      if (level == 12) {
        low = 499.8125;
        high = 500.1875;
      }
      if (level == 13) {
        low = 499.8125;
        high = 500.1875;
      }
      if (level == 14) {
        low = 499.8125;
        high = 500.1875;
      }
      if (level == 15) {
        background(0);
        text("You completed the 16 levels.", 5, 100, 800, 100);
        text("You can consistently difference two tones as little as " + (high - low)+ " Hz in difference! Well done!", 5, 200, 800, 100);
        text("Press R to reset to level 1. ", 5, 300, 800, 100);
        textFont(font3);
        text("Less than .75 Hz is exceptional.", 450, 320, 250, 200);
        text("Less than 1.5 Hz is very good.", 450, 340, 250, 50);
        text("Less than 6 Hz is normal.", 450, 360, 250, 50);
        text("Less than 12 Hz is below normal.", 450, 380, 250, 50);
        text("Less than 16 Hz is evidence of possible perception problems.", 450, 400, 250, 50);
        fill(255, 21, 0);
        text("Press E to exit.", 600, 450, 250, 50);
      }
    }
    else {
      println("Nay 1"); // Failure - User given options to reset, continure where they were, exit
      level = level;

      font = loadFont("CenturyGothic-Italic-32.vlw");
      font2 = loadFont("CenturyGothic-Italic-24.vlw");

      background(128, 0, 0);
      textFont(font);
      fill(255);
      text("You reached level " + levelview + ".", 5, 100, 800, 100);
      text("You can detect a pitch difference of as little as " + (high - low)+ " Hz.", 5, 200, 800, 100);
      text("Press R to reset to level 1. ", 5, 300, 800, 100);
      if(levelview > 1) {
        textFont(font2);
        text("Press C to continue from level " + levelview + ".", 5, 400, 800, 100);
      }
      textFont(font3);
      text("Less than .75 Hz is exceptional.", 450, 320, 250, 200);
      text("Less than 1.5 Hz is very good.", 450, 340, 250, 50);
      text("Less than 6 Hz is normal.", 450, 360, 250, 50);
      text("Less than 12 Hz is below normal.", 450, 380, 250, 50);
      text("Less than 16 Hz is evidence of possible perception problems.", 450, 400, 250, 50);
      textFont(font2);
      fill(255, 21, 0);
      text("Press E to exit.", 600, 450, 250, 50);
    }
}
else {
    if(key == '2') { // was sine 2 higher in pitch?

      if(s1 < s2) { // checks validity, updates level and resets screen graphics
        println("Yay 2");
        level = level + 1;
        levelview = level + 1;

        background(0);

        font = loadFont("CenturyGothic-Italic-32.vlw");
        font2 = loadFont("CenturyGothic-Italic-24.vlw");

        textFont(font);
        fill(0, 102, 153);
        text("Welcome to the pitch tester application.", 0, 0, 800, 100);
        textFont(font2);
        fill(234, 12, 12);
        text("This app is designed to test your ability to tell the which of two tones is higher pitched then the other.", 0, 105, 800, 800);
        fill(255);
        text("How to use:", 0, 170, 800, 100);
        text("S - Press this to play the tone at the start of a new level. Use as much as you need during each level.", 0, 190, 800, 100);
        fill(134);
        text("To choose which tone is higher in pitch, press 1 or 2 for the 1st or 2nd.", 0, 247, 800, 100);
        textFont(font2);
        fill(255, 21, 0);
        text("Press E to exit.", 600, 450, 250, 50);
        fill(12,229,234);
        text("This is level " + levelview + ".", 0, 310, 800, 100);

        if (level == 1) { // high and low information for sine wave freq
          low = 450;
          high = 550;
        }
        if (level == 2) {
          low = 480;
          high = 520;
        }
        if (level == 3) {
          low = 490;
          high = 510;
        }
        if (level == 4) {
          low = 494;
          high = 506;
        }
        if (level == 5) {
          low = 497;
          high = 503;
        }
        if (level == 6) {
          low = 498.5;
          high = 501.5;
        }
        if (level == 7) {
          low = 498.5;
          high = 501.5;
        }
        if (level == 8) {
          low = 498.5;
          high = 501.5;
        }
        if (level == 9) {
          low = 499.25;
          high = 500.75;
        }
        if (level == 10) {
          low = 499.25;
          high = 500.75;
        }
        if (level == 11) {
          low = 499.25;
          high = 500.75;
        }
        if (level == 12) {
          low = 499.8125;
          high = 500.1875;
        }
        if (level == 13) {
          low = 499.8125;
          high = 500.1875;
        }
        if (level == 14) {
          low = 499.8125;
          high = 500.1875;
        }
        if (level == 15) {
          background(0);
          text("You completed the 16 levels.", 5, 100, 800, 100);
          text("You can consistently difference two tones as little as " + (high - low)+ " Hz in difference! Well done!", 5, 200, 800, 100);
          text("Press R to reset to level 1. ", 5, 300, 800, 100);
          textFont(font3);
          text("Less than .75 Hz is exceptional.", 450, 320, 250, 200);
          text("Less than 1.5 Hz is very good.", 450, 340, 250, 50);
          text("Less than 6 Hz is normal.", 450, 360, 250, 50);
          text("Less than 12 Hz is below normal.", 450, 380, 250, 50);
          text("Less than 16 Hz is evidence of possible perception problems.", 450, 400, 250, 50);
          textFont(font2);
          fill(255, 21, 0);
          text("Press E to exit.", 600, 450, 250, 50);
        }
      }
      else {
        println("Nay 2"); //failure
        level = level;

        font = loadFont("CenturyGothic-Italic-32.vlw");
        font2 = loadFont("CenturyGothic-Italic-24.vlw");

        background(128, 0, 0);
        textFont(font);
        fill(255);
        text("You reached level " + levelview + ".", 5, 100, 800, 100);
        text("You can detect a pitch difference of as little as " + (high - low)+ " Hz.", 5, 200, 800, 100);
        text("Press R to reset to level 1. ", 5, 300, 800, 100);
        if(levelview > 1) {
          textFont(font2);
          text("Press C to continue from level " + levelview + ".", 5, 400, 800, 100);
        }
        textFont(font3);
        text("Less than .75 Hz is exceptional.", 450, 320, 250, 200);
        text("Less than 1.5 Hz is very good.", 450, 340, 250, 50);
        text("Less than 6 Hz is normal.", 450, 360, 250, 50);
        text("Less than 12 Hz is below normal.", 450, 380, 250, 50);
        text("Less than 16 Hz is evidence of possible perception problems.", 450, 400, 250, 50);
        textFont(font2);
        fill(255, 21, 0);
        text("Press E to exit.", 600, 450, 250, 50);
      }
    }
}
}

void stop()
{
out.close();
minim.stop();
super.stop();
}

PhiLho

Re: Tips on making an ear trainer

2 years ago

One generic advice: avoid code duplication.
For example, you load the fonts in setup(), where it must be done, no need to do it in draw() and keyPressed(), even less twice in a row.
You should remove key handling in draw() since you do it with keyPressed(). It will be more consistent.
Instead of successive ifs, you should do cascading ifs: ie. if level == 2, no need to test the other levels, so use else if.
But actually, since the level numbers are successive, you can put the low and high values in arrays:
float[] lowValues = { 0, 450, 480, ... }; // replace ... with real values, of course!
float[] highValues = { 0, 550, 520, ... };
and then you can get the values directly: low = lowValues[level];
Shorter code, and even if it isn't important here, faster. But more important, easier to read and to maintain.

curiousman

Re: Re: Tips on making an ear trainer

2 years ago

Howdy,

Thanks for the advice. I appreciate the feedback.

EDIT:

Looking at your answer and it makes terrific sense. I dont know what I was at loading fonts in the way I was. The low and high values for the array is a great tip!

Moved the key handling thing too. I guess I had the S to play the tones in from the very beginning so I thought nothing of it!
Ill write up that as a little check list so I can check my code afterwards for other projects!

curiousman

Re: Tips on making an ear trainer

2 years ago

No more armys of ifs :p

import ddf.minim.*;
import ddf.minim.signals.*;
Minim minim;
AudioOutput out;
SineWave sine;
SineWave sine2; // Audio setup

PFont font;
PFont font2;
PFont font3;

float n1;
float n2;
float s1;
float s2;

float[] lowValues = {
400, 450, 480, 490, 494, 497, 498.5, 498.5, 498.5, 499.25, 499.25, 499.25, 499.8125, 499.8125, 499.8125, 0
};
float[] highValues = {
600, 550, 520, 510, 506, 503, 501.5, 501.5, 501.5, 500.75, 500.75, 500.75, 500.1875, 500.1875, 500.1875, 0
};

int level;
int levelview; // Sets up level progression information

void setup()
{
println("Void Setup");
size(800, 500,P2D);
background(0);

level = 0;
levelview = level + 1; // As level starts from 0, this adds 1 for user interface

println("Level = " + level);
println("Levelview = " + levelview);
println(" ");
font = loadFont("CenturyGothic-Italic-32.vlw");
font2 = loadFont("CenturyGothic-Italic-24.vlw");
font3 = loadFont("CenturyGothic-Italic-16.vlw"); // Loads fonts of 3 different sizes

textFont(font);
fill(0, 102, 153);
text("Welcome to the pitch tester application.", 0, 0, 800, 100);

textFont(font2);
fill(234, 12, 12);
text("This app is designed to test your ability to tell the which of two tones is higher pitched then the other.", 0, 105, 800, 800);
fill(255);
text("How to use:", 0, 170, 800, 100);
text("S - Press this to play the tone at the start of a new level. Use as much as you need during each level.", 0, 190, 800, 100);
fill(134);
text("To choose which tone is higher in pitch, press 1 or 2 for the 1st or 2nd.", 0, 247, 800, 100);

textFont(font2);
fill(255, 21, 0);
text("Press E to exit.", 600, 450, 250, 50);
fill(12,229,234);
text("This is level " + levelview + ".", 0, 310, 800, 100);

minim = new Minim(this);
out = minim.getLineOut(Minim.STEREO, 4048); // final audio output setup
}

void draw()
{
}

void keyPressed() {

if(keyPressed) {
    if(key == 'e' || key == 'E') { // exit, reset and continue where left off features are here.
      exit();
    }

    if(key == 'r' || key == 'R') {

      println("User has reset the game");
      level = 0;
      levelview = level + 1;
      println("Level = " + level);
      println("Levelview = " + levelview);
      println(" ");

      background(0);
      textFont(font);
      fill(0, 102, 153);
      text("Welcome to the pitch tester application.", 0, 0, 800, 100);

      textFont(font2);
      fill(234, 12, 12);
      text("This app is designed to test your ability to tell the which of two tones is higher pitched then the other.", 0, 105, 800, 800);
      fill(255);
      text("How to use:", 0, 170, 800, 100);
      text("S - Press this to play the tone at the start of a new level. Use as much as you need during each level.", 0, 190, 800, 100);
      fill(134);
      text("To choose which tone is higher in pitch, press 1 or 2 for the 1st or 2nd.", 0, 247, 800, 100);

      textFont(font2);
      fill(255, 21, 0);
      text("Press E to exit.", 600, 450, 250, 50);
      fill(12,229,234);
      text("This is level " + levelview, 0, 310, 800, 100);
    }

    if(key == 'c' || key == 'C') {

      println("User has continued the game after an incorrect answer ");

      println(" ");
      s1 = lowValues[level];
      s2 = highValues[level];
      println("s1 and s2 after being reset to the value array ");
      println("s1 = " + s1 + " s2 = " + s2);
      println(" ");

      background(0);
      textFont(font);
      fill(0, 102, 153);
      text("Welcome to the pitch tester application.", 0, 0, 800, 100);

      textFont(font2);
      fill(234, 12, 12);
      text("This app is designed to test your ability to tell the which of two tones is higher pitched then the other.", 0, 105, 800, 800);
      fill(255);
      text("How to use:", 0, 170, 800, 100);
      text("S - Press this to play the tone at the start of a new level. Use as much as you need during each level.", 0, 190, 800, 100);
      fill(134);
      text("To choose which tone is higher in pitch, press 1 or 2 for the 1st or 2nd.", 0, 247, 800, 100);

      textFont(font2);
      fill(255, 21, 0);
      text("Press E to exit.", 600, 450, 250, 50);
      fill(12,229,234);
      text("This is level " + levelview, 0, 310, 800, 100);
    }

    if (key == 's' || key == 'S') { // this plays the sound whenever the user wants.

      println("User has started playback for level " + levelview);
      n1 = lowValues[level];
      n2 = highValues[level]; // This takes the the level dependant low and high values from the array towards the beginning

      println("n1 before randomising = " + n1);
      println("n2 before randomising = " + n2);

      float[] sinesource = new float [2]; //It converts these values to n1 and n2, which are placed in an array and randomised
      sinesource[0] = n1;                 // This randomisation stops low or high values always being placed first or last.
      sinesource[1] = n2;
      s1 = sinesource[int(random(0,2))];

      if(s1 == n1) { // if s1 = n1 then s2 is n2.
        s2 = n2;
      }
      else { // is s1 = n2 then s2 = n1
        s2 = n1;
      }

      println("s1, After n1/n2 randomisation = " + s1);
      println("s2, After n1/n2 randomisation = " + s2);
      println(" ");

      sine = new SineWave(s1, 0, out.sampleRate()); // this plays the sine waves s1 and s2
      sine2 = new SineWave(s2, 0, out.sampleRate()); // Note there is no amplitude
      out.addSignal(sine);
      out.addSignal(sine2);
      sine.setAmp(0.5);

      delay(1500);
      sine.setAmp(0); // the first sinewave is raised and lowered in volume

      delay(800);
      sine2.setAmp(0.5);
      delay(1400); // as is the second sine wave

      fill(59,234,12);
      text("Which tone was higher in pitch?", 0, 400, 800, 100);
      text("Please choose 1 or 2", 0, 450, 800, 100);
      delay(100);
      sine2.setAmp(0); // User is given the choice. For visual integrety I have chosen the writing to come up 1 tenth of a second before sine2 is ramped down in amp.
    }
}

if(key == '1') {
    if(s1 > s2) {   // if the first sine was higher in pitch
      println("Yay 1");

      println("User has chosen 1, the correct answer"); // the following updates level information and resets the screen graphics while updating elements like the level counter.
      println("Level and levelview were " + level + " and " + levelview);

      level = level + 1;
      levelview = level + 1;
      println("Level and levelview are now " + level + " and " + levelview);

      s1 = s2; // stops people continually pressing 1 or 2 to advance through the levels with no audio.
      println("s1 and s2 have been equalised to avoid cheating. They will be reset to value array later. s1 and s2 = " + s1 + "and " + s2);
      println(" ");
      background(0);

      textFont(font);
      fill(0, 102, 153);
      text("Welcome to the pitch tester application.", 0, 0, 800, 100);
      textFont(font2);
      fill(234, 12, 12);
      text("This app is designed to test your ability to tell the which of two tones is higher pitched then the other.", 0, 105, 800, 800);
      fill(255);
      text("How to use:", 0, 170, 800, 100);
      text("S - Press this to play the tone at the start of a new level. Use as much as you need during each level.", 0, 190, 800, 100);
      fill(134);
      text("To choose which tone is higher in pitch, press 1 or 2 for the 1st or 2nd.", 0, 247, 800, 100);
      textFont(font2);
      fill(255, 21, 0);
      text("Press E to exit.", 600, 450, 250, 50);
      fill(12,229,234);
      text("This is level " + levelview + ".", 0, 310, 800, 100);

      if (level == 15) { //16th level is a congrat screen

        println("User has completed the application");
        background(0);
        text("You completed the 15 levels.", 5, 100, 800, 100);
        text("You can consistently difference two tones as little as 0.375Hz in difference! Well done!", 5, 200, 800, 100);
        text("Press R to reset to level 1. ", 5, 300, 800, 100);
        textFont(font3);
        text("Less than .75 Hz is exceptional.", 450, 320, 250, 200);
        text("Less than 1.5 Hz is very good.", 450, 340, 250, 50);
        text("Less than 6 Hz is normal.", 450, 360, 250, 50);
        text("Less than 12 Hz is below normal.", 450, 380, 250, 50);
        text("Less than 16 Hz is evidence of possible perception problems.", 450, 400, 250, 50);
        fill(255, 21, 0);
        text("Press E to exit.", 600, 450, 250, 50);
      }
    }
    else {
      println("Nay 1"); // Failure - User given options to reset, continure where they were, exit

      if (s1 == s2) {
        println("User has pressed 1 or 2 after getting a correct answer, before hearing new set of sine waves either by accident or to cheat.");
        println(" ");
      }
      else {
        println("User has chosen 1, the incorrect answer");
        println(" ");
        background(128, 0, 0);
        textFont(font);
        fill(255);
        text("You reached level " + levelview + ".", 5, 100, 800, 100);
        text("You can detect a pitch difference of as little as " + (highValues[level] - lowValues[level])+ " Hz.", 5, 200, 800, 100);
        text("Press R to reset to level 1. ", 5, 300, 800, 100);
        if(levelview > 1) {
          textFont(font2);
          text("Press C to continue from level " + levelview + ".", 5, 400, 800, 100);
        }
        textFont(font3);
        text("Less than .75 Hz is exceptional.", 450, 320, 250, 200);
        text("Less than 1.5 Hz is very good.", 450, 340, 250, 50);
        text("Less than 6 Hz is normal.", 450, 360, 250, 50);
        text("Less than 12 Hz is below normal.", 450, 380, 250, 50);
        text("Less than 16 Hz is evidence of possible perception problems.", 450, 400, 250, 50);
        textFont(font2);
        fill(255, 21, 0);
        text("Press E to exit.", 600, 450, 250, 50);
      }
    }
}
else {
    if(key == '2') { // was sine 2 higher in pitch?

      if(s1 < s2) {   // if the first sine was higher in pitch
        println("Yay 1");

        println("User has chosen 1, the correct answer"); // the following updates level information and resets the screen graphics while updating elements like the level counter.
        println("Level and levelview were " + level + " and " + levelview);

        level = level + 1;
        levelview = level + 1;
        println("Level and levelview are now " + level + " and " + levelview);

        s1 = s2; // stops people continually pressing 1 or 2 to advance through the levels with no audio.
        println("s1 and s2 have been equalised to avoid cheating. They will be reset to value array later. s1 and s2 = " + s1 + "and " + s2);
        println(" ");
        background(0);

        textFont(font);
        fill(0, 102, 153);
        text("Welcome to the pitch tester application.", 0, 0, 800, 100);
        textFont(font2);
        fill(234, 12, 12);
        text("This app is designed to test your ability to tell the which of two tones is higher pitched then the other.", 0, 105, 800, 800);
        fill(255);
        text("How to use:", 0, 170, 800, 100);
        text("S - Press this to play the tone at the start of a new level. Use as much as you need during each level.", 0, 190, 800, 100);
        fill(134);
        text("To choose which tone is higher in pitch, press 1 or 2 for the 1st or 2nd.", 0, 247, 800, 100);
        textFont(font2);
        fill(255, 21, 0);
        text("Press E to exit.", 600, 450, 250, 50);
        fill(12,229,234);
        text("This is level " + levelview + ".", 0, 310, 800, 100);

        if (level == 15) { //16th level is a congrat screen

          println("User has completed the application.");
          background(0);
          text("You completed the 15 levels.", 5, 100, 800, 100);
          text("You can consistently difference two tones as little as 0.375Hz in difference! Well done!", 5, 200, 800, 100);
          text("Press R to reset to level 1. ", 5, 300, 800, 100);
          textFont(font3);
          text("Less than .75 Hz is exceptional.", 450, 320, 250, 200);
          text("Less than 1.5 Hz is very good.", 450, 340, 250, 50);
          text("Less than 6 Hz is normal.", 450, 360, 250, 50);
          text("Less than 12 Hz is below normal.", 450, 380, 250, 50);
          text("Less than 16 Hz is evidence of possible perception problems.", 450, 400, 250, 50);
          fill(255, 21, 0);
          text("Press E to exit.", 600, 450, 250, 50);
        }
      }
      else {
        println("Nay 2"); // Failure - User given options to reset, continure where they were, exit

        if (s1 == s2) {
          println("User has pressed 1 or 2 after getting a correct answer, before hearing new set of sine waves either by accident or to cheat.");
          println(" ");
        }
        else {
          println("User has chosen 2, the incorrect answer");
          println(" ");
          background(128, 0, 0);
          textFont(font);
          fill(255);
          text("You reached level " + levelview + ".", 5, 100, 800, 100);
          text("You can detect a pitch difference of as little as " + (highValues[level] - lowValues[level])+ " Hz.", 5, 200, 800, 100);
          text("Press R to reset to level 1. ", 5, 300, 800, 100);
          if(levelview > 1) {
            textFont(font2);
            text("Press C to continue from level " + levelview + ".", 5, 400, 800, 100);
          }
          textFont(font3);
          text("Less than .75 Hz is exceptional.", 450, 320, 250, 200);
          text("Less than 1.5 Hz is very good.", 450, 340, 250, 50);
          text("Less than 6 Hz is normal.", 450, 360, 250, 50);
          text("Less than 12 Hz is below normal.", 450, 380, 250, 50);
          text("Less than 16 Hz is evidence of possible perception problems.", 450, 400, 250, 50);
          textFont(font2);
          fill(255, 21, 0);
          text("Press E to exit.", 600, 450, 250, 50);
        }
      }
    }
}
}

void stop()
{
out.close();
minim.stop();
super.stop();
}