Timing problems

Programming Questions

validvalue

in Programming Questions • 3 years ago

Hi there, newbie speaking.

I'm writing a program with two timers that should work together: when one ends, the other one starts, and some booleans are changed. Now, all works well with timer1, but timer2 fails miserably. When it's done, it's supposed to change a bool from false to true, but it just doesn't. And I am not sure what I am doing wrong!

Here's the code, any help will be much appreciated!

//testing Timer class
Timer scoreTimer;
Timer cooldownTimer;
PFont font;
Boolean available;
int score = 0;
void setup()
{
size (400, 400);
scoreTimer = new Timer(5);
cooldownTimer = new Timer(3);
font = createFont("Helvetica", 22);
textFont(font);
available = true;
}
void draw()
{
background(0);
stroke(255);
line(200, 0, 200, 400);
fill(255, 0, 0);
text((scoreTimer.time), 100, 100);
fill(0, 255, 0);
text(cooldownTimer.time, 300, 100);
checkTimers();
if(mouseX > 200 && available == false)
{
score();
}
if(scoreTimer.isDone)
{
cooldown();
}
if(cooldownTimer.isDone)
{
available = true;
}
println(available);
}
void checkTimers()
{
if(scoreTimer.running)
{
scoreTimer.work();
}
if(cooldownTimer.running)
{
cooldownTimer.work();
}
}
void score()
{
scoreTimer.start();
available = false;
}
void cooldown()
{
cooldownTimer.start();
}
/* Very basic timer class
takes one parameter, max. time in sec.
*/
class Timer
{
int time, startTime, currentTime, maxTime;
Boolean running, isDone;
Timer(int _maxTime)
{
maxTime = _maxTime;
isDone = false;
stop();
}
void reset()
{
currentTime = startTime = millis()/1000;
time = currentTime - startTime;
}
void start()
{
isDone = false;
running = true;
}
void stop()
{
running = false;
}
void work()
{
if(running)
{
currentTime = millis()/1000;
time = currentTime - startTime;
if(time >= maxTime)
{
isDone = true;
reset();
stop();
}
}
}
}

Replies(2)

cedrickie..

Re: Timing problems

3 years ago

its hard to tell whats going on.
I had to set available to false in setup to make them work at all.
Now they start to count, depending on where my cursors is.

But what do you want? how should they behave? Could you explain it a bit better, makes it easier to understand and help.

validvalue

Re: Timing problems

3 years ago

Sorry, my bad - really crappy code.

The idea:

if(available)

start scoreTimer

when scoreTimer is done (5 sec)

stop scoreTimer

available = false

start cooldownTimer

when cooldownTimer is done

available = true

So the point is to make a cooldown system - the problem is that I am using a boolean to mark the end of a timer period, but the boolean cooldownTimer.isDone is never set to true. That is what doesn't work.

Just to make things more clear: this is a scoring system for a game. If the there are points available, the player will be able to get them for 5 seconds, then there is a cooldown period where the points are not available.

does this make better sense?

thanks!

EDIT: and to top it all, there is a typo in the code - this is the version that does not work, I think should:

//testing Timer class
Timer scoreTimer;
Timer cooldownTimer;
PFont font;
Boolean available;
int score = 0;
void setup()
{
size (400, 400);
scoreTimer = new Timer(5);
cooldownTimer = new Timer(3);
font = createFont("Helvetica", 22);
textFont(font);
available = true;
}
void draw()
{
background(0);
stroke(255);
line(200, 0, 200, 400);
fill(255, 0, 0);
text((scoreTimer.time), 100, 100);
fill(0, 255, 0);
text(cooldownTimer.time, 300, 100);
checkTimers();
if(mouseX > 200 && available == true)
{
score();
}
if(scoreTimer.isDone)
{
cooldown();
}
if(cooldownTimer.isDone)
{
available = true;
}
println(available);
}
void checkTimers()
{
if(scoreTimer.running)
{
scoreTimer.work();
}
if(cooldownTimer.running)
{
cooldownTimer.work();
}
}
void score()
{
scoreTimer.start();
available = false;
}
void cooldown()
{
cooldownTimer.start();
}

With the appropriate timer class

/* Very basic timer class
takes one parameter, max. time in sec.
remember to make it run on main loop!
*/
class Timer
{
int time, startTime, currentTime, maxTime;
Boolean running, isDone;
Timer(int _maxTime)
{
maxTime = _maxTime;
isDone = false;
stop();
}
void reset()
{
currentTime = startTime = millis()/1000;
time = currentTime - startTime;
}
void start()
{
isDone = false;
running = true;
}
void stop()
{
running = false;
}
void work()
{
if(running)
{
currentTime = millis()/1000;
time = currentTime - startTime;
if(time >= maxTime)
{
isDone = true;
reset();
stop();
}
}
}
}

Top Reply

Timing problems

Replies(2)

Re: Timing problems

Re: Timing problems

Statistics

Tags

Actions

Related Posts