Speed parameters stipulated in class not being applied

Programming Questions

katiebee1..

Speed parameters stipulated in class not being applied

in Programming Questions • 7 months ago

Hi I am having an issue with a rain generator, it worked fine until I added extra function to change the number of drops periodically. Now the speed parameters stipulated in the class Drop not being applied.

Hope someone can help me!

Thanks,

Katie

int savedTime;
int totalTime = 60000;
int passedTime;
int num_drops1 = 4;
int num_drops2 = 16;
int num_drops3 = 32;
int num_drops4 = 64;
int num_drops5 = 128;
int num_drops6 = 246;
int num_drops7 = 400;
void setup()
{
size(500, 500);
smooth();
noStroke();
savedTime = millis();
}
void draw() {
background(0);
passedTime = millis() - savedTime;
if (passedTime <= 7500) {
rain1();
}
else if ((passedTime <= 15000) && (passedTime > 7500)) {
rain2();
}
else if ((passedTime <= 22500) && (passedTime > 15000)) {
rain3();
}
else if ((passedTime <= 30000) && (passedTime > 22500)) {
rain4();
}
else if ((passedTime <= 37500) && (passedTime > 30000)) {
rain5();
}
else if ((passedTime <= 45000) && (passedTime > 37500)) {
rain6();
}
else if ((passedTime <= 60000) && (passedTime > 45000)) {
rain1();
}
else {
stop();
savedTime = millis(); // Save the current time to restart the timer!
}
println (passedTime + " ") ;
}
////////////////////////////////// RAIN FUNCTION //////////////////////////////////
void rain1() {
Drop[] myDrops = new Drop[num_drops1];
for (int i = 0; i<num_drops1; i++)
{
myDrops[i] = new Drop();
myDrops[i].posX = random(0, width);
myDrops[i].posY = random(0, height);
myDrops[i].speedX = random(0, 3);
}
if (passedTime < totalTime) {
for (int i = 0; i<num_drops1; i++)
{
myDrops[i].update();
}
}
}
void rain2() {
Drop[] myDrops = new Drop[num_drops2];
for (int i = 0; i<num_drops2; i++)
{
myDrops[i] = new Drop();
myDrops[i].posX = random(0, width);
myDrops[i].posY = random(0, height);
myDrops[i].speedX = random(0, 3);
}
if (passedTime < totalTime) {
for (int i = 0; i<num_drops2; i++)
{
myDrops[i].update();
}
}
}
void rain3() {
Drop[] myDrops = new Drop[num_drops3];
for (int i = 0; i<num_drops3; i++)
{
myDrops[i] = new Drop();
myDrops[i].posX = random(0, width);
myDrops[i].posY = random(0, height);
myDrops[i].speedX = random(0, 3);
}
if (passedTime < totalTime) {
for (int i = 0; i<num_drops3; i++)
{
myDrops[i].update();
}
}
}
void rain4() {
Drop[] myDrops = new Drop[num_drops4];
for (int i = 0; i<num_drops4; i++)
{
myDrops[i] = new Drop();
myDrops[i].posX = random(0, width);
myDrops[i].posY = random(0, height);
myDrops[i].speedX = random(0, 3);
}
if (passedTime < totalTime) {
for (int i = 0; i<num_drops4; i++)
{
myDrops[i].update();
}
}
}
void rain5() {
Drop[] myDrops = new Drop[num_drops5];
for (int i = 0; i<num_drops5; i++)
{
myDrops[i] = new Drop();
myDrops[i].posX = random(0, width);
myDrops[i].posY = random(0, height);
myDrops[i].speedX = random(0, 3);
}
if (passedTime < totalTime) {
for (int i = 0; i<num_drops5; i++)
{
myDrops[i].update();
}
}
}
void rain6() {
Drop[] myDrops = new Drop[num_drops6];
for (int i = 0; i<num_drops6; i++)
{
myDrops[i] = new Drop();
myDrops[i].posX = random(0, width);
myDrops[i].posY = random(0, height);
myDrops[i].speedX = random(0, 3);
}
if (passedTime < totalTime) {
for (int i = 0; i<num_drops6; i++)
{
myDrops[i].update();
}
}
}
void rain7() {
Drop[] myDrops = new Drop[num_drops7];
for (int i = 0; i<num_drops7; i++)
{
myDrops[i] = new Drop();
myDrops[i].posX = random(0, width);
myDrops[i].posY = random(0, height);
myDrops[i].speedX = random(0, 3);
}
if (passedTime < totalTime) {
for (int i = 0; i<num_drops7; i++)
{
myDrops[i].update();
}
}
}
////////////////////////////////// RAIN CLASS ///////////////////////////////////////
class Drop
{
//properties
int myDiameter = 4;
float posX = 250;
float posY = 250;
float speedX = 0.1;
float speedY = 0;
float gravity = 0.05;
//method
void update()
{
//ellipse(posX, posY, myDiameter, myDiameter);
fill(#62B7FF, 200);
ellipse(posY, posX, myDiameter, myDiameter);
posX += speedX + 0.01;
speedX = speedX + gravity;
if (posX > width)
{
posX = 0;
speedX = speedX*-.10;
}
}
}
////////////////////////////////// END RAIN CLASS ///////////////////////////////////

Replies(7)

PhiLho

Re: Speed parameters stipulated in class not being applied

7 months ago

Wow, copy & paste nightmare!
You re-create all the drops on each frame, so you update them only once...
You should have a look at ArrayList to better manage the variable number of drops. You can add or remove them when you need it.

katiebee1..

Re: Re: Speed parameters stipulated in class not being applied

7 months ago

Ok thanks.

I never have understood arrays :(

Chrisir

Re: Speed parameters stipulated in class not being applied

7 months ago

ok, array is easy

an array is a list

look at your code:

int num_drops1 = 4;
int num_drops2 = 16;
int num_drops3 = 32;
int num_drops4 = 64;
int num_drops5 = 128;
int num_drops6 = 246;
int num_drops7 = 400;

this looks like a list already

let's make it to an array

so your list has the name num_drops

now each line in the list has a number:

line number 1, number 2 etc.

like on a shopping list each line has a different value (apple banana...)

in your case the values are : 4, 16, 32 etc.

so instead of

int num_drops1 = 4;
int num_drops2 = 16;
int num_drops3 = 32;
int num_drops4 = 64;
int num_drops5 = 128;
int num_drops6 = 246;
int num_drops7 = 400;

we say :

int[] num_drops = new int [7];
num_drops[1] = 4;
num_drops[2] = 16;
num_drops[3] = 32;
num_drops[4] = 64;
num_drops[5] = 128;
num_drops[6] = 246;
num_drops[7] = 400;

now we can use num_drops[5] to get 128

where 5 is the line number

now you can reduce the many functions to just one and give the num_drops[5] as a parameter

since the 5 (line number) changes we say

num_drops[currentIndex]

currentIndex or current line number is a global var and we change this accordingly to the time that has passed (switch)

But I think your error is caused somewhere else...

let me see

has to do with the timer, you use in draw() AND in the functions

katiebee1..

Re: Re: Speed parameters stipulated in class not being applied

7 months ago

Thanks for your help! I should be able to figure it out now, I am probably just missing it with all the mess in my current code.

PhiLho

Re: Speed parameters stipulated in class not being applied

7 months ago

" But I think your error is caused somewhere else..."
As I wrote, the error comes from that the drops are recreated on each frame, instead of persisting between draw() calls.

Chrisir

Re: Speed parameters stipulated in class not being applied

7 months ago

oh, sorry!

PhiLho

Re: Speed parameters stipulated in class not being applied

7 months ago

No problem, I just wanted to avoid you extra work...

Top Reply