Rookie needs someone to correct his simple sketch

jimrolland

Rookie needs someone to correct his simple sketch

in Contributed Library Questions • 3 years ago

Hello everybody!

I'd like to play 4 different things (mov. and wav. files) depending on the distance given by a proximetre.

I wrote this sketch but there are errors inside!!! Can you help me to correct it?

I thank you!
JM
____________________________________________
import rwmidi.*;
import ddf.minim.*;
import processing.video.*;

MidiInput input;
Movie myMovie;
Movie myMovie2;

AudioPlayer machanson;
AudioPlayer machanson2;
Minim minim;

float valeur;

void setup() {

{
input = RWMidi.getInputDevices()[0].createInput(this);
int[] valeur = new int[4];
int numero;
}

minim = new Minim(this);
    machanson = minim.loadFile("migration2.wav");
    machanson2 = minim.loadFile("migration1.wav");

    myMovie=new Movie(this, "migration1.mov");
    myMovie2=new Movie(this, "migration2.mov");

myMovie.read();
myMovie2.read();

size(800,600);
background(0);
}

void draw() {

if (valeur>54 && valeur<60) {machanson.play(); myMovie.read();}
if (valeur>59 && valeur<75) {machanson.play(); myMovie2.read();}
if (valeur>74 && valeur<116) {machanson2.play(); myMovie2.read();}

}

void stop() {

machanson.close();
machanson2.close();
minim.stop();
super.stop();

}

Replies(3)

PhiLho

Re: Rookie needs someone to correct his simple sketch

3 years ago

"Errors inside" is a good slogan (?) but not very informative... In the future, you should report the error message and where it happens.

Well, here it is obvious enough:
1) As said in the reference, make size() call the first instruction of setup().
2) valeur in setup() is useless, not used (and confusing with the global variable).
3) So is numero.
4) The main issue is probably the closing brace after numero's declaration...

General advice: use millis()'s value to trigger events based on time. You can also use frameCount (no need to update a variable yourself) but it is less reliable.

jimrolland

Re: Rookie needs someone to correct his simple sketch

3 years ago

Thanks very much phi!

I corrected the sketch with your advices :

____________________________________________________________________

import rwmidi.*;

import ddf.minim.*;

import processing.video.*;

MidiInput input;

Movie myMovie;

Movie myMovie2;

AudioPlayer machanson;

AudioPlayer machanson2;

Minim minim;

float valeur;

void setup() {

size(800,600);

background(0);

input = RWMidi.getInputDevices()[0].createInput(this);

minim = new Minim(this);

machanson = minim.loadFile("migration2.wav");

machanson2 = minim.loadFile("migration1.wav");

myMovie=new Movie(this, "migration1.mov");

myMovie2=new Movie(this, "migration2.mov");

myMovie.read();

myMovie2.read();

}

void draw() {

if (valeur>54 && valeur<60) {machanson.play(); myMovie.read();}

if (valeur>59 && valeur<75) {machanson.play(); myMovie2.read();}

if (valeur>74 && valeur<116) {machanson2.play(); myMovie2.read();}

}

void stop() {

machanson.close();

machanson2.close();

minim.stop();

super.stop();

}

__________________________________________________________________

Now, no error message appears but nothing happens (I mean that even when the values given by the proximeter are > 54, the videos aren't played). I think that the problem comes from the fact I didn't link the "valeur" to the proximeter.... thanks for your help!

amnon.owed

Re: Rookie needs someone to correct his simple sketch

3 years ago

There is nothing changing valeur in this sketch, it remains at 0. So to fix this problem, you should add something to draw() like valeur++; Or better yet, as phi.lho pointed out, start using frameCount or millis() instead of your own valeur.