Questing regarding Pie Graph

General Discussion Other

jinzo64

in General Discussion • Other • 1 year ago

Hey everyone. I used the pie graph example to construct my own, and I have modified it to change every 3 seconds. For some reason, the program is not reading my data. (which i made sure all equals to 360 degrees). Could someone please help me out?

//Original Pie Graph by Ira Greenberg. http://processing.org/learning/basics/piechart.html

void setup(){
size(500, 500);
background(255);
smooth();
noStroke();
}

void draw(){
float diameter = min(width, height) * 0.75;
// it creates a float variable (a decimal value used in processing more often than double) set equal to the minimum width and height of the graphic * 3/4
//int[] angs = {30, 10, 45, 35, 60, 38, 75, 67};
float[] angs = {141,180,32,1,6};
//float[] angs = {141,120,32,31,36};
// formula for angles (data point/ total of the data points) * 360
float time = 0;
float lastAng = 0;

if (time == 1)
{
angs = new float[]{168,157,27,4,4};
}
if (time == 2)
{
angs =new float[]{ 184,137,33,5,1};
}
if (time == 3)
{
angs = new float[]{232, 116,6,3,3} ;
}

if (time == 4)
{
angs = new float[]{236,91,28,3,2};
}

for (int i = 0; i < angs.length; i++){

if (i==1)
{
fill (255,0,0) ;
}
if (i==2 )
{
fill (255,100,0) ;
}
if (i==3)
{
fill (255,100,255) ;
}
if (i==4)
{
fill (255,255,0) ;
}
if (i==5)
{
fill (0,255,0);
}

//fill(angs[i] * 3.0);
arc(width/2, height/2, diameter, diameter, lastAng, lastAng+radians(angs[i]));
lastAng += radians(angs[i]);
time= time + 1;
//delay (3000);

}
}

Replies(10)

jbum

Re: Questing regarding Pie Graph

1 year ago

In your code, you are initializing your variable time to zero, and never changing it.

You can use the millis() function to make a second counter, like so:

int time = millis()/1000;

Also, your code is not indented to show structure, which makes it very hard to read.

Instead of doing this

{

stuff

}

do this

{

stuff

}

jinzo64

Re: Questing regarding Pie Graph

1 year ago

I thought I was changing the time variable by having the "time = time + 1" at the bottom. I will try you suggestions Thanks

jinzo64

Re: Questing regarding Pie Graph

1 year ago

I am still having problems with the data not being represented correctly. Also I want the graph to loop, but it does not. Can anyone please help me out?

//Original Pie Graph by Ira Greenberg. http://processing.org/learning/basics/piechart.html

void setup(){
size(500, 500);
background(255);
smooth();
noStroke();
}

void draw(){
float diameter = min(width, height) * 0.75;
// it creates a float variable (a decimal value used in processing more often than double) set equal to the minimum width and height of the graphic * 3/4
//int[] angs = {30, 10, 45, 35, 60, 38, 75, 67};
float[] angs = {141,180,32,1,6};
//float[] angs = {141,120,32,31,36};
// formula for angles (data point/ total of the data points) * 360
//float time = 0;
float lastAng = 0;
int time = millis()/1000;

if (time == 1)
{
angs = new float[]{168,157,27,4,4};
}
if (time == 2)
{
angs =new float[]{ 184,137,33,5,1};
}
if (time == 3)
{
angs = new float[]{232, 116,6,3,3} ;
}

if (time == 4)
{
angs = new float[]{236,91,28,3,2};
}

if (time < 5)
{
time = 0 ;
}

for (int i = 0; i < angs.length; i++){

if (i==1)
{
fill (255,0,0) ;
}
if (i==2 )
{
fill (255,100,0) ;
}
if (i==3)
{
fill (255,100,255) ;
}
if (i==4)
{
fill (255,255,0) ;
}
if (i==5)
{
fill (0,255,0);
}

//fill(angs[i] * 3.0);
arc(width/2, height/2, diameter, diameter, lastAng, lastAng+radians(angs[i]));
lastAng += radians(angs[i]);
time= time + 1;
//delay (3000);

}
}

jbum

Re: Questing regarding Pie Graph

1 year ago

Oh, I missed the time = time + 1 bit.

Okay, make time a global variable, by declaring it outside of your draw function. Just set it to zero. Then use the modulo operator it make it loop.

int time = 0;

draw()

{

// same as before, but without declaring the time variable

time = time + 1;

time = time % 6;

// OR time = (time + 1) % 6;

}

Your original problem was by declaring time as a local variable inside draw. It was getting reset to zero every time draw was called. Read up on the difference between local and global variables.

jinzo64

Re: Questing regarding Pie Graph

1 year ago

Thats screws things up. This millis works fine. My main problem is having the data not being represented properly. For example my first set of values are float[] angs = {141,180,32,1,6}; but the graph does not reflect this. The red part is 180 and the orange part is under 180, Can you help me?

jbum

Re: Questing regarding Pie Graph

1 year ago

You can also loop the millis() based time by using

time = time % 5;

after the line that sets it via mllis. This will make it go 0,1,2,3,4,0,1,2,3,4,0,1,2,3,4, etc.

Now, your next problem is caused by your perception that you count by going

1,2,3,4,5

That's how humans do it. Silly humans.

Computers do it this way:

0,1,2,3,4

Silly computers. At any rate, a lot of mathematical things turn out to be simpler if you start counting from zero. For example when you are born, you are not quite yet a year old. You reach 1 years old after a year has elapsed. Similar, the millis() function doesn't reach 1000 (or one second) until one second has elapsed, so the time value will go 0,1,2,3 etc.

So change your statements that are checking the value of time to look for 0-4, instead of 1 to 5, and things should behave better. At the moment, you aren't checking for zero, which is the first value, and you are checking for 5, which after you fix looping, won't ever occur.

jinzo64

Re: Questing regarding Pie Graph

1 year ago

Here's the thing. I set the original values (thats 0) then I did 1 -4 in the if statements. It doesn't work with having all the if statments be 0 to 4. I retry it anyways.

jinzo64

Re: Questing regarding Pie Graph

1 year ago

Nope, I still does not work. This issue also is present even without all the changing stats thing. The data will not be represented correctly.

//Original Pie Graph by Ira Greenberg. http://processing.org/learning/basics/piechart.html

void setup(){
size(900, 500);
background(255);
smooth();
noStroke();

}

void draw(){
float diameter = min(width, height) * 0.75;
// it creates a float variable (a decimal value used in processing more often than double) set equal to the minimum width and height of the graphic * 3/4
//int[] angs = {30, 10, 45, 35, 60, 38, 75, 67};
float[] angs = {141,180,32,1,6};
//float[] angs = {141,120,32,31,36};
// formula for angles (data point/ total of the data points) * 360
//float time = 0;
float lastAng = 0;
int time = millis()/1000;
//PImage b = loadImage("dj.jpg");
//image(b, 10, 27.5, 600,450);

//if (time == 1)
//{
// angs = new float[]{168,157,27,4,4};
//}
//else if (time == 2)
//{
// angs =new float[]{ 184,137,33,5,1};
//}
//else if (time == 3)
//{
// angs = new float[]{232, 116,6,3,3} ;
//}
//
//else if (time == 4)
//{
// angs = new float[]{236,91,28,3,2};
//}
//
//else
//{
// time = 0 ;
//}

for (int i = 0; i < angs.length; i++){

if (i==1)
{
fill (255,0,0) ;
}
else if (i==2 )
{
fill (255,100,0) ;
}
else if (i==3)
{
fill (255,100,255) ;
}
else if (i==4)
{
fill (255,255,0) ;
}
else if (i==5)
{
fill (0,255,0);
}

//fill(angs[i] * 3.0);
arc(width/2-200, height/2, diameter, diameter, lastAng, lastAng+radians(angs[i]));
lastAng += radians(angs[i]);
//time= time + 1;
//delay (3000);
time = time % 5;

}
}

// I changed the size for visual purposes. please help me out

jbum

Re: Questing regarding Pie Graph

1 year ago

Please use auto format (via the edit menu) on your code before posting it here.

try this

void draw() {

float diameter = min(width, height) * 0.75;

float[] angs = {

141, 180, 32, 1, 6

};

float lastAng = 0;

int time = millis()/1000;

time = time % 5; // you had this line too low. time gets reinitialized on the line above.

if (time == 0) // you commented this out. you need it

{

angs = new float[]{168,157,27,4,4};

}

else if (time == 1)

{

angs =new float[]{ 184,137,33,5,1};

}

else if (time == 2)

{

angs = new float[]{232, 116,6,3,3} ;

}

else if (time == 3)

{

angs = new float[]{236,91,28,3,2};

}

else

{

time = 0 ;

}

for (int i = 0; i < angs.length; i++) {

if (i==0) // you were using 1s here.

{

fill (255, 0, 0) ;

}

else if (i==1 )

{

fill (255, 100, 0) ;

}

else if (i==2)

{

fill (255, 100, 255) ;

}

else if (i==3)

{

fill (255, 255, 0) ;

}

else

{

fill (0, 255, 0);

}

arc(width/2-200, height/2, diameter, diameter, lastAng, lastAng+radians(angs[i]));

lastAng += radians(angs[i]);

}

jinzo64

Re: Questing regarding Pie Graph

1 year ago

Wow. I can't thank you enough for this. You have been a great help. Just wicked.