PShape array assigned to createShape(void) issue

Programming Questions

sachaamm

PShape array assigned to createShape(void) issue

in Programming Questions • 8 months ago

Hello guys

just one question : im in trouble with the createShape function (void)

createShape();

i call an pshape array

PShape[] test = new PShape [20];

in a class

class ShapeClass

when i assign vertex to a custom PShape created from the PShape array i can't only initialise in the class the createShape function like this:

class Ball {

float x;

float y;

float w;

float h;

final float fx=0;

final float fy=0;

int index = 0;

PShape[] test = new PShape[8] ;

Ball(float tempX, float tempY, float tempW, float tempH, int index_) {

x = tempX;

y = tempY;

w = tempW;

h = tempH;

index = index_;

}

void initShape() {

for (int i = 0; i<8; i++) {

test[i] = createShape();

test[i].fill(0);

}

void setShape(int currentNombre, boolean start) {

currentNombre = index+1;

println(currentNombre);

for (int i=0; i<currentNombre; i++) {

if (currentNombre>= 0) {

//test[currentNombre]=createShape();

test[currentNombre].vertex(this.x, this.y);

test[currentNombre].vertex(this.x+20, this.y);

test[currentNombre].vertex(this.x+20, this.y+20);

test[currentNombre].vertex(this.x, this.y+20);

}

test[currentNombre].end(CLOSE);

shape(test[currentNombre]);

}

i call initshape() in void setup() and setShape() in void draw(); but it still doesn't work : i get a NPE...

Need I use createShape() in each frame?

So i can't assign createShape to my pshape array in void setup()? This is a serious issue because he burns so much memory ...

Please, I need your help sir

Thanks in advance.

Replies(6)

GoToLoop

Re: PShape array assigned to createShape(void) issue

8 months ago

I barely know anything about it! But AFAIK, there's no createShape(), only loadShape() from an .svg file!

Perhaps what you want is a PGraphics rather than a PShape?

Here's some tweaks I've made to your class before gotten suspicious about the whole thing!

class Ball {
  float x, y, w, h;
  int idx;

  final static byte sizeVertex = 20;
  final static byte numShapes = 8;
  final PShape[] test = new PShape[numShapes];

  Ball(float xx, float yy, float ww, float hh, int index) {
    x = xx;
    y = yy;
    w = ww;
    h = hh;

    idx = index;
  }

  void initShape() {
    for (int i=0; i!=numShapes; i++) {
      test[i] = new PShape();
      test[i].fill(0);
    }
  }

  void setShape(int curIdx, boolean start) {
    curIdx = idx+1;
    println(curIdx);

    for (PShape t: test) {
      t.beginShape();

      t.vertex(x, y);
      t.vertex(x+sizeVertex, y);
      t.vertex(x+sizeVertex, y+sizeVertex);
      t.vertex(x, y+sizeVertex);

      t.end(CLOSE);

      shape(t);
    }
  }
}

sachaamm

Re: PShape array assigned to createShape(void) issue

8 months ago

i want to use a pshape to use basic textures models like this:

PShape test;

int Ax, Ay, Aw, Ah;

Control[] Rect;

void setup() {

size(800, 500, P3D);

PImage tex = loadImage("333.jpg");

Rect = new Control[4];

Ax=120-25;

Ay=120-5;

Aw=Ah=25;

test = createShape();

test.noStroke();

test.texture(tex);

test.tint(255);

test.vertex(120, 120, 0, 0, 0);

test.vertex(width-20, 120, 0, tex.width, 0);

test.vertex(width-20, height-20, 0, tex.width, tex.height);

test.vertex(120, height-20, 0, 0, tex.height);

test.end();

for (int i = 0; i<4;i++) {

Rect[i] = new Control(120+int(random(width-240)), 120+int(random(height-240)), i );

}

void draw() {

background(255);

for (int i = 0; i<4;i++) {

Rect[i].Check(test);

Rect[i].display();

}

// for(Control control : Rect){

// control.display();

// }

pushStyle();

noFill();

rect(Ax, Ay, Aw, Ah);

popStyle();

if (keyPressed&&key=='1') {

Rect[1] = new Control(mouseX, mouseY,1);

}

if (pressA()) {

Ax = mouseX-10;

Ay=mouseY-10;

test.setVertex(0, mouseX, mouseY, 0);

}

shape(test);

}

boolean pressA() {

if (mousePressed&&mouseX>Ax&&mouseY>Ay&&mouseX<Ax+Aw&&mouseY<Ay+Ah) {

return true;

}

else {

return false;

}

class Control {

int mx;

int my;

int index;

Control(int mx_, int my_, int index_) {

mx= mx_;

my = my_;

index = index_;

}

boolean Check(PShape test) {

int Rectselected = 1;

if (mousePressed&&mouseX>this.mx&&this.mx+25>mouseX&&mouseY<this.my+25&&this.my<mouseY) {

this.mx=mouseX-10;

this.my=mouseY-10;

test.setVertex(this.index, mouseX-10, mouseY-10, 0);

return true;

}

else {

return false;

}

void display() {

noFill();

stroke(255, 0, 0);

rect(mx, my, 25, 25);

}

////////////////////////////

i want to make a little program using this example above integrated to an arraylist.

so now i got the structure of what i want to do but it's at this point a performance issue: i need to use an efficient code because my sketch is runing so slowin down...

I'm not an experimented programmer so i need to perform my sketch and use the most efficient method .

so i use arraylist class using pshape arrays, but after the creating of the fifth object, my frameRate decrease to 15 frames...

i don't experiment a lot with Pggraphics so if them using could upgrade the performances of my sketch it could be great.

I also tried this:

PImage img;

int currentNombre = 0;

int[] pos, posY;

int nombre;

void setup(){

size(500,500,P3D);

img = loadImage("333.jpg");img.resize(800,500);

nombre=330;

pos = new int[nombre];

posY = new int[nombre];

background(255);

}

void draw(){

tint(255,255,255,20);

fill(mouseX);

println(currentNombre);

for (int i=0; i< currentNombre; i++) {

for(int j=1;j<currentNombre;j++){

for(int k=currentNombre-1;j<currentNombre;j++){

stroke(random(255),j*2,k*2,1);noFill();

point(pos[i], posY[i],0);

line(pos[i],posY[i],pos[j],posY[j]);

triangle(pos[i],posY[i],pos[j],posY[j],pos[k],posY[k]);

if(keyPressed&&currentNombre>2){

beginShape();

texture(img);

vertex(pos[i],posY[i],0,0,0);

vertex(pos[j],posY[j],0,300,120);

vertex(pos[k],posY[k],0,200,400);}

endShape();

}

if (mousePressed) {

pos[currentNombre] = mouseX;

posY[currentNombre] = mouseY;

currentNombre +=1;

mousePressed=false;

}

GoToLoop

Re: PShape array assigned to createShape(void) issue

8 months ago

Now I got it! createShape() is a new feature from Processing beta series 2.
Unfortunately, I'm still using current stable v1.5.1.

PhiLho

Re: PShape array assigned to createShape(void) issue

8 months ago

I tried your second code with an image I had, and I had no NPE, it works fine, the image is distorted when I move the handles.
Tested with Processing 2.0b7 on Windows.

sachaamm

Re: PShape array assigned to createShape(void) issue

8 months ago

hi philho,

i try to integrate these basic textures function in an array list : in a first time i could draw a rectangle texture and in a second time modify the texture vertex positions.

so i want to use an arraylist of class using pshape array

i can't use the pshape array outside from the class because i won't use my pshape array in the context of my class attributes ( a returned pshape array in draw() will cost a lot of memory)

i know the best method will be to assign only a pshape created in real time from a pshape array and no a class using a pshape array at the instance of each object.

the serious problem is you could'nt assign the createshape method in setup and define the pshape vertex attributes in a second time in draw,

this example illustrates it : (this is the same code but i only set the vertex properties in draw() )

PShape test;

int Ax, Ay, Aw, Ah;

Control[] Rect;

void setup() {

size(800, 500, P3D);

PImage tex = loadImage("333.jpg");

Rect = new Control[4];

Ax=120-25;

Ay=120-5;

Aw=Ah=25;

test = createShape();

test.noStroke();

for (int i = 0; i<4;i++) {

Rect[i] = new Control(120+int(random(width-240)), 120+int(random(height-240)), i );

}

void draw() {

test.texture(tex);

test.tint(255);

test.vertex(120, 120, 0, 0, 0);

test.vertex(width-20, 120, 0, tex.width, 0);

test.vertex(width-20, height-20, 0, tex.width, tex.height);

test.vertex(120, height-20, 0, 0, tex.height);

test.end();

background(255);

for (int i = 0; i<4;i++) {

Rect[i].Check(test);

Rect[i].display();

}

// for(Control control : Rect){

// control.display();

// }

pushStyle();

noFill();

rect(Ax, Ay, Aw, Ah);

popStyle();

if (keyPressed&&key=='1') {

Rect[1] = new Control(mouseX, mouseY,1);

}

if (pressA()) {

Ax = mouseX-10;

Ay=mouseY-10;

test.setVertex(0, mouseX, mouseY, 0);

}

shape(test);

}

boolean pressA() {

if (mousePressed&&mouseX>Ax&&mouseY>Ay&&mouseX<Ax+Aw&&mouseY<Ay+Ah) {

return true;

}

else {

return false;

}

class Control {

int mx;

int my;

int index;

Control(int mx_, int my_, int index_) {

mx= mx_;

my = my_;

index = index_;

}

boolean Check(PShape test) {

int Rectselected = 1;

if (mousePressed&&mouseX>this.mx&&this.mx+25>mouseX&&mouseY<this.my+25&&this.my<mouseY) {

this.mx=mouseX-10;

this.my=mouseY-10;

test.setVertex(this.index, mouseX-10, mouseY-10, 0);

return true;

}

else {

return false;

}

void display() {

noFill();

stroke(255, 0, 0);

rect(mx, my, 25, 25);

}

maybe you could tell me more about it

PhiLho

Re: PShape array assigned to createShape(void) issue

8 months ago

Your last example doesn't compile, because tex is defined inside setup(): just define it outside.

PImage tex;
void setup() {
size(800, 500, P3D);
tex = loadImage("H:/PhiLhoSoft/images/clock.gif");

Top Reply