nesting two selectInput() functions

Programming Questions

NinjaChris

nesting two selectInput() functions

in Programming Questions • 9 months ago

Hello all, hopefully this should be an easy one: I'd like to use the above function to select two different text files containing CSV data and then perform a mathematical operation on the data. Currently its throwing an error and I don't understand why. Have I structured this correctly?

/*
This code selects two files and performs a mathematical operation on the signal data in each row.
*/
PrintWriter output;
String folderPath; // folder path where logfiles will be saved
String blankFilePath;
String testFilePath;
String blankFileName;
String[] blankLines;
String testFileName;
String testFileFolderPath;
String outputFile;
String[] testLines;
long index = 0;
String[] blankData;
// ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~
void setup() {
selectInput("Select a blank file:", "blankSelected");
}
// ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~
void blankSelected(File selection) {
if (selection == null) {
println("Window was closed or the user hit cancel.");
exit();
}
else {
blankFilePath = selection.getAbsolutePath();
blankFileName = selection.getName();
println("blank file selected: " + blankFilePath);
blankLines = loadStrings(selection);
println(blankLines[0]);
selectInput("Select a file to subtract:", "fileSelected");
}
output = createWriter(outputFile);
for(String i : testLines) { // this is the main loop of the sketch - contains just test code for now
blankData = split(i, ',');
println(blankData[0]);
println(index);
index++;
}
exit();
}
// ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~ ~
void fileSelected(File selection) {
if (selection == null) {
println("Window was closed or the user hit cancel.");
exit();
}
else {
testFilePath = selection.getAbsolutePath();
testFileFolderPath = selection.getParent();
testFileName = selection.getName();
String[] tFN = split(testFileName, '-');
println("test file selected: " + testFilePath);
outputFile = testFileFolderPath + "\\" + "LCMS mathematical operator output - " + tFN[1]; // text file to save output to
println("output file: " + outputFile);
testLines = loadStrings(selection);
println(testLines[0]);
}
}

The output window produces the following (note that I have prefaced each row of correct output with "$$$$" to highlight where the code has done thigns correctly):

$$$$ blank file selected: C:\Google Drive\Chris Pook AUT\research\lipids LC-MS\2ul injections 12-12-13\ultimate txt writer\LCMS ultimate .txt writer output - 2ul blank crop.txt

$$$$ 590.0,500.0,0

java.lang.reflect.InvocationTargetException

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

at java.lang.reflect.Method.invoke(Method.java:597)

at processing.core.PApplet.selectCallback(PApplet.java:6049)

at processing.core.PApplet.access$000(PApplet.java:153)

at processing.core.PApplet$5.run(PApplet.java:5975)

at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:209)

at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:646)

at java.awt.EventQueue.access$000(EventQueue.java:84)

at java.awt.EventQueue$1.run(EventQueue.java:607)

at java.awt.EventQueue$1.run(EventQueue.java:605)

at java.security.AccessController.doPrivileged(Native Method)

at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)

at java.awt.EventQueue.dispatchEvent(EventQueue.java:616)

at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)

at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)

at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)

at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)

at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)

at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

Caused by: java.lang.NullPointerException

at java.io.File.<init>(File.java:222)

at processing.core.PApplet.saveFile(PApplet.java:7024)

at processing.core.PApplet.createWriter(PApplet.java:6168)

at LCMS_mathematical_operator.blankSelected(LCMS_mathematical_operator.java:61)

... 21 more

$$$$ test file selected: C:\Google Drive\Chris Pook AUT\research\lipids LC-MS\2ul injections 12-12-13\ultimate txt writer\LCMS ultimate .txt writer output - 2ul 500mg.l tristearin crop.txt

$$$$ output file: C:\Google Drive\Chris Pook AUT\research\lipids LC-MS\2ul injections 12-12-13\ultimate txt writer\LCMS mathematical operator output - 2ul 500mg.l tristearin crop.txt

java.lang.reflect.InvocationTargetException

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

at java.lang.reflect.Method.invoke(Method.java:597)

at processing.core.PApplet.selectCallback(PApplet.java:6049)

at processing.core.PApplet.access$000(PApplet.java:153)

at processing.core.PApplet$5.run(PApplet.java:5975)

at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:209)

at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:646)

at java.awt.EventQueue.access$000(EventQueue.java:84)

at java.awt.EventQueue$1.run(EventQueue.java:607)

at java.awt.EventQueue$1.run(EventQueue.java:605)

at java.security.AccessController.doPrivileged(Native Method)

at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)

at java.awt.EventQueue.dispatchEvent(EventQueue.java:616)

at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)

at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)

at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)

at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)

at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)

at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

Caused by: java.lang.OutOfMemoryError: Java heap space

at java.util.Arrays.copyOfRange(Arrays.java:3209)

at java.lang.String.<init>(String.java:215)

at java.io.BufferedReader.readLine(BufferedReader.java:331)

at java.io.BufferedReader.readLine(BufferedReader.java:362)

at processing.core.PApplet.loadStrings(PApplet.java:6646)

at processing.core.PApplet.loadStrings(PApplet.java:6633)

at processing.core.PApplet.loadStrings(PApplet.java:6567)

at LCMS_mathematical_operator.fileSelected(LCMS_mathematical_operator.java:92)

... 21 more

Many thanks,

Replies(8)

PhiLho

Re: nesting two selectInput() functions

9 months ago

Long shot (and recall of somebody having a similar issue in the past): try saving on the hard disk instead of on a virtual disk (if Google Drive is that).

NinjaChris

Re: nesting two selectInput() functions

9 months ago

Hi PhiLho, thanks for your rapid response. GDrive is a folder on my physical HDD that gets sync'd to the cloud so shouldn't be a problem. The Google client isn't running at the moment either.

I tried separating the two selectInput() Methods and calling them from void setup() one after the other. I added some println("step X - " + millis()) lines around the place to track the progress of the sketch and bizarrely the second selectInput() method runs first. The code is hanging on the first one (run second!) at the line blankLines = loadStrings(selection);

The error code now reads:

step 4 - 2515

test file selected: C:\Google Drive\Chris Pook AUT\research\lipids LC-MS\2ul injections 12-12-13\ultimate txt writer\LCMS ultimate .txt writer output - 2ul 500mg.l tristearin crop.txt

output file: C:\Google Drive\Chris Pook AUT\research\lipids LC-MS\2ul injections 12-12-13\ultimate txt writer\LCMS mathematical operator output - 2ul 500mg.l tristearin crop.txt

step 5 - 3468

590.0,500.0,0

blank file selected: C:\Google Drive\Chris Pook AUT\research\lipids LC-MS\2ul injections 12-12-13\ultimate txt writer\LCMS ultimate .txt writer output - 2ul blank crop.txt

step 1 - 3468

java.lang.reflect.InvocationTargetException

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

at java.lang.reflect.Method.invoke(Method.java:597)

at processing.core.PApplet.selectCallback(PApplet.java:6049)

at processing.core.PApplet.access$000(PApplet.java:153)

at processing.core.PApplet$5.run(PApplet.java:5975)

at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:209)

at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:646)

at java.awt.EventQueue.access$000(EventQueue.java:84)

at java.awt.EventQueue$1.run(EventQueue.java:607)

at java.awt.EventQueue$1.run(EventQueue.java:605)

at java.security.AccessController.doPrivileged(Native Method)

at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)

at java.awt.EventQueue.dispatchEvent(EventQueue.java:616)

at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:269)

at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:184)

at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:174)

at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:169)

at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:161)

at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

Caused by: java.lang.OutOfMemoryError: Java heap space

at java.io.BufferedReader.readLine(BufferedReader.java:331)

at java.io.BufferedReader.readLine(BufferedReader.java:362)

at processing.core.PApplet.loadStrings(PApplet.java:6646)

at processing.core.PApplet.loadStrings(PApplet.java:6633)

at processing.core.PApplet.loadStrings(PApplet.java:6617)

at LCMS_mathematical_operator.blankSelected(LCMS_mathematical_operator.java:66)

... 21 more

The line " Caused by: java.lang.OutOfMemoryError: Java heap space" is ominous. Odd too, because I'm not out of memory.

I tried replacing the input to the problem line with a String carrying the same information and it still falls over so it definitely seems to be a problem resulting from my use of loadStrings().

quarks

Re: nesting two selectInput() functions

9 months ago

In the latest version of Processing the selectInput method asks you for the name of a method that will be executed in a separate thread so if from setup you do

selectInput("Select a blank file:", "blankSelected");
selectInput("Select a file to subtract:", "fileSelected");

Then you will have the main thread , a thread to execute the method blankSelected and a third thread to execute the method fileSelected.

Since you don't have access to the actual threads you have no control over synchronising their actions so it is quite possible for the fileSelected method to be executed first.

If you nest them as you did before then you have another problem because the selectInput will open the standard Java file-chooser dialog, but AFAIK this cannot be done except from the main thread and we are in another thread.

Although I can see the advantages of using separate threads to process the actual file loading it makes the sketch code more complex because you have to flag up that the file has been loaded so that the main thread knows when it can be processed.

In previous versions everything stopped until the file loading had completed. I can't see why they removed this option and allow the user to choose whether to have immediate mode or threaded mode.

Either you do the above or you could use the latest version of G4P because I have included immediate versions of the file dialog boxes, see here.

NinjaChris

Re: nesting two selectInput() functions

9 months ago

Hi Quarks, thanks for your reply. I like the look of your library. I'll give it a whirl tomorrow and try to make do stuff. Just a quick query- there's no obvious class in the documentation that allows me to open files. Am I missing something?

PhiLho

Re: nesting two selectInput() functions

9 months ago

" there's no obvious class in the documentation that allows me to open files"
You use loadStrings()...
Otherwise, search for reader.

NinjaChris

Re: nesting two selectInput() functions

9 months ago

Sorry, I meant that there was no relevant class in the G4P library but I now see that its mentioned in the first row of the page Quark links to. The facepalm is strong with this one.

To implement Quark's suggestion to use a flag would while() and a boolean to monitor whether selectInput()has completed do the job? I shall play some more.

Thanks again for all your help chaps.

NinjaChris

Re: nesting two selectInput() functions

8 months ago

The boolean flag isn't working.

int proceed =0;
void setup() {
selectInput("Select a blank file:", "blankSelected");
if(proceed > 0) {
selectInput("Select a file to subtract:", "fileSelected");
}
}

Even though I put a proceed++; line at the end of blankSelected the code hangs and doesn't move on to fileSelected.

Got to try G4P now.

Edit

I've tried nesting the fileSelected class back into blankSelected and kept the flag. The lines run in the correct order now and it no longer hangs at the end of blankSelected. I've also discovered that increasing total memory to 1024 stops it crashing at testLines = loadStrings(selection); . Unfortunately another windows process now crashes. I'll try and identify it.

NinjaChris

Re: nesting two selectInput() functions

8 months ago

Okay, so I've managed to get the sketch to load the two data files and do stuff with the contents. If anyone's interested in how I did this you can get a zip of the current working version of the sketch here.

Top Reply