Loading...
Logo
Processing Forum
Core Library Questions
hapticdata
hapticdata

Minim memory leak related to AudioRecorder

in Core Library Questions  •  3 years ago  
I'm making an application that begins recording once it receives an audio signal above a threshold and ends recording once that falls below the threshold for a few seconds straight. I have set a maximum recording length to 5 minutes consecutively so that it doesn't run out of memory, yet after several recordings (last crash was 10 recordings x 5 minutes each) I get an OutOfMemoryError as it writes to the saved file.

Here is the error (minus the Processing added part):
Exception in thread "Animation Thread" java.lang.OutOfMemoryError: Java heap space
at org.tritonus.share.sampled.FloatSampleBuffer.convertToByteArray(FloatSampleBuffer.java:394)
at ddf.minim.javasound.JSBufferedSampleRecorder.save(JSBufferedSampleRecorder.java:144)
at ddf.minim.AudioRecorder.save(AudioRecorder.java:107)
at AOVAudioRecord.completeRecord(AOVAudioRecord.java:213)
at AOVAudioRecord.draw(AOVAudioRecord.java:136)
at processing.core.PApplet.handleDraw(PApplet.java:1606)
at processing.core.PApplet.run(PApplet.java:1503)
at java.lang.Thread.run(Thread.java:637)


two relevant functions:
Copy code
  2. void initRecord()
  3. {
  4.   currentFilename = getTimestamp() + ".wav";
  5.    recorder = minim.createRecorder(in, currentFilename, true);
  6.    worthSavingCounter.reset();
  7.    recorder.beginRecord();
  8. }

Copy code
  2. void completeRecord()
  3. {
  4.     recorder.endRecord();
  5.     recorder.save();
  6.     println("Done saving.");
  7.     addRecentFile(currentFilename);
  8.     currentRecordingLength = 0;
  9.     nRecordings++;
  10.     
  11. }

I can post all of the code if that helps. It seems clear its from saving the file, which is maxed out at 5 minutes in length, and only happens after it has recorded around 50 minutes worth... any suggestions for how I can fix this? I need this to run for 10 days straight

Replies(5)

hapticdata
hapticdata

Re: Minim memory leak related to AudioRecorder

3 years ago
I dramatically improved it just by setting the createRecorder()'s boolean buffered to false.


Currently the application has been running for about 15 hours, I've had constant audio input so it has recorded 230 wav files limited to 5 minutes each.

only problem is, the memory usage is still creeping upwards. 15 hours ago the application was using about 55mb, now its using 279.4mb. So with its current memory limit it would crash a little more than once every 3 days. Though this is not actually likely, because there isnt going to be constant audio to record like in my tests, it still is a vulnerability for my installation.

Any ideas how to fix this leak?
PhiLho
PhiLho

Re: Minim memory leak related to AudioRecorder

3 years ago
Hard to tell without seeing the source code of Minim...
As a wild guess, you can try and set recorder to null after save() call. It shouldn't be necessary, but who knows?

Note: you should try and get JVisualVM, a free tool (found in the JDK but also available separately), it can allow to track memory usage.
niguloto
niguloto

Re: Minim memory leak related to AudioRecorder

1 year ago
Hi I have a similar problem with a minim memory leak but in slight different configuration. I didn't know if it was the case to open a new topic, but anyhow: I'm using processing to control arduino where 2 photoresistors track the ammount of light and if it is over a certain ammount they will turn on their respective LED on the arduino board and play a random track from a pool of 10 different .aiff files.

I'm quite a noob and I might just be using the wrong option to select from a randomic pool of audio files in minim, but that's the only solution I came up with yesterday...obviously minim now does not seem to be able to track down the files in order to clear the memory.

Here's the code, any help? or any solution to achieve the same result in a more elegant way?

Copy code
  2. import ddf.minim.*;
  3. import ddf.minim.signals.*;
  4. import ddf.minim.analysis.*;
  5. import ddf.minim.effects.*;


  8. import processing.video.*;
  9. import processing.serial.*;


  12. import cc.arduino.*;

  14. Serial myPort;         // The Serial Port
  15. Arduino scheda;

  17. boolean ledA = false;
  18. int phoA = 0;

  20. boolean ledB = false;
  21. int phoB = 0;

  23. int brightness = 255;
  24. int fade = 1;

  26. float heightValA;
  27. float heightValB;

  29. int x = 0;
  30. int px= 0;
  31. int delayVal = 0;

  33. Minim audio = new Minim(this);
  34. AudioPlayer track;

  36. void setup(){
  37.   scheda = new Arduino(this, Arduino.list()[1], 57600);
  38.   size(800, 600);
  39.   rectMode(CENTER);
  40.   noStroke();
  41. }

  43. void draw() {
  44.   //set a random track to play
  45.   int randomTrack = (int)random(1, 11);
  46.   track = audio.loadFile("voce" + randomTrack + ".aiff");
  47.   
  48.   //read analog pin from arduino (photoresistors)
  49.   phoA = scheda.analogRead(0);
  50.   phoB = scheda.analogRead(1);
  51.   //map photoresistors val to fit window size
  52.   heightValA = map(phoA, 0,1023, 0, height);
  53.   heightValB = map(phoB, 0,1023, 0, height);
  54.   
  55.   //delay time: check every 1sec
  56.   if (millis() - delayVal > 1000) {
  57.     
  58.   if (phoA < 100 && ledB == false && phoB > 100) {
  59.     ledA = true;
  60.     track.play();
  61.     delayVal = millis();
  62.   } else if (phoB < 100) {
  63.     ledA = false;
  64.     ledB = true;
  65.     track.play();
  66.     delayVal = millis();
  67.   } else if (phoA < 100 && ledB == true) {
  68.     ledA = true;
  69.     ledB = false;
  70.     track.play();
  71.     delayVal = millis();
  72.   } else if (brightness == 0) {
  73.     ledA = false;
  74.     ledB = false;
  75.     brightness = 255;
  76.   }

  78.   }

  80.   //graphic placeholder to track photoresistors light values
  81.   noStroke();
  82.   fill(225, 10);
  83.   rect(width/2, height/2, width, height);
  84.   x = x+1;
  85.   if (x > width) {
  86.     x = 0;
  87.   }
  88.   stroke(250, 100, 0);
  89.   line(x, heightValA, px, heightValA);
  90.   stroke(0, 100,250);
  91.   line(x, heightValB, px, heightValB);
  92.   println(phoA);
  93.   ledState();
  94.   px = x;
  95. }


  98. void ledState() {
  99.  // LED state A 
  100.  if (ledA == true) {
  101.    scheda.digitalWrite(6, Arduino.HIGH);
  102.    noStroke();
  103.    fill(30, phoA);
  104.    rect(width/4,height/2, 10, 10);
  105. //     if (brightness > 0) {
  106. //       brightness -= fade;
  107. //     } else if (brightness <= 0) {
  108. //       brightness = 0;
  109. //     } 
  110.    
  111.  } else if (ledA == false) {
  112.    scheda.digitalWrite(6, Arduino.LOW); 
  113.  }
  114.  
  115.  // LED state B
  116.  if (ledB == true) {
  117.    scheda.digitalWrite(7, Arduino.HIGH);
  118.    noStroke();
  119.    fill(30, phoB); 
  120.    rect(width-width/4,height/2, 10, 10);
  121. //        if (brightness > 0) {
  122. //       brightness -= fade;
  123. //     } else if (brightness <= 0) {
  124. //       brightness = 0;
  125. //     } 

  127.  } else if (ledB == false) {
  128.    scheda.digitalWrite(7, Arduino.LOW); 
  129.  }
  130.  
  131. }

  133. //minim
  134. public void stop()
  135. {
  136.   track.close();
  137.   audio.stop();

  139. super.stop();
  140. }

and here follow the error message I get in processing, thanks in advance for any help you can give me!!


An OutOfMemoryError means that your code is either using up too much memory
because of a bug (e.g. creating an array that's too large, or unintentionally
loading thousands of images), or that your sketch may need more memory to run.
If your sketch uses a lot of memory (for instance if it loads a lot of data files)
you can increase the memory available to your sketch using the Preferences window.
Exception in thread "Animation Thread" java.lang.OutOfMemoryError: unable to create new native thread
at java.lang.Thread.start0(Native Method)
at java.lang.Thread.start(Thread.java:658)
at ddf.minim.javasound.JSBaseAudioRecordingStream.open(JSBaseAudioRecordingStream.java:399)
at ddf.minim.AudioSource.<init>(AudioSource.java:90)
at ddf.minim.AudioPlayer.<init>(AudioPlayer.java:57)
at ddf.minim.Minim.loadFile(Minim.java:360)
at ddf.minim.Minim.loadFile(Minim.java:341)
at tesiProj_audioLight.draw(tesiProj_audioLight.java:71)
at processing.core.PApplet.handleDraw(PApplet.java:1906)
at processing.core.PApplet.run(PApplet.java:1803)
at java.lang.Thread.run(Thread.java:680 


niguloto
niguloto

Re: Minim memory leak related to AudioRecorder

1 year ago
to make it easier this should be the "problematic part", where I assign the .aiff files every loop :/ and then I check if the conditions are "just right" so I call track.play() 


Copy code
  2. void draw() {
  3.   //set a random track to play
  4.   randomTrack = (int)random(1, 11);
  5.   track = audio.loadFile("voce" + randomTrack + ".aiff");
  6.   
  7.   //read analog pin from arduino (photoresistors)
  8.   phoA = scheda.analogRead(0);
  9.   phoB = scheda.analogRead(1);
  10.   //map photoresistors val to fit window size
  11.   heightValA = map(phoA, 0,1023, 0, height);
  12.   heightValB = map(phoB, 0,1023, 0, height);
  13.   
  14.   //delay time: check every 1sec
  15.   if (millis() - delayVal > 1000) {
  16.     
  17.   if (phoA < 100 && ledB == false && phoB > 100) {
  18.     ledA = true;
  19.     track.play();
  20.     delayVal = millis();
  21.   } else if (phoB < 100) {
  22.     ledA = false;
  23.     ledB = true;
  24.     track.play();
  25.     delayVal = millis();
  26.   } else if (phoA < 100 && ledB == true) {
  27.     ledA = true;
  28.     ledB = false;
  29.     track.play();
  30.     delayVal = millis();
  31.   } else if (brightness == 0) {
  32.     ledA = false;
  33.     ledB = false;
  34.     brightness = 255;
  35.   }

  37.   }

of course if i move
Copy code
  1.  track = audio.loadFile("voce" + randomTrack + ".aiff");
inside each "if" like so
Copy code
  2. if (millis() - delayVal > 1000) {
  3.     
  4.   if (phoA < 100 && ledB == false && phoB > 100) {
  5.     ledA = true;
  6.     track = audio.loadFile("voce" + randomTrack + ".aiff");
  7.     track.play();
  8.     delayVal = millis();
  9.   } else if (phoB < 100) {
  10.     ledA = false;
  11.     ledB = true;
  12.     track = audio.loadFile("voce" + randomTrack + ".aiff");
  13.     track.play();
  14.     delayVal = millis();
  15.   } else if (phoA < 100 && ledB == true) {
  16.     ledA = true;
  17.     ledB = false;
  18.     track = audio.loadFile("voce" + randomTrack + ".aiff");
  19.     track.play();
  20.     delayVal = millis();
  21.   } 
  22. }
it's not called 60 times per second but just 1 per second maximum; nonetheless I believe it'll lead to a memory leak just further in time...so it might crash again in 3hrs instead that in 30sec...any suggestion?

here's a screen taken from JVisualVM:



but I don't really know how to read it other than threads don't die!!
niguloto
niguloto

Re: Minim memory leak related to AudioRecorder

1 year ago
No luck I guess :/

Does anyone even have any suggestion on how to do this differently? like with an array or something and minim classes?

Thanks anyway :)
Top Reply

Statistics

  • 5 Replies
  • 1443  Views
  • 0 Followers

Actions

Related Posts