help with removal of hearts

Programming Questions

Wanaka

in Programming Questions • 1 year ago

Hey guys, I'm doing a game as a schoolproject where u are supposed to catch some things falling, and I want to have hearts that indicates that you have missed an item. I have manage to make one heart dissapear. But the other two hearts i dont know how to remove, i have tried different things...but it hasnt worked.

so please help me out!

Heart heartOne;
Heart heartTwo;
Heart heartThree;
Catcher catcher; // One catcher object
Timer timer; // One timer object
Drop _drops;
Drop[] drops; // An array of drop objects
int totalDrops = 0; // totalDrops
int xValue = 200;
void setup() {
size(400, 400);
smooth();
catcher = new Catcher(32); // Create the catcher with a radius of 32
drops = new Drop[1000]; // Create 1000 spots in the array
timer = new Timer(1500); // Create a timer that goes off every 2 seconds
timer.start(); // Starting the timer
heartOne = new Heart(382, 20, 20, 20);
heartTwo = new Heart(360, 20, 20, 20);
heartThree = new Heart(338, 20, 20, 20);
}
void draw() {
background(255);
// Set catcher location
catcher.setLocation(xValue, 360);
// Display the catcher
catcher.display();
//display heart
heartOne.heartDisplay();
heartTwo.heartDisplay();
heartThree.heartDisplay();
// Check the timer
if (timer.isFinished()) {
// Deal with raindrops
// Initialize one drop
drops[totalDrops] = new Drop();
// Increment totalDrops
totalDrops ++ ;
// If we hit the end of the array
if (totalDrops >= drops.length) {
totalDrops = 0; // Start over
}
timer.start();
}
// Move and display all drops
for (int i = 0; i < totalDrops; i++ ) {
drops[i].move();
drops[i].display();
if (catcher.intersect(drops[i])) {
drops[i].caught();
}
}
//BOUNCE ON WALL
if (xValue<=0)
{
xValue = 0;
}
if (xValue>=width)
{
xValue = width;
}
for (int i = 0; i < totalDrops; i++) {
if (drops[i].reachedBottom())
{
heartOne.remove();
}
}
}
void keyPressed() {
if (key == CODED) {
if (keyCode == LEFT) {
xValue = xValue-20;
}
}
if (key == CODED) {
if (keyCode == RIGHT) {
xValue = xValue+20;
}
}
}
////////
class Drop {
float x,y; // Variables for location of raindrop
float speed; // Speed of raindrop
color c;
float r; // Radius of raindrop
Drop() {
r = 8; // All raindrops are the same size
x = random(width); // Start with a random x location
y = -r*4; // Start a little above the window
speed = random(1,2); // Pick a random speed
c = color(50,100,150); // Color
}
// Move the raindrop down
void move() {
// Increment by speed
y += speed;
}
// Check if it hits the bottom
boolean reachedBottom() {
// If we go a little beyond the bottom
if (y > height) {
return true;
} else {
return false;
}
}
// Display the raindrop
void display() {
// Display the drop
fill(c);
noStroke();
for (int i = 2; i < r; i++ ) {
ellipse(x,y + i*4,i*2,i*2);
}
}
// If the drop is caught
void caught() {
// Stop it from moving by setting speed equal to zero
speed = 0;
// Set the location to somewhere way off-screen
y = - 1000;
}
}
/////////////////
class Heart {
int xHeart;
int yHeart;
int wHeart;
int hHeart;
boolean heartCheck;
Heart(int _x, int _y, int _w, int _h)
{
xHeart = _x;
yHeart = _y;
wHeart = _w;
hHeart = _h;
}
void remove()
{
xHeart = 100;
heartCheck = true;
}
void heartDisplay()
{
ellipse(xHeart, yHeart, wHeart, hHeart);
}
}

Replies(2)

tfguy44

Re: help with removal of hearts

1 year ago

First, let's start by posting a simplified version of your code that anyone can copy and paste to run. What you posted can't easily be run by anyone else because we don't have the Catcher or Timer classes. Also noticed that I pulled the code that does a heart removal into the mouseClicked function, for easy testing:

Heart heartOne;
Heart heartTwo;
Heart heartThree;
void setup(){
size(400, 400);
smooth();
heartOne = new Heart(382, 20, 20, 20);
heartTwo = new Heart(360, 20, 20, 20);
heartThree = new Heart(338, 20, 20, 20);
}
void draw(){
background(255);
heartOne.heartDisplay();
heartTwo.heartDisplay();
heartThree.heartDisplay();
}
void mousePressed(){
heartOne.remove();
}
///
class Heart {
int xHeart;
int yHeart;
int wHeart;
int hHeart;
boolean heartCheck;
Heart(int _x, int _y, int _w, int _h) {
xHeart = _x;
yHeart = _y;
wHeart = _w;
hHeart = _h;
}
void remove(){
xHeart = 100;
heartCheck = true;
}
void heartDisplay(){
ellipse(xHeart, yHeart, wHeart, hHeart);
}
}

Now it should be clear why only one heart is every removed - you only ever tell it to remove heartOne! You never do anything to heartTwo or heartThree! We can solve this by putting your hearts into an Array, and then have a new variable which keeps track of which heart needs to move next, and it can index that Array of hearts:

Heart[] hearts;
int whichHeart = 0;
void setup(){
size(400, 400);
smooth();
hearts = new Heart[3];
for( int i = 0; i < hearts.length; i++){
hearts[i] = new Heart( 382-22*i, 20,20,20);
}
}
void draw(){
background(255);
for( int i = 0; i < hearts.length; i++){
hearts[i].heartDisplay();
}
}
void mousePressed(){
if( whichHeart < hearts.length ){
hearts[whichHeart].remove();
whichHeart++;
}
}
///
class Heart {
int xHeart;
int yHeart;
int wHeart;
int hHeart;
boolean heartCheck;
Heart(int _x, int _y, int _w, int _h) {
xHeart = _x;
yHeart = _y;
wHeart = _w;
hHeart = _h;
}
void remove(){
xHeart = 100;
heartCheck = true;
}
void heartDisplay(){
ellipse(xHeart, yHeart, wHeart, hHeart);
}
}

Wanaka

Re: Re: help with removal of hearts

1 year ago

I've tried your code, and i cant get it to work when it's in a for-loop...either it remove only the first one or all of the three hearts...Is there a way in the for-loop to make it work properly?

cheers

Heart[] hearts;
int whichHeart = 0;
Catcher catcher; // One catcher object
Timer timer; // One timer object
Drop _drops;
Drop[] drops;
// An array of drop objects
int totalDrops = 0; // totalDrops
int xValue = 200;
void setup() {
size(400, 400);
smooth();
catcher = new Catcher(32); // Create the catcher with a radius of 32
drops = new Drop[1000]; // Create 1000 spots in the array
timer = new Timer(1500); // Create a timer that goes off every 2 seconds
timer.start(); // Starting the timer
hearts = new Heart[3];
for ( int i = 0; i < hearts.length; i++) {
hearts[i] = new Heart( 382-22*i, 20, 20, 20);
}
}
void draw() {
background(255);
for ( int i = 0; i < hearts.length; i++) {
hearts[i].heartDisplay();
}
// Set catcher location
catcher.setLocation(xValue, 360);
// Display the catcher
catcher.display();
// Check the timer
if (timer.isFinished()) {
// Deal with raindrops
// Initialize one drop
drops[totalDrops] = new Drop();
// Increment totalDrops
totalDrops ++ ;
// If we hit the end of the array
if (totalDrops >= drops.length) {
totalDrops = 0; // Start over
}
timer.start();
}
// Move and display all drops
for (int i = 0; i < totalDrops; i++ ) {
drops[i].move();
drops[i].display();
if (catcher.intersect(drops[i])) {
drops[i].caught();
}
}
//BOUNCE ON WALL
if (xValue<=0)
{
xValue = 0;
}
if (xValue>=width)
{
xValue = width;
}
///////PROBLEM!!!!
//remove heart
for (int i = 0; i < totalDrops; i++) {
if (drops[i].reachedBottom())
{
if (whichHeart < hearts.length ) {
hearts[whichHeart].remove();
whichHeart++;
}
}
}
/////////////////////////
}
void keyPressed() {
if (key == CODED) {
if (keyCode == LEFT) {
xValue = xValue-20;
}
}
if (key == CODED) {
if (keyCode == RIGHT) {
xValue = xValue+20;
}
}
}

Top Reply