Hi,

thank you for asking.

Unfortunately I have to work tonight.  

I will see if I can have a look tomorrow maybe.

I can only advise you to check each of the sub-processes (working steps in your program) you have separatly:

• Does the reading of the xml-data work? Can you print your data in a for loop with println? Does it look like expected?
• Can you feed other data than the xml-data in the treemap? Does it work? Does it look like expected?
• etc.
  

Thus you have different parts / working steps of the program and check them separatly and track down your error.

You may find another treemap here:
http://www.generative-gestaltung.de/P_3_1_4_01


Greetings, Chrisir  

I took a closer look...

first the xml is not read correctly, I think.

In your first for loop

I put this

1.   for (int i = 0; i < x_projects.getChildCount(); i++) {
2.     XMLElement  pxml = x_projects.getChild(i);
3.     int id = pxml.getInt(""id"");
4.     print ("ID = " + id);
5.     String name = pxml.getString("name");
6.     print ("; name = " + name);   
7.     String description = pxml.getString("description");
8.     println ("; description = " + description);   

and got

starting....

ID = 0; name = null; description = null

ID = 0; name = null; description = null

ID = 0; name = null; description = null

ID = 0; name = null; description = null

ID = 0; name = null; description = null

ID = 0; name = null; description = null

ID = 0; name = null; description = null

ID = 0; name = null; description = null

ID = 0; name = null; description = null

ID = 0; name = null; description = null

ID = 0; name = null; description = null

ID = 0; name = null; description = null

ID = 0; name = null; description = null

ID = 0; name = null; description = null

ID = 0; name = null; description = null

end of setup()....

Then I wanted to go directly to the data map (at the very end of setup() )

1.   mapData = new ProjectMap();
2.   Project p;
3.   p = new Project(0, "NAME4", "Test");
4.   mapData.addProject(p);
5.   p = new Project(1, "name2", "Test2");
6.   mapData.addProject(p);
7.   p = new Project(2, "name3", "Test3");
8.   mapData.addProject(p);
9.   mapData.finishAdd();
10.   for (int i = 0; i < 2; i++) {
11.     println (mapData.toString());
12.   }
13.   map = new Treemap(mapData, 3, 3, width, height);
14.   noLoop();
15.   println ("end of setup()....");
16. }

but even this simplified approach didn't draw a treemap...

bad.


oups, my firefox just crashed, all I wrote is lost...

anyway, you see where you should work on... (short version of what I wrote the last 2 hours  )

Greetings, Chrisir 

I fixed the xml loading.

why does FolderItem extend FileItem?, why not the other way around since it's a folder that hold's files and not the other way around.

Both FileItem and FolderItem are 'things' that can be found on the hard drive. In both cases we want to store information about the item i.e.

1. parent
2. file (see note)
3. name
4. level

Note that item 2 is a Java File object and encapsulates the path to the item so is valid for both files and folders.

If you now consider FolderItem it requires additional information that is  not applicable to FileItem i.e.

1. algorithm
2. items (child items may be folders or files)
3. contents visible?
4. layout valid?

In other words FolderItem is a specialised type of FileItem therefore FolderItem inherits from FileItem

So quark,

In this particular case the answer is yes but FolderItem would then have to extend (inherit from) SimpleMapItem otherwise it cannot be stored in the TreeMap.

The following class diagram shows what the book has (left) and your suggestion (right)



The TreeMap can store any object of type SimpleMapItem or any oject from a class that inherits (at any level) from SimpleMapItem. So in both cases the program should work BUT your suggestion is not a good idea.

Why not? I hear you ask. It is not just about duplicating the attributes but the class will also have methods that use/modify those attributes, so these would also have to be duplicated. Now if an error is discovered in one of these methods then you have to remember to correct the error in both classes.

Object orientation is not just about how the code is organised into classes and files, it is a way of visuallising/designing/thinking about software development. Inheritance is one of the more powerful/useful features of an OO language.

OO when used correctly can help you produce elegant scalable software.

thanks for making graphs, you made my shitty day slightly better :)

In my case SubProject should extend Project right?

Can a SubProject hold other SubProjects? I ask because subProjects is shown as an attribute of Project, so if you do extend this class it will also become an attribute of any child class e.g. SubProject.

If the answer is no then I would not extend the Project class but have both extend SimpleMapItem.

The question to ask is "Is SubProject ' a kind of' Project?"

If a SubProject cannot hold other SubProjects but it is a kind of Project then you might create another class to hold the common attributes e.g.



I create the diagrams with a freebie "Violet UML editor" it is a just runnable jar and very easy to use. A little Googling should find where to download it from no problem.

The diagram looks good.

Then you would have

i love you.

(please read post above as well.)

It took a while to find it but I have the solution to the corrupted display in last post.

The problem was caused in the ProjectBase class where you used calcBox to calculate the top-left and bottom-right corners but then when it came to the drawing the rectMode was set to CORNER i.e. x,y,w,h so it meant that the boxes were being drawn bigger than they should have been. (e.g. for the width it was expecting w but you were using x+w)

Although there is a very simple solution (just one line of code) it would be better to rewrite the ProjectBase class because it has redundant attributes that we need to get rid of.

Since the ProjectBase class inherits from SimpleMapItem then an object created from the ProjectBase class will also have the attributes of SimpleMapItem (see class diagram on right)

The values x,y,w & h are filled when the TreeMap is created and we can use these directly in the ProjectBase class rather than create new variables (i.e. boxLeft etc.)

If we do this, not only will it solve the corruption problem but make your code stronger by making proper use of inheritance.

The solution then is to replace your ProjectBase code with that below. You might notice that I have used pushStyle and popStyle inside the draw method. Although not essential it 'isolates' your drawing setup from any changes made outside the class.

1. class ProjectBase extends SimpleMapItem implements MapModel {
2.   MapLayout algorithm = new SquarifiedLayout(); //PivotBySplitSize();
3.   Mappable[] items;
4.   boolean contentsVisible;
5.   boolean layoutValid;
6.   float textPadding = 8;
7.   int id;
8.   String name;
9.   String description;
10.   ProjectBase(int id, String name, String description) {
11.     this.id = id;
12.     this.name = name;
13.     this.description = description;
14.     items = new Mappable[0];
15.   }
16.   // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
17.   void checkLayout() {
18.     if (!layoutValid) {
19.       if (getItemCount() != 0) {
20.         algorithm.layout(this, bounds);
21.       }
22.       layoutValid = true;
23.     }
24.   }
25.   // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
26.   void draw() {
27.     pushStyle();
28.     rectMode(CORNER);
29.     fill(255);
30.     rect(x, y, w, h);
31.     if (textFits()) {
32.       drawTitle();
33.     }
34.     popStyle();
35.   }
36.   // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
37.   void drawTitle() {
38.     fill(0);
39.     textAlign(LEFT);
40.     text(name, x + textPadding, y + h - textPadding);
41.   }
42.   // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
43.   Mappable[] getItems() {
44.     return items;
45.   }
46.   // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
47.   int getItemCount() {
48.     return items.length;
49.   }
50.   // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
51.   boolean textFits() {
52.     float wide = textWidth(name) + textPadding*2;
53.     float high = textAscent() + textDescent() + textPadding*2;
54.     return (w > wide) && (h > high);
55.   }
56.   // - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
57. }

As to the other question it seems to me that effectively you have 3 levels of tree maps -


I would recommend that :-

1. The classes Projects and Sub projects extends SimpleMapItem and implements MapModel
   
2. The class Hours extends SimpleMapItem

Note if you are going to have ProjectBase as the parent class for Project and SubProject then change (1) to

1. The class ProjectBase extends SimpleMapItem and implements MapModel

HTH

thank you so much, i will continue on it today.

I think i understand why the hours should be nested into the sub project.

I think i understand why the hours should be nested into the sub project.

I hope you do - I was going off the picture in your original post and assumed you wanted this as another level of the TreeMap

Also w is like x2 and h is like y2 (right bottom corner).

This is really confusing.

Processing allows you to define the location and size of a rectangle to be drawn in three different ways. The way used is controlled with the method rectMode(mode)
mode        Draw rectangle command
CORNER      rect(x0, y0, w, h);
CORNERS     rect(x0, y0, x1, y1);
CENTER      rect(cx, cy, w, h);
where
x0   x position of top-left corner
y0   y position of top-left corner
x1   x position of bottom-right corner
y1   y position of bottom-right corner
cx   centre x position of the rectangle
cy   centre y position of the rectangle
w    width of the rectangle
h    height of the rectangle

The tree map library calculates the rectangle position using mode = CORNER and in your code you were calculating the box corners (mode = CORNERS) but not using this mode when drawing.

I have just looked at the example in the book and I can see where you got the boxLeft, boxTop etc. - I can see why Ben has included them and the confusion I caused by trying to get rid of them. Unfortunately the book example did not change the rectMode from the default value CORNER to CORNERS and this did not matter when the map was created using (0,0,width,height), the drawing corruption problem was only highlighted when you used (0,0,width/2, height/2)

Also i would like that you can click on a treemap (project/subProject) and that the one that's get clicked on get sized to the size that holds all treemaps (let's say window size).

Is that still possible or am  working totally wrong.

You are not wrong it is still possible because the map data is a collection of rectangles of known position and size - you only have to loop through these to see which one contains the mouse coordinates.

All programmers reach a point where everything seems to go wrong no matter what they do. At that point he/she should move away from the keyboard have a break and try and visualise what they are trying to achieve and what needs to be done to achieve it. The keyboard is no substitute for the brain.

I should be able to have a look at your code (v8) today, but it may take a while to solve the exception error before I can get onto the other problems.

Just to come back to the subject of hours/subpprojects. In the diagram you show that a sub-project comprises of a number of  boxes (TreeMap) but when I look at the software V5 there is nothing inside this class that could be used for a TreeMap.

Now I suggested a map of hours based on your picture in your first post - but that now seems wrong and what you really have is this.



Please confirm this is what you want?

but when I look at the software V5 there is nothing inside this class that could be used for a TreeMap.

OK thats fine. I have been looking at your code all afternoon without much luck. The main problem is that the problem definition is not clear and you are trying to resolve too many issues at the same time.

It would be better to concentrate on developing a full UML class diagram to describe the problem definition. For instance I am still unclear about the class Hours - what does this class do??? what is it recording information about??? You need to be clear what information is to be stored in SubProject???

Looking at the code that loads the XML data it seems to me that a SubProject is NOT a collection of hours it is in fact a collection of Jobs - some of these jobs are Contributed and some Donated all have a time allocation (hours) so we can replace Hours with Job in the previous diagram.

In the final analysis the classes
      Project
      SubProject
      Job
are required to be Mappable items. This means that each of these classes should have a method called getSize() that returns a double that is used by TreeMap to work out the size of the box to display. The following method could be used in the Project class - the size depends on the number of SubProjects.

1.   double getSize() {
2.     return subProjects.size();
3.   }

In the SubProject class it might return the sum add of all the hours donated/contributed.
In the Job class it might return the number of hours associated with this job.


The classes
      Project
      SubProject
also have to implement the MapModel interface. This means each of these classes should have a getItems() method which returns an array of mappable items. In the Project class you have an array list of SubProjects so I would add the following code to the Project class

1.   Mappable[] getItems() {
2.     return subProjects.toArray(new Mappable[subProjects.size()]);
3.   }

In the SubProject class it would return an array of Jobs

I notice that in your classes Project, SUbProject you have been adding TreeMap attributes - get rid of them. Since in the final application you will probably be using dynamic data i.e. adding Projects/SubProjects/Jobs etc the TreeMap should be created when required.

For instance assume that you have a Project object with the identifier proj1, then the TreeMap of its SubProjects is calculated with

  map = new Treemap(proj1, 50, 50, width-100, height-100);

HTH

I nearly forgot - XMLElement will be removed from Processing V2.

thanks, i have to go now.

Yes.

XMLElement is replaced by XML see wiki

Hours was a bad name, it should be Hour. Every subProject is a job itself, in there it shows the hours participated/donated. Every hour will be a rectangle (a SimpleMapItem), the size will depend on the reward.

The classes 
       Project
       SubProject
also have to implement the MapModel interface. This means each of these classes should have a getItems()  method which returns an array of mappable items. In the Project class you have an array list of SubProjects so I would add the following code to the Project class

1.   Mappable[] getItems() {
2.     return subProjects.toArray(new Mappable[subProjects.size()]);
3.   }

In the SubProject class it would return an array of Jobs

ProjectBase has