G4P panel expand/collapse disabled after textfield event in nexted panel

bbcannon

G4P panel expand/collapse disabled after textfield event in nexted panel

in Contributed Library Questions • 1 year ago

Hello,

I used the Guibuilder for G4P to create nested panels with textFields. I would like to be able to expand and collapse the panels. However, once I click in one of the textFields (placed inside the nested panel), I can no-longer expand or collapse any of the panels.

Here is an image of my panels. Panel 'panel1' is the top panel, which contains both 'panel11' and 'panel12'. The textFields which cause the issue are placed in panel11 and panel12.

Has anyone seen this before? I'm using Processing 1.5.1, G4P 1.1.0 and guicomponents 1.7.3

Thanks in advance,

bbc

Replies(8)

bbcannon

Re: G4P panel expand/collapse disabled after textfield event in nexted panel

1 year ago

Well, I don't think I accurately described the 'issue' I'm seeing. Of course, it may be pebkac.

It looks like any time you place a textField inside a GPanel or GWindow, once the user sets the focus onto that textField, it will not release focus. I've tried hitting Enter, Tab, clicking in all other parts of the window.

I think I've found a work-around though. Using GComponent.setFocus(false) will release the focus if it's executed in a callback function. So, I guess I can release focus when Enter is pressed for a one-line textField.

Overall, I've enjoyed using G4P so far. Many thanks to Quarks (?) for making this library available!

bbc

quarks

Re: G4P panel expand/collapse disabled after textfield event in nexted panel

1 year ago

You description of the problem is quite clear and PEBKAC == false

Internally G4P tracks the z ordering of components because 'floating' components such as GPanel and GCombo mean that components can overlap other components causing confusion over which has focus or being used.

In the last couple of hours (since I noticed this post) I have been looking at the source code, I think I have a solution to the problem but since you have found a neat if temporary solution there is no rush to release a new version of G4P, and I want the time to do more investigation and esting. Will hopefully release a new release before Christmas.

I see that you are also using the GUI builder tool for G4P, hope you like that too.

Thanks for reporting the bug.

bbcannon

Re: G4P panel expand/collapse disabled after textfield event in nexted panel

1 year ago

Thanks for supporting this! I can see how keeping track of the floating components can be tricky.

I'll be fine with the work-around, and don't want to encourage a quick fix. A thoughtful solution with testing is the way to go...

The GUI builder is a real time saver. Not only for trying various layouts, but learning how the code works.

bbc

bbcannon

Re: G4P panel expand/collapse disabled after textfield event in nexted panel

1 year ago

I found I have to check hasFocus() before calling setFocus():

// p11_mid_txtfield.addEventHandler(this, "textfield2_Enter2");

void textfield2_Enter2(GTextField textfield) { //_CODE_:p11_mid_txtfield:242616:

println("p11_mid_txtfield - GTextField event occured " + System.currentTimeMillis()%10000000 );

if (textfield.hasFocus() && textfield.getEventType() == GTextField.ENTERED) {

textfield.setFocus(false);

}

} //_CODE_:p11_mid_txtfield:242616:

Otherwise, I kept seeing this error message:

############# EXCEPTION IN EVENT HANDLER #############

An error occured during execution of the eventhandler:

CLASS: g4p_builder_test METHOD: textfield2_Enter2

Caused by java.lang.StackOverflowError

guicomponents.GMessenger.eventHandlerFailed(GMessenger.java:91)

########################################################

quarks

Re: G4P panel expand/collapse disabled after textfield event in nexted panel

1 year ago

Not sure why you need to call hasFocus since the method textfield2_Enter2 is ONLY executed if the textField has generated an event, so it must have had focus.

bbcannon

Re: G4P panel expand/collapse disabled after textfield event in nexted panel

1 year ago

Yah, I can't explain the logic behind this. I just knew that repeatedly calling textfield.setFocus(false) seemed to cause the stack overflow. I guessed at checking hasFocus(), and the error went away. Perhaps it is coincidental, but thought I would report it anyway. And, I've run it a number of times with/without hasFocus() and the behavior looks consistent to me.

I forgot to check if hasFocus ever returns false though...

bbcannon

Re: G4P panel expand/collapse disabled after textfield event in nexted panel

1 year ago

I checked the hasFocus() return value and I see it returning false.

The callback function:

void textfield2_Enter2(GTextField textfield) { //_CODE_:p11_mid_txtfield:242616:
println("p11_mid_txtfield - GTextField event occured " + System.currentTimeMillis()%10000000 );
// if (textfield.hasFocus() && textfield.getEventType() == GTextField.ENTERED) {
if (textfield.getEventType() == GTextField.ENTERED) {
if (textfield.hasFocus()) {
textfield.setFocus(false);
} else {
println("HEY NO FOCUS!!");
}
}
} //_CODE_:p11_mid_txtfield:242616:

And this was printed in the IDE:

panel1 - GPanel event occured 1939539

panel11 - GPanel event occured 1941072

p11_mid_txtfield - GTextField event occured 1944871

p11_mid_txtfield - GTextField event occured 1945638

p11_mid_txtfield - GTextField event occured 1946272

p11_mid_txtfield - GTextField event occured 1947855

HEY NO FOCUS!!

p11_mid_txtfield - GTextField event occured 1951990

HEY NO FOCUS!!

fwiw...

bbc

bbcannon

Re: G4P panel expand/collapse disabled after textfield event in nexted panel

1 year ago

Thanks for the update quarks!

G4P version 1.7.4 makes this much better. Not perfect, but much better. You can mouse click in the GPanel where the textField resides and it will release focus. Mouse clicks outside that GPanel didn't register for me.

Top Reply