Loading...
Logo
Processing Forum
Contributed Library Questions
david.finnegan
david.fin..

Draw in visual for as long as midi note is held

in Contributed Library Questions  •  1 year ago  
Hi guys, I'm currently working on editing a piece of code from  http://krazydad.com/processing_music/ I've managed to get it working roughly how I wanted, but there's a few gripes I'm thus far unable to get my head around. 

This is what I'm struggling with; 

1; I want the visual to draw in for however long I hold a note on my midi keyboard 
2; I don't want the visual to disappear when I strike the note for a second time

Here's the code I'm working with, once again many thanks to Jim (KrazyDad) for the original code! 

Copy code
  2. import rwmidi.*; //Import the library

  4. MidiOutput myOutput; // The MidiBus
  5. MidiInput  myInput;

  7. boolean midiThru = false;  // echo all received midi in messages to the midi out device

  9. int  maxNotes = 128;


  12. class MNote {
  13.   long   startTime;
  14.   float  ax;
  15.   float  ay;
  16.   float  bx;
  17.   float  by;
  18.   float  cx;
  19.   float  cy;
  20.   float  dx;
  21.   float  dy;
  22.   float  ex;
  23.   float  ey;
  24.   float  fx;
  25.   float  fy;
  26.   float  gx;
  27.   float  gy;
  28.   float  hx;
  29.   float  hy;
  30.   float  initRad;
  31.   float  weight;
  32.   float  kMinVelocity = 10;
  33.   float  kMaxVelocity = 100;
  34.   float a = 100;
  35.   int    pitch;
  36.   int    velocity;
  37.   
  38.   
  39.   boolean  isOn = false;

  41.   MNote(int pitch) {
  42.     this.pitch = pitch;
  43.   }
  44.   
  45.   void init(int pitch, int velocity)
  46.   {
  47.     startTime = millis();
  48.     int  rotation = 50000;
  49.     int currentTime = millis();
  50.     float m = (currentTime%rotation)* PI*2 / rotation; //creates motion
  51.     
  52.     this.ax = (sin(m)*a+screen.width/2);
  53.     this.ay = (cos(m)*a+screen.height/2);
  54.     this.bx = (sin(m)*(a+40)+screen.width/2);
  55.     this.by = (cos(m)*(a+40)+screen.height/2);
  56.     this.cx = (sin(m)*(a+80)+screen.width/2);
  57.     this.cy = (cos(m)*(a+80)+screen.height/2);
  58.     this.dx = (sin(m)*(a+120)+screen.width/2);
  59.     this.dy = (cos(m)*(a+120)+screen.height/2);
  60.     this.ex = (sin(m)*(a+160)+screen.width/2);
  61.     this.ey = (cos(m)*(a+160)+screen.height/2);
  62.     this.fx = (sin(m)*(a+200)+screen.width/2);
  63.     this.fy = (cos(m)*(a+200)+screen.height/2);
  64.     this.gx = (sin(m)*(a+240)+screen.width/2);
  65.     this.gy = (cos(m)*(a+240)+screen.height/2);
  66.     this.hx = (sin(m)*(a+280)+screen.width/2);
  67.     this.hy = (cos(m)*(a+280)+screen.height/2);
  68.     
  69.     this.pitch = pitch;
  70.     this.velocity = velocity;
  71.     this.isOn = true;
  72.   }
  73.   
  74.   void render()
  75.   {
  76.    if (!isOn)
  77.       return;
  78.       
  79.     float hueV = (this.pitch % 12) / 12.0;
  80.     float lum = constrain(1+pow(4,2), .05, 1);
  81.     float sat = lum;
  82.      
  83.     noStroke();
  84.     
  85.     fill(hueV,sat,lum,20);
  86.     ellipse(ax,ay,40,40);
  87.     
  88.     fill(hueV,sat,lum,20);
  89.     ellipse(bx,by,40,40);
  90.     
  91.     fill(hueV,sat,lum,20);
  92.     ellipse(cx,cy,40,40);
  93.     
  94.     fill(hueV,sat,lum,20);
  95.     ellipse(dx,dy,40,40);
  96.     
  97.     fill(hueV,sat,lum,20);
  98.     ellipse(ex,ey,40,40);
  99.     
  100.     fill(hueV,sat,lum,20);
  101.     ellipse(fx,fy,40,40);
  102.     
  103.     fill(hueV,sat,lum,20);
  104.     ellipse(gx,gy,40,40);
  105.       
  106.     fill(hueV,sat,lum,20);
  107.     ellipse(hx,hy,40,40);
  108.     
  109.   }
  110. }

Replies(3)

PhiLho
PhiLho

Re: Draw in visual for as long as midi note is held

1 year ago
I don't know the Midi library (but because of it I moved the topic from Programming Questions to this one), so I can't help on your specific question. But here too, you could use an array to reduce the amount of code...
nickhudspeth
nickhudsp..

Re: Draw in visual for as long as midi note is held

1 year ago
I'm pretty sure that MIDI devices send separate messages for key-on and key-off events. You could just write your code to begin drawing in your visual at the key-on event, and continue to draw in until a key-off event is detected.

Maybe you can find some useful info here:
jbum
jbum

Re: Draw in visual for as long as midi note is held

1 year ago
Your MNote class can be shortened as follows.  You question pertains more to the way you are triggering it, which involves the parts of the code you haven't shown.  In your class, I've eliminated a lot of unnecessary variables, and used a loop to shorten the code.  Assuming you are drawing one MNote per note, there is no need to precompute the ellipse positions as you did.

Copy code
  2. class MNote {
  3.   int    pitch;
  4.   int    velocity;
  5.   boolean  isOn = false;

  7.   MNote(int pitch) {
  8.     this.pitch = pitch;
  9.   }
  10.   
  11.   void init(int pitch, int velocity)
  12.   {
  13.     startTime = millis();
  14.     
  15.     this.pitch = pitch;
  16.     this.velocity = velocity;
  17.     this.isOn = true;
  18.   }
  19.   
  20.   void render()
  21.   {
  22.    if (!isOn)
  23.       return;
  24.       
  25.     float hueV = (this.pitch % 12) / 12.0;
  26.     float lum = constrain(1+pow(4,2), .05, 1);
  27.     float sat = lum;
  28.      
  29.     noStroke();
  30.     
  31.     fill(hueV,sat,lum,20);
  32.     for (int i = 0; i < 8; ++i) {
  33.       ellipse(sin(m)*(a+40*i)+screen.width/2,
  34.               cos(m)*(a+40*i)+screen.height/2,40,40);
  35.     }
  36.   }
  37. }
Top Reply

Statistics

  • 3 Replies
  • 437  Views
  • 0 Followers

Tags

No tags available for this topic.

Actions

Related Posts