controlP5 / adding listeners

miasma

in Contributed Library Questions • 2 years ago

Hi,

I'm currently using controlP5 in a Java/Swing/Processing application and recently I had to split the GUI into a Controller and a View. Now my Controller implements ControllerListener and I add the variables hopefully to the controller. I'm not sure if this is right:

        int i = 0;
        for (final Slider slider : mSliders) {
            slider.setGroup(ctrl);
            slider.setId(i);
            slider.captionLabel().toUpperCase(true);
            slider.captionLabel().style().padding(4, 0, 1, 3);
            slider.captionLabel().style().marginTop = -4;
            slider.captionLabel().style().marginLeft = 0;
            slider.captionLabel().style().marginRight = -14;
            slider.captionLabel().setColorBackground(0x99ffffff);
            slider.plugTo(mControl);
            i++;
        }

It doesn't work... the controlEvent(...) is getting invoked but the bound variables don't change. A template method setupGUI() has to initialize GUI specific settings.

    /**
     * Constructor.
     *
     * @param paramApplet
     *            {@link PApplet} instance
     * @param paramControl
     *            {@link ISunburstControl} implementation
     * @param paramDb
     *            {@link ReadDB} instance
     */
    protected AbsSunburstGUI(final PApplet paramApplet, final ISunburstControl paramControl, final ReadDB paramDb) {
        assert paramApplet != null;
        assert paramControl != null;
        assert paramDb != null;
        mParent = paramApplet;
        mControl = paramControl;
        mDb = paramDb;
        mZoomer = new ZoomPan(mParent);
        mZoomer.setMouseMask(PConstants.CONTROL);
        mControlP5 = new ControlP5(mParent);
        mControlP5.addListener(mControl);
        mSliders = new LinkedList<Slider>();
        mRanges = new LinkedList<Range>();
        mToggles = new LinkedList<Toggle>();
    }

    /** Initial setup of the GUI. */
    protected abstract void setupGUI();

In setupGUI I'm doing something like:

mToggles.add(ti, getControlP5().addToggle("mShowArcs", mShowArcs, left + 0, top + posY, 15, 15));
mToggles.get(ti++).setLabel("show Arcs");

mToggles and mShowArcs are defined in the supertype (AbsSunburstGUI). Neither plugTo(this) nor plugTo(mControl) works.

So I'm wandering what's wrong :-/

regards,
Johannes

Replies(3)

andreas.s..

Re: controlP5 / adding listeners

2 years ago

hi, i hope i understand your question correctly, and assume you are trying to do something like this?

import controlP5.*;
ControlP5 cp5;
void setup() {
size(400,400);
cp5 = new ControlP5(this);
B b = new B();
cp5.addSlider("slider",0,100).plugTo(b);
}
void draw() {}
abstract class A {
void slider(float theValue) {
println(theValue);
}
}
class B extends A {
}

as you already pointed out, the plugTo method here does ignore the slider() method inside the abstract class A, hence an instance of class B will not be informed when a slider event has been invoked for this particular setup. the following 2 setups do work(around) though, but not sure if this is applicable to your code structure:

import controlP5.*;
ControlP5 cp5;
void setup() {
size(400,400);
cp5 = new ControlP5(this);
B b = new B();
cp5.addSlider("slider",0,100).plugTo(b);
}
void draw() {}
abstract class A {
abstract void slider(float theValue);
}
class B extends A {
void slider(float theValue) {
println(theValue);
}
}

or using the ControlListener:

import controlP5.*;
ControlP5 cp5;
void setup() {
size(400,400);
cp5 = new ControlP5(this);
B b = new B();
cp5.addSlider("slider",0,100).plugTo(b);
cp5.addListener(b);
}
void draw() {}
abstract class A implements ControlListener {
void slider(float theValue) {
println(theValue);
}
public void controlEvent(ControlEvent theEvent) {
slider(theEvent.value());
}
}
class B extends A {
}

best,

andreas

miasma

Re: controlP5 / adding listeners

2 years ago

Hi Andreas,

my setup is as follows:

abstract class GUI {
ControlP5 mControl;
List<Slider> mSliders;
private transient float mDotSize;
GUI(PApplet paramApplet, final ISunburstControl paramControl) {
mControl = new ControlP5(paramApplet);
mControl.addListener(paramControl);
mSliders = new LinkedList<Slider>();
...
setupGUI();
}
private void setupGUI() {
...
mSliders
.add(si, mControlP5.addSlider("mDotSize", 0, 10, mDotSize, LEFT, TOP + mPosY + 0, len, 15));
mSliders.get(si++).setLabel("dotSize");
...
setup();
...
for (final Slider slider : mSliders) {
slider.setGroup(ctrl);
slider.setId(i);
slider.captionLabel().toUpperCase(true);
slider.captionLabel().style().padding(4, 0, 1, 3);
slider.captionLabel().style().marginTop = -4;
slider.captionLabel().style().marginLeft = 0;
slider.captionLabel().style().marginRight = -14;
slider.captionLabel().setColorBackground(0x99ffffff);
slider.plugTo(this);
i++;
}
}
protected abstract void setup();
}

The Sliders, Toggles etc.pp. should bind to the abstract class instead of concrete implementations and classes which implement the Template method setup() should bind their private ControlP5 Toggles, Sliders etc.pp. to the concrete implementation class. Thus the generic (abstract) GUI can be used from many classes (Bla extends GUI; Blubb extends GUI).

But it somehow doesn't work with abstract classes, but the reflection mechanisms used in ControlP5 should work I think (getDeclaredFields()).

If I do something like

SunburstGUI extends GUI and bind the variables to the SunburstGUI (plugTo(paramGUI)); it works, but I have to specify setters like:

/**
* Set show arcs.
*
* @param paramFlag
* true if arcs should be shown, false otherwise
*/
public void mShowArcs(final boolean paramFlag) {
setShowArcs(paramFlag);
}

to invoke the setShowArcs(paramFlag); method in the abstract class. And it's something which has to be done for many fields and for each class wich extends the abstract GUI.

It would be great to build the greatest part of the controlP5 GUI in the abstract class and then just add some special toggles, sliders or whatever in the concrete GUI implementations.

But maybe your second way works:

addListener(mControl);
addListener(this);

in the abstract GUI class and then use setters:

public void controlEvent(final ControlEvent paramEvent) {
setDotSize(paramEvent.value());
}

Ok... this works, but I somehow have to switch over the events I think, such that the right method is invoked. Maybe using setId(int) and then switch over the int. But it would be much easier to use reflection to just set the fields in the abstract class accordingly :-/ I'm not sure why it doesn't work simply with plugTo(this) in the abstract class.

regards and thanks,
Johannes

miasma

Re: controlP5 / adding listeners

2 years ago

Ok thanks Andreas, I've put the whole controlEvent thing into the Controller, that's where it belongs ;-) and it works with id's:

    /**
     * Called on every change of the GUI.
     *
     * @param paramControlEvent
     *            the {@link ControlEvent}
     */
    @Override
    public void controlEvent(final ControlEvent paramControlEvent) {
        assert paramControlEvent != null;
        if (paramControlEvent.isController()) {
            if (paramControlEvent.controller() instanceof Toggle) {
                switch (paramControlEvent.controller().id()) {
                case 0:
                    assert paramControlEvent.controller() instanceof Toggle;
                    getGUI().setShowArcs(((Toggle)paramControlEvent.controller()).getState());
                    break;
                case 1:
                    assert paramControlEvent.controller() instanceof Toggle;
                    getGUI().setShowLines(((Toggle)paramControlEvent.controller()).getState());
                    break;
                case 2:
                    assert paramControlEvent.controller() instanceof Toggle;
                    getGUI().setUseBezierLine(((Toggle)paramControlEvent.controller()).getState());
                    break;
                }
            } else if (paramControlEvent.controller() instanceof Slider) {
                switch (paramControlEvent.controller().id()) {
                case 0:
                    getGUI().setInnerNodeArcScale(paramControlEvent.controller().value());
                    break;
...

thanks,
Johannes

Top Reply