is there any way to make a condition like "if this - do this", general into the sketch without the need of rewriting many times.

Yes...  But your description isn't particularly clear so it's hard to give an example of the best option in your context...  If I've understood correctly you want to avoid a situation where you test note length individually for each pitch?  But since note length is independent of pitch why should you need to?  You can check it once in a separate condition and assign the result to a variable.  You might still need to check against this variable for each pitch, but again, depending on what you're trying to do there may be shortcuts or better alternatives available (e.g. switch() can be a good alternative to multiple if/else if conditions); you can also write functions to avoid repetition of code...  Alternatively if you're loading files based on note length and pitch you could perhaps name them in such a way that you can generate the file-name by combining the length and pitch values into a string...  The answer really depends on what you're trying to achieve ;)

I'd suggest you go ahead and post your code, or at least the complete section relevant to this problem: that will make it easier to offer a relevant solution ;)

if you can express those if() else if() statments as a mathematical expression then you possibly could. sorry i'm not that hot at maths though.

Thank you both for the replies and the variety of solutions.

i would like to mention that when i detect a midipitch  a gray note is being loaded that is the same for all pitches.
this is because, processing first finds the pitch and after the duration.
so, when my sketch goes to the next midipitch the gray note must be subtitude with the appropriate image(half-whole-quarter note).

1. note = grayNote;//default image for all pitches
   
2. //When the note finishes
   if(noteDuration<=tempo)
   {
   afternote = quarterNote;
   }
   else if(noteDuration>=tempo && (noteDuration<=2*tempo))
   {
     afternote = halfNote;
   }
   else if (noteDuration>=2*tempo)
   {
     afternote = wholeNote;
   }
   
   
   //condition which loads a default image for all pitches
   if(midiPitch==48)
   image(note, verticalNotePos , cUnderLine, width/12,height/12);
   if(midiPitch==50)
   image(note, verticalNotePos, d_underGAP, width/12,height/12);
   if(midiPitch==53)
   image(note, verticalNotePos, fGAP, width/12,height/12);
   if(midiPitch==55)
   image(note, verticalNotePos, gLine-10, width/12,height/12);
   if(midiPitch==57)
   image(note, verticalNotePos, aGAP, width/12,height/12);
   if(midiPitch==59)
   image(note, verticalNotePos, bLine-10, width/12,height/12);
   if(midiPitch==60)
   image(note, verticalNotePos, cGAP, width/12,height/12);
   if(midiPitch==64)
   image(note, verticalNotePos, eGAP ,width/12,height/12);
   if(midiPitch==65)
   image(note, verticalNotePos, fLine ,width/12,height/12);

where verticalNotePos is just the position in time and next to it the position on the stave.

so now i am going to check your answers and reply back..


thanks again

Assuming you're running this code separately for each note, then replacing all those individual if conditions with a switch() would certainly be an option (and more efficient); and since the image call is identical for all, except for a single parameter, you could do something along the lines of this:

1. int imgYposition; // or maybe you're using a float?
   
2. 
   
3. switch(midiPitch) {
4.     case 48:
5.         imgYposition = cUnderLine;
6.         break;
7.     case 50:
8.         imgYposition = d_underGAP;
9.         break;
10.     case 53:
11.         imgYposition = fGap;
12.         break;
13.     //etc...
14. }
15. image(note, verticalNotePos, imgYposition, width/12, height/12);

Though, as jaeger83 suggested, if you can calculate the vertical position mathematically based on the pitch you could do away with the conditions altogether ;)

Thank you blindfish, i already adapt the switch() function and it looks much more efficient.

As for the vertical position of the notes  is based on the duration.
When every note finishes, its vertical position is depended on the duration of the
previous note in which it will be added to and so on.

So any advice on loading the proper image when the note has finished.


For example, What could be the code of

"When the note finishes change the gray image to - that- image"?

well thats a silly question...

Thanks again..

Well at the least you probably need to store the properties of each note in an array...  you could then update the image property for each element as and when the note finishes.  You could then iterate over the array in draw() to handle the display and update of images...

Though in actual fact I'd be tempted to look into an OOP way of achieving this - probably far simpler in the long run - but without seeing the project as a whole it's hard to suggest the best approach.

hello again..

i manage to load the vertical position of each note in an array(arrays actually, cause its changing during time..1st stave, 2nd stave...  etc).

1. float [] linesAndGaps = new float[10];//declare an array to strore note's position
2. float [] linesAndGaps1 = {cUnderLine,eLine,gLine,bLine,dLine,fLine,d_underGAP, fGAP, aGAP,cGAP,eGAP};
   float [] linesAndGaps2 = {c2UnderLine,e2Line,g2Line,b2Line,d2Line,f2Line,d2_underGAP, f2GAP, a2GAP,c2GAP,e2GAP};
   
   ///////////////////////////////////////METRONOME////////////////////////////////////////
   
   if(millis()-start >= tempo)
   {
   start = millis();
   counter++;
   
   if(counter>=0)
   {linesAndGaps = linesAndGaps1;}
   
   if (counter>16)
   {
   linesAndGaps = linesAndGaps2;
   }
   
   if (counter>32)
   {
     linesAndGaps = linesAndGaps1;
     counter2=1;
   }
   println(linesAndGaps);
   
   }

in the above example i am using a counter for counting the measures and for changing the note position during the staves.

what do you mean by saying properties and what kind of array i have to use? Is it something like  ArrayList?

Thank you..

Well you could potentially start using multi-dimensional arrays...  For example each stave (which itself is an array) could be an element of a parent array, in which case you could use a counter to move through the staves and another counter to move through the notes, but as I said, without more context it's hard to suggest the best option.

Often using a simple class (see Objects) as a container makes this sort of thing much simpler to manage as instead of referencing meaningless index numbers in multi-dimensional arrays you reference meaningful property names.

BTW - I assumed the notes had multiple properties because you not only wanted to position them vertically but also wanted  to replace the image once the note had completed.  Perhaps you replace the image with another generic image rather than a specific image for each note?  I don't know...

well i am only using Processing a few months now...and the only background i had into programming was just MAX/MSP(which are day and night).

So i have a lot of work still..

The generic image cannot be one cause it depends on the different timinig values of the notes and so that a musician can read it after and replay it.

You are right with that referencing thing..its also making my sketch growing too much already so editing is getting more difficult.

Anyways..i am going to take a look  at the "Class building" field..

Thanks