Code eficiency

Programming Questions

asdf

in Programming Questions • 9 months ago

Hi,

i am working on this data visualization project, and its like 40% done. Well, i suddenly realized about my code being not so efficient since functions are called from functions and similar trails.

void setup() {
......
....
.....
schedule = new Table("asdf.tsv");
setupMain();
}
void setupMain() {
NumberOfRows = lines.length;
.....
...........
FlightNumber = new String[NumberOfRows]; //initializing arrays
Origin = new String[NumberOfRows];
Destination = new String[NumberOfRows];
Frequency = new String[NumberOfRows];
DepartureTime = new String[NumberOfRows];
ArrivalTime = new String[NumberOfRows];
placeIndices = new HashMap();
..........
..........
setupTime(DepartureTime); // Separate Functions
setupOrigin(Origin);
setupDestination(Destination);
setupFrequency(Frequency);
} <--- End of setupMain()
setupTime(String[] DepartureTime) {
....
....
}
void draw() {
...
}

Replies(4)

Chrisir

Re: Code eficiency

9 months ago

Hello,

that a function calls a function that calls a function is ok imho, when they are modules with each an own purpose.

What strikes me in your Code that you have many parallel arrays to describe flight(s).

You can make a class Flight and make an Array of that class.

See: http://wiki.processing.org/w/From_several_arrays_to_classes

Greetings, Chrisir

p.S.

for OOP see

http://processing.org/learning/objects/

asdf

Thanks so much for replying Chrisir! Well, initially i thought the same but just started with it referring to Ben Fry's visualizing data! Alright, so i manage to change the code, made a Flight class, (*thinking about a particular flight*), you can have a look at the data here. (which i got my tsv from). The problem which i am facing is, how am i suppose to save a data in, if not arrays.

Now, there are flights with same(duplicate) flight number , same Origin, same destination, but at different times.

Anyway, here's the class Flights:

class Flights {
int NumberOfRows;
int INDEX;
String FlightNumber;
String Origin;
String Destination;
String DepartureTime;
String ArrivalTime;
String Frequency;
boolean hovered=false;
Flights(int i) {
INDEX = i+1;
FlightNumber = schedule.getString(i+1, 0);
Origin = schedule.getString(i+1, 1);
Destination = schedule.getString(i+1, 2);
DepartureTime = schedule.getString(i+1, 3);
ArrivalTime = schedule.getString(i+1, 4);
}
void FlightNumber() {
}
void Origin() {
}
void Destination() {
}
void DepartureTime() {
}
void ArrivalTime() {
}
void Frequency() {
}
}

Using Table class from Ben Fry's book..

Table schedule;
int rowCount;
void setup() {
int width = 1200;
int height = 1000;
//size(width, height);
schedule = new Table("Indigo Flights.tsv");
// rowCount = schedule.getRowCount();
data = new Flights[schedule.getRowCount()-1]; //t = schedule
//println(data);
println("rowCount = " + schedule.getRowCount()); //prints 564
for(int i = 0;i < data.length;i++) {
data[i] = new Flights(i);
}
}

Earlier, i was doing this-

void setupMain() {
String[] lines = loadStrings("Indigo Flights.tsv");
NumberOfRows = lines.length;
FlightNumber = new String[NumberOfRows]; //initializing arrays
Origin = new String[NumberOfRows];
Destination = new String[NumberOfRows];
Frequency = new String[NumberOfRows];
DepartureTime = new String[NumberOfRows];
ArrivalTime = new String[NumberOfRows];
placeIndices = new HashMap();
//Ariival time, departure time
for(int i = 1; i < NumberOfRows; i++) {
String[] pieces = split(lines[i], TAB);
FlightNumber[i] = pieces[0]; //each line separated by TAB
Origin[i] = pieces[1];
Destination[i] = pieces[2];
DepartureTime[i] = pieces[3];
ArrivalTime[i] = pieces[4];
Frequency[i] = pieces[5];
placeIndices.put(FlightNumber[i], new Integer(i));
}
//println(DepartureTime);
setupTime(DepartureTime);
setupOrigin(Origin);
setupDestination(Destination);
setupFrequency(Frequency);
}

Chrisir

Re: [WatchList] Code eficiency

9 months ago - via EMail-to-forum

asdf

Re: Code eficiency

9 months ago

Also, making a separate "Index" variable, would be a good idea OR Using hashmap(which is a lil confusing to grasp sometimes)
P.S. the table class defined in Ben Fry Visualizing data, is not defined in processingjs?(that might be the reason it not running in browser) Again, the tsv i am getting is from here .

[update]: Finally some progress Chrisir :D Woop.(not all the way though)

Flight class-

class Flights {
int NumberOfRows;
int Count;
String FlightNumber;
String Origin;
String Destination;
String DepartureTime;
String ArrivalTime;
boolean hovered=false;
Flights(int i, String FlightNumber, String Origin, String Destination, String DepartureTime, String ArrivalTime) {
this.Count = i;
this.FlightNumber = FlightNumber;
this.Origin = Origin;
this.Destination = Destination;
this.DepartureTime = DepartureTime;
this.ArrivalTime = ArrivalTime;
Count = i;
FlightNumber = schedule.getString(i+1, 0);
Origin = schedule.getString(i+1, 1);
Destination = schedule.getString(i+1, 2);
DepartureTime = schedule.getString(i+1, 3);
ArrivalTime = schedule.getString(i+1, 4);
}
void getFlightNumber() {
println(FlightNumber);
}
void getOrigin() {
println(Origin);
}
void getDestination() {
}
void getDepartureTime() {
}
void getArrivalTime() {
}
}

Main Tab:-

void setup() {
int width = 1200;
int height = 1000;
schedule = new Table("Indigo Flights.tsv");
data = new Flights[schedule.getRowCount()-1]; //t = schedule
String[] lines = loadStrings("Indigo Flights.tsv");
println("data length is: " + data.length);
for(int i = 0; i < data.length; i++) {
String[] pieces = split(lines[i], TAB);
data[i] = new Flights(i, pieces[0], pieces[1], pieces[2], pieces[3], pieces[4]);
}
for(int i = 1; i < data.length; i++) {
data[i].getFlightNumber();
}
for(int j = 1; j < data.length; j++) {
data[j].getOrigin();
}
String[] timelines = loadStrings("Time.tsv");
for(int i = 0; i < time.length; i++) {
String[] pieces1 = split(timelines[i], TAB);
time[i] = new Time(i, pieces1[0], pieces1[1], pieces1[2], pieces1[3], pieces1[4], pieces1[5], pieces1[6], pieces1[7], pieces1[8]);
}
}

Top Reply

Code eficiency

Replies(4)

Re: Code eficiency

Re: Code eficiency

Re: [WatchList] Code eficiency

Re: Code eficiency

Statistics

Tags

Actions

Related Posts