Loading...
Logo
Processing Forum
Programming Questions
mmm.fuinha
mmm.fuinha

can somebody tell me were this is wrong :D

in Programming Questions  •  1 month ago  
plz tell me were this is wrong:
Copy code
  2. import java.util.Map;

  4. Map<Integer, HashMap<Integer, Boolean>> edjesMap = new HashMap();

  6. HashMap<Integer, Boolean> sub = new HashMap();
  7. int vb = 0;
  8. int va = 0;
  9. Boolean help;

  11. help = sub.get(vb);
  12. if (help == null) {

  14.   sub.put(vb, true);
  15.   HashMap<Integer, Boolean> sub1 = new HashMap();
  16.   try {
  17.     sub1 = edjesMap.get(vb);
  18.     sub1.put(va, true);
  19.   }
  20.   catch(Exception w ) {
  21.     w.printStackTrace();
  22.     sub1.put(va, true);
  23.   }
  24.   edjesMap.put(vb, sub1);
  25. }

can u give me a solution
ty
:D

Replies(12)

GoToLoop
GoToLoop

Re: can somebody tell me were this is wrong :D

1 month ago
I think you should use put() method before get().
That is, you gotta store something before accessing what's stored, right?

Even for the inner HashMap's instantiation, you gotta put() that into the outer HashMap!
After that, you gotta put() keys/values inside the inner HashMap.
Only then you can start using get()!

In a previous post of yours, my example clearly demonstrates that:
http://forum.processing.org/topic/can-i-do-hashmap-integer-hashmap-integet-boolean-and-more

I still think you don't need such a complex structure! 
mmm.fuinha
mmm.fuinha

Re: Re: can somebody tell me were this is wrong :D

1 month ago
ty 
quarks
quarks

Re: can somebody tell me were this is wrong :D

1 month ago
The code logic is a indecipherable and the purpose of the code is unknown because you don't explain it - so how do you expect a decent answer?

One error is line 22 because it will always throws a Null Pointer Eception because the only way to get here is if the identical statement in line 18 throws an exception, so delete line 22.

Please note that this was pointed out in reply to your previous post.
mmm.fuinha
mmm.fuinha

Re: Re: can somebody tell me were this is wrong :D

1 month ago
ty  alot :D
mmm.fuinha
mmm.fuinha

Re: Re: can somebody tell me were this is wrong :D

1 month ago
after all this the code still gives error:

This should do the follow:
take sub from edjesMap.get(va)
see is sub have any key vb
if not sub.put (vb,true)
       and edjes.put(va,sub);
       and take sub1 from edjesMap.get(vb);
      and sub1.put(va,true);
      and edjesMap.put(vb,vb);

Copy code
  2. import java.util.Map;

  4. Map<Integer, Map<Integer, Boolean>> edjesMap = new HashMap();

  6. Map<Integer, Boolean> sub = new HashMap();
  7. int vb = 0;
  8. int va = 0;
  9. Boolean help;


  12.       
  13.      
  14.       // AAAAA-------------------
  15.       
  16.         sub = edjesMap.get(va);
  17.       
  18.       
  19.       // BBBBB-------------------
  20.       help = sub.get(vb);
  21.       if(help == null) {
  22.         
  23.         sub.put(vb,true);
  24.         edjesMap.put(va,sub);
  25.         Map<Integer,Boolean> sub1 = new HashMap();
  26.         sub1 = edjesMap.get(vb);
  27.         sub1.put(va,true);
  28.         edjesMap.put(vb,sub1);
  29.        
  30.         
      }can u plz tell me a solution but plz test it first
quarks
quarks

Re: can somebody tell me were this is wrong :D

1 month ago
This should do the follow:
Copy code
  1. take sub from edjesMap.get(va)
  2. see is sub have any key vb
  3. if not sub.put (vb,true)
  4.       and edjes.put(va,sub);
  5.       and take sub1 from edjesMap.get(vb);
  6.       and sub1.put(va,true);    
  7.       and edjesMap.put(vb,sub1);

Some questions for you

  1. In line 1 the get will return null if edjesMap does not contain the key va - what should happen in that case because sub == null?
  2. In line 5 the get will return null if edjesMap does not contain the key vb - what should happen in that case because sub1 == null?
  3. I have change line 7 is that correct?


mmm.fuinha
mmm.fuinha

Re: Re: can somebody tell me were this is wrong :D

1 month ago
ok i got u point
and i made the repair an it work

Copy code
  2. import java.util.Map;

  4. Map<Integer, Map<Integer, Boolean>> edjesMap = new HashMap();

  6. Map<Integer, Boolean> sub = new HashMap();
  7. int vb = 0;
  8. int va = 0;
  9. Boolean help;


  12.       
  13.      
  14.       // AAAAA-------------------
  15.       
  16.         sub = edjesMap.get(va);
  17.       if(sub == null) {
  18.         sub = new HashMap();
  19.       }
  20.       
  21.       // BBBBB-------------------
  22.       help = sub.get(vb);
  23.       if(help == null) {
  24.         
  25.         sub.put(vb,true);
  26.         edjesMap.put(va,sub);
  27.         Map<Integer,Boolean> sub1 = new HashMap();
  28.         sub1 = edjesMap.get(vb);
  29.         sub1.put(va,true);
  30.         edjesMap.put(vb,sub1);
  31. }
but when i made the reapir in my semi-full code, it still wrong.
 i cant show u the full code because is too bigg
but do u know a way that that could go wrong

note:the error is in that part of the code.

i can show the page of the code, but will not compile ,because , all the other classes are in diferente pages

watch:

(ps : that is the class object, resposeble for holding all the hashmap and arraylists that hold vertex , surfaces,and edjes

ps : the error is in the function addSurf, this one should create the surface and check if the edjes of that surface already exist, if not it will create them)
Copy code
  2. ArrayList objs = new ArrayList();
  3. // CLASS -----------------------------------------------------------------------------------------------------------------
  4. class obj {
  5.   obj() {
  6.   }
  7.   obj(float x ,float y , float z) {
  8.     posx = x;
  9.     posy = y;
  10.     posz = z;
  11.   }
  12.   obj(float x ,float y , float z,float rx ,float ry , float rz) {
  13.     posx = x;
  14.     posy = y;
  15.     posz = z;
  16.     rotx = rx;
  17.     roty = ry;
  18.     rotz = rz;
  19.   }
  20.   // VARIABLES -----------------------------------------------------------------------------------------------------------------
  21.   boolean selected = false;
  22.   ArrayList surfs = new ArrayList();
  23.   ArrayList edjes = new ArrayList();
  24.  Map <Integer,vert> verts = new HashMap<Integer,vert>();
  25.   Map<Integer, Map<Integer,Boolean>> edjesMap = new HashMap();
  26.   int[] selectVerts =new int [0];
  27.   int[] selectFaces =new int [0];
  28.   int[] selectEdjes =new int [0];
  29.   
  30.   
  31.   float posx=0;
  32.   float posy=0;
  33.   float posz=0;
  34.   int sPosx;
  35.   int sPosy;
  36.   float rotx = 0;
  37.   float roty = 0;
  38.   float rotz = 0;
  39.   boolean visible = false;
  40.   int cont = -1;
  41.   int  []delVerts = new int[0];
  42.   
  43.   
  44. //EDJE_CONTROLL------------------------------------------------------------------------------------------------------------------------   
  45.  
  46.   void edjesMove() {
  47.     for(int i = 0; i < edjes.size();i++) {
  48.       edje e = (edje) edjes.get(i);
  49.       vert v1 = (vert) verts.get(e.v1);
  50.       vert v2 = (vert) verts.get(e.v2);
  51.       e.cPosx = (v1.posx + v2.posx)*0.5;
  52.       e.cPosy = (v1.posy + v2.posy)*0.5;
  53.       e.cPosz = (v1.posz + v2.posz)*0.5;
  54.     }
  55.     
  56.   
  57.   }
  58. // CLASS FUNCTIONS -----------------------------------------------------------------------------------------------------------------
  59.   void facesMove() {
  60.     for(int i = 0; i < surfs.size();i++) {
  61.       surf s =(surf) surfs.get(i);
  62.       vert v1 = (vert) verts.get(s.p1);
  63.       vert v2 = (vert) verts.get(s.p2);
  64.       vert v3 = (vert) verts.get(s.p3);
  65.       
  66.       s.cPosx = (v1.posx + v2.posx + v3.posx)*0.333;
  67.       s.cPosy = (v1.posy + v2.posy + v3.posy)*0.333;
  68.       s.cPosz = (v1.posz + v2.posz + v3.posz)*0.333;
  69.       
  70.     }  
  71.   }
  72.   // CREATE VERTEX -----------------------------------------------------
  73.   int createVert(float x, float y , float z) {
  74.     
  75.     if(delVerts.length >0){
  76.       int i = delVerts[delVerts.length -1];
  77.       delVerts = shorten(delVerts);
  78.       verts.put(i,new vert(x,y,z,i));
  79.       return i;
  80.     }
  81.     else{
  82.       cont++;
  83.       verts.put(cont,new vert(x,y,z,cont));
  84.       return cont;
  85.     }
  86.     
  87.   }
  88.   // DELETE VERTEX -----------------------------------------------------
  89.   void delVert(int i){
  90.     delVerts = append(delVerts,i);
  91.     verts.remove(i);
  92.   
  93.   }


  96.   // ADDING SURFS -----------------------------------------
  97.   void addSurf(int a , int b, int c) {
  98.     int va = 0;
  99.     int vb = 0;
  100.     int vc = 0;
  101.     surfs.add(new surf(a,b,c));
  102.     for(int i= 0; i<3 ; i++) {
  103.            if(i == 0) {va =a;vb = b; vc = c;}
  104.       else if(i == 1) {va =c;vb = a; vc = b;}
  105.       else if(i == 2) {va =b;vb = a; vc = c;}
  106.       Map<Integer,Boolean> sub = new HashMap();
  107.       
  108.      boolean help;
  109.       // AAAAA-------------------
  110.       
  111.         sub = edjesMap.get(va);
  112.       if(sub == null){
  113.         sub = new HashMap();
  114.       }
  115.       
  116.       // BBBBB-------------------
  117.       help = sub.get(vb);
  118.       if(help == null) {
  119.         
  120.         sub.put(vb,true);
  121.         edjesMap.put(va,sub);
  122.         Map<Integer,Boolean> sub1 = new HashMap();
  123.         sub1 = edjesMap.get(vb);
  124.        if(sub1 == null) {
  125.           sub1 = new HashMap();
  126.         }
  127.         sub1.put(va,true);
  128.         edjesMap.put(vb,sub1);
  129.         edjes.add(new edje(va,vb));
  130.         
  131.       }
  132.       //-----
  133.       
  134.       // CCCCC-------------------
  135.       /*try{
  136.         help = sub.get(vc);
  137.       }
  138.       catch(Exception e ){
  139.         e.printStackTrace();
  140.         sub.put(vc,true);
  141.         HashMap<Integer,Boolean> sub1 = new HashMap();
  142.         try{
  143.           sub1 = edjesMap.get(vc);
  144.           sub1.put(va,true);
  145.         }
  146.         catch(Exception w ){
  147.           w.printStackTrace();
  148.           sub1.put(va,true);
  149.         }
  150.         edjesMap.put(vc,sub1);
  151.         edjes.add(new edje(va,vc));
  152.       }*/
  153.       
  154.       
  155.     }
  156.   }
  157. }

if it is any way form e send u the full project´
plz say.
:D
ty for u ilemited patience.
:D

just one more thing is u are interested in elpping me in this project i will be very grateffull(let me know)
note:
this project is a software toedit and  create geometry 
 then will slice the geometric in 2d data to be later printer in a 3d printer that im doing
 
if u were interested let me know and i will tell u more of wht is done and wht is stilll needed to do
:D
cya
quarks
quarks

Re: can somebody tell me were this is wrong :D

1 month ago
If you look in the fist block of code you pasted - in section BBB lines 27 - 30 are

27      Map<Integer,Boolean> sub1 = new HashMap();
28      sub1 = edjesMap.get(vb);
29      sub1.put(va,true);
30      edjesMap.put(vb,sub1);

In line 27 you create a new HashMap called sub1 but then the statement in line 28 replaces it with one from edjesMap but if it doesn't exist then sub1 becomes null. Then you get an error on line 29 . Replace lines 27-30 with

Copy code
  1. Map<Integer,Boolean> sub1 = edjesMap.get(vb);
  2. if(sub1 == null)
  3.   sub1 = new HashMap();
  4. sub1.put(va,true);
  5. edjesMap.put(vb,sub1);
mmm.fuinha
mmm.fuinha

Re: Re: can somebody tell me were this is wrong :D

1 month ago
i replace and still an error

watch blue part:
Copy code
  2. ArrayList objs = new ArrayList();
  3. // CLASS -----------------------------------------------------------------------------------------------------------------
  4. class obj {
  5.   obj() {
  6.   }
  7.   obj(float x ,float y , float z) {
  8.     posx = x;
  9.     posy = y;
  10.     posz = z;
  11.   }
  12.   obj(float x ,float y , float z,float rx ,float ry , float rz) {
  13.     posx = x;
  14.     posy = y;
  15.     posz = z;
  16.     rotx = rx;
  17.     roty = ry;
  18.     rotz = rz;
  19.   }
  20.   // VARIABLES -----------------------------------------------------------------------------------------------------------------
  21.   boolean selected = false;
  22.   ArrayList surfs = new ArrayList();
  23.   ArrayList edjes = new ArrayList();
  24.  Map <Integer,vert> verts = new HashMap<Integer,vert>();
  25.   Map<Integer, Map<Integer,Boolean>> edjesMap = new HashMap();
  26.   int[] selectVerts =new int [0];
  27.   int[] selectFaces =new int [0];
  28.   int[] selectEdjes =new int [0];
  29.   
  30.   
  31.   float posx=0;
  32.   float posy=0;
  33.   float posz=0;
  34.   int sPosx;
  35.   int sPosy;
  36.   float rotx = 0;
  37.   float roty = 0;
  38.   float rotz = 0;
  39.   boolean visible = false;
  40.   int cont = -1;
  41.   int  []delVerts = new int[0];
  42.   
  43.   
  44. //EDJE_CONTROLL------------------------------------------------------------------------------------------------------------------------   
  45.  
  46.   void edjesMove() {
  47.     for(int i = 0; i < edjes.size();i++) {
  48.       edje e = (edje) edjes.get(i);
  49.       vert v1 = (vert) verts.get(e.v1);
  50.       vert v2 = (vert) verts.get(e.v2);
  51.       e.cPosx = (v1.posx + v2.posx)*0.5;
  52.       e.cPosy = (v1.posy + v2.posy)*0.5;
  53.       e.cPosz = (v1.posz + v2.posz)*0.5;
  54.     }
  55.     
  56.   
  57.   }
  58. // CLASS FUNCTIONS -----------------------------------------------------------------------------------------------------------------
  59.   void facesMove() {
  60.     for(int i = 0; i < surfs.size();i++) {
  61.       surf s =(surf) surfs.get(i);
  62.       vert v1 = (vert) verts.get(s.p1);
  63.       vert v2 = (vert) verts.get(s.p2);
  64.       vert v3 = (vert) verts.get(s.p3);
  65.       
  66.       s.cPosx = (v1.posx + v2.posx + v3.posx)*0.333;
  67.       s.cPosy = (v1.posy + v2.posy + v3.posy)*0.333;
  68.       s.cPosz = (v1.posz + v2.posz + v3.posz)*0.333;
  69.       
  70.     }  
  71.   }
  72.   // CREATE VERTEX -----------------------------------------------------
  73.   int createVert(float x, float y , float z) {
  74.     
  75.     if(delVerts.length >0){
  76.       int i = delVerts[delVerts.length -1];
  77.       delVerts = shorten(delVerts);
  78.       verts.put(i,new vert(x,y,z,i));
  79.       return i;
  80.     }
  81.     else{
  82.       cont++;
  83.       verts.put(cont,new vert(x,y,z,cont));
  84.       return cont;
  85.     }
  86.     
  87.   }
  88.   // DELETE VERTEX -----------------------------------------------------
  89.   void delVert(int i){
  90.     delVerts = append(delVerts,i);
  91.     verts.remove(i);
  92.   
  93.   }


  96.   // ADDING SURFS -----------------------------------------
  97.   void addSurf(int a , int b, int c) {
  98.     int va = 0;
  99.     int vb = 0;
  100.     int vc = 0;
  101.     surfs.add(new surf(a,b,c));
  102.     for(int i= 0; i<3 ; i++) {
  103.            if(i == 0) {va =a;vb = b; vc = c;}
  104.       else if(i == 1) {va =c;vb = a; vc = b;}
  105.       else if(i == 2) {va =b;vb = a; vc = c;}
  106.       Map<Integer,Boolean> sub = new HashMap();
  107.       
  108.      boolean help;
  109.       // AAAAA-------------------
  110.       
  111.         sub = edjesMap.get(va);
  112.       if(sub == null){
  113.         sub = new HashMap();
  114.       }
  115.       
  116.       // BBBBB-------------------
  117.       help = sub.get(vb);
  118.       if(help == null) { // the operator == is undifined for the argument type(s) boolean , null
  119.         
  120.         sub.put(vb,true);
  121.         edjesMap.put(va,sub);
  122.         Map<Integer,Boolean> sub1 = new HashMap();
  123.         sub1 = edjesMap.get(vb);
  124.        if(sub1 == null) {
  125.           sub1 = new HashMap();
  126.         }
  127.         sub1.put(va,true);
  128.         edjesMap.put(vb,sub1);
  129.         edjes.add(new edje(va,vb));
  130.         
  131.       }
  132.            
  133.     }
  134.   }
  135. }
  136. // STARTING OBJECTS -------------------------------

  138. void plane(float x, float y ,float z,float s){
  139.   
  140.   objs.add(new obj(x,y,z));
  141.   obj o = (obj) objs.get(objs.size() - 1);
  142.   int a = o.createVert((-1 *s),(-1*s),0f);
  143.   int w = o.createVert((-1*s),(1*s),0f);
  144.   int d = o.createVert((1*s),(1*s),0f);
  145.   int f = o.createVert((1*s),(-1*s),0f);
  146.   o.surfs.add(new surf(a,w,d));
  147.   o.surfs.add(new surf(d,f,a));
  148.  
  149.   o.facesMove();
  150.   o.edjesMove();
  151.   


  154. }

  156. void square(float x, float y ,float z,float s){
  157.   
  158.   objs.add(new obj(x,y,z));
  159.   obj o = (obj) objs.get(objs.size() - 1);
  160.   int a = o.createVert((-1 *s),(-1*s),(-1*s));
  161.   int w = o.createVert((-1*s),(1*s),(-1*s));
  162.   int d = o.createVert((1*s),(1*s),(-1*s));
  163.   int f = o.createVert((1*s),(-1*s),(-1*s));
  164.   int g = o.createVert((-1 *s),(-1*s),(1*s));
  165.   int h = o.createVert((-1*s),(1*s),(1*s));
  166.   int j = o.createVert((1*s),(1*s),(1*s));
  167.   int k = o.createVert((1*s),(-1*s),(1*s));
  168.   // botton Face ------------------------
  169.   
  170.   o.addSurf(a,w,d);
  171.   o.addSurf(d,f,a);
  172.   
  173.   // Top Face --------------------------
  174.   
  175.   o.addSurf(g,h,j);
  176.   o.addSurf(j,k,g);
  177.   // Left Face ------------------------
  178.   
  179.   o.addSurf(a,g,k);
  180.   o.addSurf(a,k,f);
  181.   // Right Face --------------------------
  182.   
  183.   o.addSurf(w,d,j);
  184.   o.addSurf(j,h,w);
  185.   //forwar Face -------------------------
  186.  
  187.   o.addSurf(k,j,d);
  188.   o.addSurf(d,f,k);
  189.   // Back Face --------------------------
  190.   
  191.   o.addSurf(a,g,h);
  192.   o.addSurf(h,w,a);
  193.   
  194.   o.facesMove();
  195.   o.edjesMove();

  197. }

  199. Still gives an error at the red part
  200. :(
PhiLho
PhiLho

Re: can somebody tell me were this is wrong :D

1 month ago
You have to learn the difference between Boolean (object) and boolean (primitive type).
GoToLoop
GoToLoop

Re: can somebody tell me were this is wrong :D

1 month ago
Java's 8 primitive data-types can't be assigned and compared to null.
Only object/reference variable types can have null.
mmm.fuinha
mmm.fuinha

Re: Re: can somebody tell me were this is wrong :D

1 month ago
ty all for helping me
::D



TTTTTTYYYYYYY       AAAAAALLLLLLLL!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Top Reply

Statistics

  • 12 Replies
  • 573  Views
  • 0 Followers

Tags

No tags available for this topic.

Actions

Related Posts