ArrayIndexOutOfBounds--Making a tilemap

Programming Questions

cmvitolo

ArrayIndexOutOfBounds--Making a tilemap

in Programming Questions • 3 years ago

I'm creating a side scrolling platform game, and the first step was to see if I could make the map. I have an array of integers to represent my tiles, and then I loop through my image array to load the actual images. Then, i would loop through the array to place each tile on the screen. I'm not sure why, but i keep get an arrayOutofBounds error, but I checked to make sure that the for loop was correct, and I'm not understanding the error. I posted the code below, except for the TileMap class and I am hoping someone can tell me what the problem is.

PImage bg;

TileMap map;

void setup()

{

size(3200,640);

map= new TileMap(100,20);

bg=loadImage("level_1_background.png");

for(int i=0;i<20;i++)

{

for(int j=0;j<100;j++)

{

if(tile_map[j][i]==0)

map.setTile(loadImage("blank.gif"),j,i);

if(tile_map[j][i]==1)

map.setTile(loadImage("tree_1.gif"),j,i);

if(tile_map[j][i]==2)

map.setTile(loadImage("tree_2.gif"),j,i);

if(tile_map[j][i]==3)

map.setTile(loadImage("tree_3.gif"),j,i);

if(tile_map[j][i]==4)

map.setTile(loadImage("tree_4.gif"),j,i);

if(tile_map[j][i]==5)

map.setTile(loadImage("tree_5.gif"),j,i);

if(tile_map[j][i]==6)

map.setTile(loadImage("tree_6.gif"),j,i);

if(tile_map[j][i]==7)

map.setTile(loadImage("tree_7.gif"),j,i);

if(tile_map[j][i]==8)

map.setTile(loadImage("tree_8.gif"),j,i);

if(tile_map[j][i]==9)

map.setTile(loadImage("tree_9.gif"),j,i);

if(tile_map[j][i]==10)

map.setTile(loadImage("tree_10.gif"),j,i);

if(tile_map[j][i]==11)

map.setTile(loadImage("tree_11.gif"),j,i);

if(tile_map[j][i]==12)

map.setTile(loadImage("tree_12.gif"),j,i);

if(tile_map[j][i]==13)

map.setTile(loadImage("tree_13.gif"),j,i);

if(tile_map[j][i]==14)

map.setTile(loadImage("tree_14.gif"),j,i);

if(tile_map[j][i]==15)

map.setTile(loadImage("tree_15.gif"),j,i);

if(tile_map[j][i]==16)

map.setTile(loadImage("tree_16.gif"),j,i);

if(tile_map[j][i]==17)

map.setTile(loadImage("tree_17.gif"),j,i);

if(tile_map[j][i]==18)

map.setTile(loadImage("tree_18.gif"),j,i);

if(tile_map[j][i]==19)

map.setTile(loadImage("tree_19.gif"),j,i);

if(tile_map[j][i]==20)

map.setTile(loadImage("tree_20.gif"),j,i);

if(tile_map[j][i]==21)

map.setTile(loadImage("tree_21.gif"),j,i);

if(tile_map[j][i]==22)

map.setTile(loadImage("tree_22.gif"),j,i);

if(tile_map[j][i]==23)

map.setTile(loadImage("tree_23.gif"),j,i);

if(tile_map[j][i]==24)

map.setTile(loadImage("tree_24.gif"),j,i);

if(tile_map[j][i]==25)

map.setTile(loadImage("tree_25.gif"),j,i);

if(tile_map[j][i]==26)

map.setTile(loadImage("tree_26.gif"),j,i);

if(tile_map[j][i]==27)

map.setTile(loadImage("tree_27.gif"),j,i);

if(tile_map[j][i]==28)

map.setTile(loadImage("tree_28.gif"),j,i);

if(tile_map[j][i]==29)

map.setTile(loadImage("tree_29.gif"),j,i);

if(tile_map[j][i]==31)

map.setTile(loadImage("Platform1.png"),j,i);

if(tile_map[j][i]==32)

map.setTile(loadImage("platform2.png"),j,i);

if(tile_map[j][i]==33)

map.setTile(loadImage("platform3.png"),j,i);

if(tile_map[j][i]==34)

map.setTile(loadImage("tree_bush.gif"),j,i);

if(tile_map[j][i]==35)

map.setTile(loadImage("rock 1.png"),j,i);

if(tile_map[j][i]==36)

map.setTile(loadImage("rock2.png"),j,i);

if(tile_map[j][i]==37)

map.setTile(loadImage("rock3.png"),j,i);

if(tile_map[j][i]==38)

map.setTile(loadImage("rock6.png"),j,i);

if(tile_map[j][i]==39)

map.setTile(loadImage("bridge_1.png"),j,i);

if(tile_map[j][i]==40)

map.setTile(loadImage("bridge_2.png"),j,i);

if(tile_map[j][i]==41)

map.setTile(loadImage("bridge_3.png"),j,i);

}

void draw()

{

image(bg,0,0);

for(int i=0; i< map.getHeight();i++)

{

for(int j=0;j< map.getWidth();j++)

{

image(map.getTile(j,i),gpft(j),gpft(i));

}

int gpft(int t) //get pixels from tiles

{

return t*32;

}

int[][]tile_map={

{0,0,0,0,0,0,0,0,0,0,0,0,1,2,3,4,5,0,

0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1,

2,3,4,5,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,0,0,0,0,0,0,0,0

{0,0,0,0,0,0,0,0,0,0,0,0,6,7,8,9,10,0,

0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,6,7,

8,9,10,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,0,0,0,0,0

{0,0,0,0,0,0,0,0,0,0,0,0,11,12,13,14,

15,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,11,12,13,14,15,0,0,0,0,0,0,0,0,

0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,0,0,0,0,0,0,32,32,32,32,0,0,0,

0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,0

{0,0,0,0,0,0,0,0,0,0,0,0,16,17,18,19,

20,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,16,17,18,19,20,0,0,0,0,0,0,0,0,

0,0,0,0,0,0,0,0,0,0,0,0,0,0,34,0,0,

0,0,0,0,0,32,32,32,36,36,36,36,34,0,

0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,0

{0,0,0,0,0,0,0,0,0,0,0,0,0,0,21,22,0,

0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,21,22,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,0,0,0,0,0,0,0,31,32,33,0,0,0,0,

31,32,32,32,32,32,32,32,32,32,33,0,0,

0,0,0,0,0,0,0,0,0,0,34,34,0,0,0,0,0,

0,0

{0,0,0,0,0,0,0,0,0,0,0,0,0,23,24,25,0,

0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

23,24,25,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,0,0,0,0,32,0,35,37,38,0,0,0,0,35,

36,36,36,36,36,36,36,36,36,38,0,0,0,

0,0,0,0,0,0,0,0,32,32,32,32,32,32,32,

32,33,0

{0,0,0,0,0,0,0,34,34,0,0,34,0,26,27,28,

29,34,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,26,27,28,29,34,0,0,0,0,0,0,0,34,34,

0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

35,36,36,36,36,36,36,36,38,0,0,0,0,0,0,

0,0,0,0,0,0,36,36,36,36,36,36,36,36,38,

{0,31,32,32,32,32,32,32,32,32,32,32,32,

32,32,32,32,32,33,0,0,0,0,0,31,32,32,

32,32,32,32,32,32,32,32,32,32,32,32,32,

32,32,32,32,32,32,32,32,32,32,32,32,0,

0,0,0,32,32,33,0,0,0,0,0,0,0,0,0,0,0,

35,36,36,36,37,37,38,0,0,0,0,0,0,0,0,

0,34,34,0,0,36,36,36,36,36,36,36,38,0,

{0,35,36,36,36,36,36,36,36,36,36,36,36,

36,36,36,36,36,38,0,0,0,0,0,35,36,36,

36,36,36,36,36,36,36,36,36,36,36,36,36,

36,36,36,36,36,36,36,36,36,36,36,36,0,

0,0,0,36,36,38,0,31,32,33,0,0,0,0,0,0,

0,0,37,37,37,0,0,0,0,0,0,0,0,0,0,32,

32,32,32,32,32,32,32,33,37,37,37,37,0,

0,0

{0,0,35,36,36,36,36,36,36,36,36,36,36,

36,36,36,36,38,0,0,0,31,33,0,0,35,36,

36,36,36,36,36,36,36,36,36,36,36,36,

36,32,32,32,32,36,38,0,0,36,36,36,33,

0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,36,36,36,36,36,36,36,36,38,0,0,

0,0,0,0,0

{0,0,0,35,37,37,37,36,36,36,37,37,37,

37,37,37,38,0,0,0,0,37,37,0,0,0,35,

36,36,36,36,36,36,36,36,36,36,36,36,

36,36,36,36,36,38,0,0,0,36,36,36,36,

32,33,0,0,0,0,39,40,40,40,40,41,0,0,

0,0,0,0,0,34,36,36,36,36,36,36,36,38,

0,0,0,0,0,0,0,0

{0,0,0,0,0,0,0,37,37,37,0,0,0,0,0,0,0,

34,0,0,0,0,0,0,0,0,0,35,37,35,36,36,

36,36,36,36,36,36,36,36,36,36,36,36,

36,36,36,36,36,36,36,36,36,36,36,38,

0,0,0,0,35,36,36,36,36,36,32,32,32,

32,0,0,0,0,0,0,32,32,32,32,32,32,32,

32,33,37,36,36,37,37,37,0,0,0,0,0,0,

0,0,0

{0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,31,

32,33,0,0,0,0,0,0,0,0,0,0,35,37,37,37,

37,37,37,37,37,37,37,37,37,37,37,37,

37,37,37,37,37,37,37,37,38,0,0,0,0,0,

0,35,36,36,36,36,36,36,36,36,0,0,0,0,

0,0,35,36,36,36,36,36,36,36,38,0,37,

37,0,0,0,0,0,0,0,0,0,0,0,0

{0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,37,

37,37,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,0,0,0,0,0,0,37,37,36,36,36,36,36,

37,0,0,0,0,0,0,0,35,36,36,36,36,

36,38,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0

{0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,0,0,31,32,32,33,0,0,0,0,0,0,0,0,

0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,0,0,0,0,0,0,0,0,0,0,35,37,37,37,

38,0,0,0,0,0,0,0,0,0,37,37,37,37,

37,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0

{0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,0,0,36,36,36,36,0,0,0,0,0,0,0,0,

0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,0,0,0,0,0,0,0,0,0,0

{0,0,0,0,0,0,0,0,0,0,0,34,34,0,0,0,0,

0,0,34,31,32,36,36,36,36,0,0,0,0,0,0,

0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,0,0,0,0,0,0,0,0,0,0,0,0

{0,0,0,0,0,0,0,0,0,0,31,32,32,32,32,

32,32,32,32,32,32,32,32,32,32,32,32,

33,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0

{0,0,0,0,0,0,0,0,0,0,35,36,36,36,36,

36,36,36,36,36,36,36,36,36,36,36,36,

38,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0,0

{0,0,0,0,0,0,0,0,0,0,0,35,36,36,36,

36,36,36,36,36,36,36,36,36,36,36,38,

0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

0,0

}

};

Replies(6)

kevin.bjo..

Re: ArrayIndexOutOfBounds--Making a tilemap

3 years ago

You didn't say where the error occurred, nor did you supply a reference to the TileMap class, so.. hard to debug. Could be in those long tile_map declarations instead of the loops?

kb, http://www.riftgame.com/

cmvitolo

Re: Re: ArrayIndexOutOfBounds--Making a tilemap

3 years ago

The error is happens in this area:

for(int i=0;i<20;i++)

{

for(int j=0;j<100;j++)

{

if(tile_map[j][i]==0)

map.setTile(loadImage("blank.gif"),j,i);

if(tile_map[j][i]==1)

map.setTile(loadIma

As for the TileMap class, I didn't post because I don't see how that would have related to it. I used the methods from that class, but there was no array. Here it is:

class TileMap

{

public int width, height;

PImage[][] tiles;

TileMap(int x, int y)

{

this.width = x;

this.height = y;

tiles = new PImage[y][x];

}

int getWidth()

{

return width;

}

int getHeight()

{

return height;

}

void setTile(PImage image, int x, int y)

{

tiles[y][x] = image;

}

PImage getTile(int x, int y)

{

if(x < 0 || x > width || y < 0 || y > height)

{

println("Tile doesn't exist");

return null;

}

else

{

return tiles[y][x];

}

blindfish

Re: ArrayIndexOutOfBounds--Making a tilemap

3 years ago

Re: solving the problem - ditto what kb says.

But also look at switch() as that would be a far more efficient way of handling those conditions... Though in actual fact I'd be tempted to put the image file names in an array then you wouldn't need conditions at all. i.e.

imagesArray = { "blank.gif", "tree_1.gif", "tree_2.gif", etc... };
//<snip>
for(int i=0;i<20;i++) {
for(int j=0;j<100;j++) {
// I've separated these out for clarity
int imageIndex = tile_map[i][j];
String imageName = imagesArray[imageIndex];
map.setTile(loadImage(imageName),j,i); // you may need to reverse the i & j here also?
}
}

You might also consider loading the tilemaps from separate text files: it may be easier to generate and manage them that way (e.g. using something like Excel (you could perhaps use autoformat to colour cells based on content to give you an idea of what it would look like) and saving to CSV).

[edit: fixed the index ref problem in this code - I really should know better than to just copy-paste!]

kevin.bjo..

Re: ArrayIndexOutOfBounds--Making a tilemap

3 years ago

For efficiency, why not make your bg width be the screen width + 2 tiles. That way you only update single columns as you scroll... and then just use two calls to copy() instead of one call to image() to place the scrolling bg on-screen.

kb, http://www.riftgame.com/

blindfish

Re: ArrayIndexOutOfBounds--Making a tilemap

3 years ago

OK - my previous advice re the conditions still stands: your approach is grossly inefficient...

As for the solution to your problem. It was staring us in the face! You have 20 elements in the outer array each containing an array of 100 elements...

for(int i=0;i<20;i++) {
for(int j=0;j<100;j++) {
if(tile_map[j][i]==0)
//...
}
}

Look again at the order in which you're using the i and j values to reference the arrays...

cmvitolo

Re: Re: ArrayIndexOutOfBounds--Making a tilemap

3 years ago

haha wow. I had the i and j values originally in the right spot, but i got the error, but the real problem was that i didn't change the x and y values in the actual TileMap class! it works now. thank you for your help!