Array Problem

Programming Questions

amusingfu..

in Programming Questions • 1 year ago

Hey I wanted to make fish class and the bubbles should be part of the fish. and the bubbles should come out of the fish mouth. but they are giving me error when i try to run the programme. I am unable to figure out the solution to this problem. can any body help me correcting the code please and how to make the bubbles class work and the bubbles come out of each fish mouth. the size of the bubbles array is 5 means each fish should only emit 5 bubbles.

is there anything that can be done about it.

i hope i can get an answer soon.. thanks

int TANK_LEFT;

int TANK_RIGHT;

int TANK_TOP;

int TANK_BOTTOM;

int WATER_TOP;

/*The Fish class holds all the info pertinent to a single

fish: location, size, direction, colour, and speed.*/

class Bubble{

int x,y,w,h;

Bubble (int b1, int b2, int b3, int b4){

x = b1;

y = b2;

w = b3;

h = b4;

}

Fish[] f;

class Fish{ // Be consistent in your naming conventions!

int x,y,w,h,dir,r,g,b;

float speed,boost;

Bubble[] bub; // Don't forget to init it: give it a size and set each member in a loop

Fish(int p1,int p2,int p3,int p4,int p5,int p6,int p7,int p8,float p9){

x = p1;

y = p2;

w = p3;

h = p4;

dir = p5;

r = p6; // Pass a color(r, g, b) instead, only one param!

g = p7;

b = p8;

speed = p9;

boost = 0; //initially zero

}

void setup() {

frameRate(200);

size(800,600); //feel free to change this, all the code will change relative to it

setConstants(); //initialize the tank size

f = new Fish [10];

for (int i=0; i<f.length; i++)

f[i] = makeFish();

}

/*The setConstants() method sets the size of the tank

relative to the size of the canvas. If the canvas is

too small the program exits with a warning message*/

void setConstants(){

if(height<250 || width < 200){

println("Sorry, needs a bigger canvas");

exit();

}

TANK_LEFT = int(width*.15);

TANK_RIGHT = width-int(width*.15);

TANK_BOTTOM = height-100;

TANK_TOP = height - TANK_BOTTOM;

WATER_TOP = TANK_TOP + int((TANK_BOTTOM-TANK_TOP)*.2);

}

/*The draw method is the simulation loop of our program. It

simply moves the fish, and then redraws the scene*/

void draw(){

drawBackground();

for (int i=0; i<f.length;i++)

moveFish (f[i]);

for (int i=0; i<f.length;i++)

drawFish (f[i]);

drawForeground();

}

/*The makeFish() method generates some random values, and then

creates a fish object based on those values.

Returns:

Fish - A fish object with randomized parameters*/

Fish makeFish(){

//generate random values

int randw = (int)random(30, 50);

int randh = (int)random(randw-20, randw);

int randD = (int)(random(360));

int randx = (int)random(TANK_LEFT+randw, TANK_RIGHT-randw);;

int randy = (int)random(WATER_TOP, TANK_BOTTOM-(randh/2));

int randr = (int)random(0, 256);

int randg = (int)random(0, 256);

int randb = (int)random(0, 256);

float randSpeed = random(3) + 3;

//call the constructor, and return the Fish object it returns

return new Bubble (randx,randy,5,5);

return new Fish(randx,randy,randw,randh,randD,randr,randg,randb,randSpeed,Bubble[5]);

}

/*moveFish() updates the location of a given fish based on

the bouncing ball mechanics discussed in class

Parameters:

Fish f - a fish object to be moved*/

void moveFish(Fish f){

f.x = f.x + (int)((f.speed+f.boost)*cos(radians(f.dir)));

f.y = f.y + (int)((f.speed+f.boost)*sin(radians(f.dir)));

f.boost = f.boost*0.96;

if(f.x-(f.w/2) <= TANK_LEFT){

f.dir = (180-f.dir) % 360;

f.x = TANK_LEFT+f.w;

}

if(f.x+(f.w/2) >= TANK_RIGHT) {

f.dir = (180-f.dir) % 360;

f.x = TANK_RIGHT - f.w;

}

if(f.y <= WATER_TOP){

f.dir = -f.dir;

f.y=WATER_TOP;

}

if(f.y+(f.h/2) >= TANK_BOTTOM) {

f.dir = -f.dir;

f.y=TANK_BOTTOM - f.h/2;

}

/*drawBackground() organizes any background drawing that must

be done*/

void drawBackground() {

//wall

background(128, 50, 50);

//floor

stroke(0);

fill(100, 56, 0);

rect(0, int(height*.7), width, int(height*.3));

drawTable();

drawAquariumBack();

}

/*The drawTable method draws a 3d table beneath where the

fish tank will go*/

void drawTable() {

//table legs

stroke(0);

fill(160, 116, 60); //shade

//back left leg

rect(TANK_LEFT, TANK_BOTTOM+50, 25, 15);

triangle(TANK_LEFT+25, TANK_BOTTOM+50, TANK_LEFT+35, TANK_BOTTOM+50, TANK_LEFT+25, TANK_BOTTOM+65);

//back right leg

rect(TANK_RIGHT+40, TANK_BOTTOM-50, 25, 115);

fill(200, 156, 100); //unshaded

quad(TANK_RIGHT+65, TANK_BOTTOM+65, TANK_RIGHT+75, TANK_BOTTOM+40, TANK_RIGHT+75, TANK_BOTTOM-100, TANK_RIGHT+65, TANK_BOTTOM-100);

//front left leg

rect(TANK_LEFT-50, TANK_BOTTOM+50, 25, 50);

fill(160, 116, 60);

quad(TANK_LEFT-25, TANK_BOTTOM+50, TANK_LEFT-15, TANK_BOTTOM+50, TANK_LEFT-15, TANK_BOTTOM+100, TANK_LEFT-25, TANK_BOTTOM+100);

//front right leg

fill(200, 156, 100);

rect(TANK_RIGHT, TANK_BOTTOM+50, 25, 50);

quad(TANK_RIGHT+25, TANK_BOTTOM, TANK_RIGHT+35, TANK_BOTTOM, TANK_RIGHT+35, TANK_BOTTOM+100, TANK_RIGHT+25, TANK_BOTTOM+100);

//table top

quad(TANK_LEFT-50, TANK_BOTTOM+25, TANK_LEFT+30, TANK_BOTTOM-100, TANK_RIGHT+75, TANK_BOTTOM-100, TANK_RIGHT+25, TANK_BOTTOM+25); //top

rect(TANK_LEFT-50, TANK_BOTTOM+25, (TANK_RIGHT+25)-(TANK_LEFT-50), 25); //front

quad(TANK_RIGHT+25, TANK_BOTTOM+25, TANK_RIGHT+75, TANK_BOTTOM-100, TANK_RIGHT+75, TANK_BOTTOM-75, TANK_RIGHT+25, TANK_BOTTOM+50); //side

}

/*drawAquariumBack draws the bottom, back, and left panes of

the fish tank.*/

void drawAquariumBack() {

//aquarium

stroke(255);

fill(255, 255, 255, 20); //faint white tint

rect(TANK_LEFT+40, TANK_TOP-60, (TANK_RIGHT+25)-(TANK_LEFT+40), (TANK_BOTTOM-60)-(TANK_TOP-60)); //back

quad(TANK_LEFT, TANK_BOTTOM, TANK_LEFT+40, TANK_BOTTOM-60, TANK_RIGHT+25, TANK_BOTTOM-60, TANK_RIGHT, TANK_BOTTOM); //bottom

quad(TANK_LEFT, TANK_BOTTOM, TANK_LEFT+40, TANK_BOTTOM-60, TANK_LEFT+40, TANK_TOP-60, TANK_LEFT, TANK_TOP);//back-left

}

/*drawFish draws a fish based on the provided parameters.

Parameters:

Fish f - The fish to be drawn

void drawFish(Fish f) {

stroke(0);

fill(f.r, f.g, f.b);

ellipse(f.x, f.y, f.w, f.h);

int tail;

if ((f.dir <90 && f.dir>=-90)||f.dir>=270||f.dir<-270) { //right

tail = -(f.w/2);

fill(255);

ellipse(f.x+(f.w*0.25), f.y-(f.h*0.25), 10, 10);

fill(0);

ellipse(f.x+(f.w*0.25), f.y-(f.h*0.25), 5, 5);

}

else {

tail = (f.w/2);

fill(255);

ellipse(f.x-(f.w*0.25), f.y-(f.h*0.25), 10, 10);

fill(0);

ellipse(f.x-(f.w*0.25), f.y-(f.h*0.25), 5, 5);

}

fill(f.r, f.g, f.b);

triangle(f.x+tail, f.y, (f.x+(2*tail)), (f.y+(f.h/2)), (f.x+(2*tail)), (f.y-(f.h/2)));

}

/*drawForeground organizes all the items that need to be drawn

after the fish*/

void drawForeground() {

drawWater();

drawAquariumFront();

}

/*drawWater draws 3 panes of water on top of the fish to imitate

a rectangular prism. Water is tinted translucent blue.*/

void drawWater() {

noStroke();

fill(50, 100, 255, 100); //translucent blue

rect(TANK_LEFT, WATER_TOP, TANK_RIGHT-TANK_LEFT, TANK_BOTTOM-WATER_TOP); //front face

quad(TANK_RIGHT, WATER_TOP, TANK_RIGHT+25, WATER_TOP-60, TANK_RIGHT+25, TANK_BOTTOM-60, TANK_RIGHT, TANK_BOTTOM); //right face

stroke(0, 0, 56); //dark blue surface line

quad(TANK_LEFT,WATER_TOP,TANK_LEFT+40,WATER_TOP-60, TANK_RIGHT+25, WATER_TOP-60, TANK_RIGHT,WATER_TOP);//top face

}

/*drawAquariumFront() draws the front and right panes of the aquarium*/

void drawAquariumFront() {

//aquarium

stroke(255);

fill(255, 255, 255, 20);

rect(TANK_LEFT, TANK_TOP, TANK_RIGHT-TANK_LEFT, TANK_BOTTOM - TANK_TOP); //front

quad(TANK_RIGHT, TANK_TOP, TANK_RIGHT+25, TANK_TOP-60, TANK_RIGHT+25, TANK_BOTTOM-60, TANK_RIGHT, TANK_BOTTOM);//front-right

noFill();

quad(TANK_LEFT, TANK_TOP, TANK_LEFT+40, TANK_TOP-60, TANK_RIGHT+25, TANK_TOP - 60, TANK_RIGHT, TANK_TOP); //top

}

/*mousePressed() is an event handler called by Processing whenever

the user clicks the mouse. If the location of the mouse is within

the bounds of the aquarium's front face, a simulation of tapping

the glass takes place. A circle is drawn around the mouse, and

the fish speed away from the mouse*/

void mousePressed(){

if(mouseX<TANK_RIGHT && mouseX>TANK_LEFT &&

mouseY>WATER_TOP && mouseY<TANK_BOTTOM){

noFill();

stroke(255);

ellipse(mouseX,mouseY,25,25);

for (int i=0; i<f.length;i++)

scareFish(f[i]);

}

/*scareFish is a wrapper method to clean the repitition of

code five times with different fish variables.

It turns the given fish away from the mouse, and gives it

a boost to it's speed.

Parameters:

Fish f - the fish to scare*/

void scareFish(Fish f){

float tapDir = atan2(mouseY-f.y,mouseX-f.x);

f.dir = (int)(degrees(tapDir) + 180) % 360;

f.boost = f.speed;

}

Replies(10)

PhiLho

Re: Array Problem

1 year ago

If you make two topics with exactly the same subject, it is perhaps a hint you should have posted in the previous thread...

Beside, you haven't followed the advice I gave in your first thread. Multiplying the threads like this isn't good for continuity of discussion...

There, I advised to put the random number generation inside the constructor of Fish instead of passing a bunch of parameters. makeFish(), scareFish() and similar functions where you pass a Fish parameter or return one are actually code that belong to the class itself.
Instead of x = p1; just put directly x = (int)random(30, 50);
No need to create all these intermediary variables, and these parameters.

Your makeFish() function has two return statements. Only one is allowed in a function, how the compiler can pick one? And you can't return a Bubble in a function declaring to return a Fish.
Again, drop makeFish(), and move the code in the Fish constructor. There, make a loop to create the bubbles. A for () loop, assigning each new Bubble() to an array slot.

amusingfu..

Re: Array Problem

1 year ago

hey

I tried doing it the way you suggested but it gave me an error that it cannot find the component x. that is the reason i kept them same and asked for help in making the bubble work. i tried making the bubbles seperately but it says it cannot find anything name bub. following it the code im using. Can you help me correct the code if that is possible.

your help in this matter is highly appreciated.

thanks

//some useful constants (initialized in the setup)

int TANK_LEFT;

int TANK_RIGHT;

int TANK_TOP;

int TANK_BOTTOM;

int WATER_TOP;

/*The Fish class holds all the info pertinent to a single

fish: location, size, direction, colour, and speed.*/

class Bubble{

int x,y,w,h;

Bubble (int b1, int b2, int b3, int b4){

x = b1;

y = b2;

w = b3;

h = b4;

}

Fish[] f;

class Fish{ // Be consistent in your naming conventions!

int x,y,w,h,dir,r,g,b;

float speed,boost;

Bubble[] bub;

Fish(int p1,int p2,int p3,int p4,int p5,int p6,int p7,int p8,float p9){

float randSpeed = random(3) + 3;

x = p1;

y = p2;

w = p3;

h = p4;

dir = p5;

r = p6; // Pass a color(r, g, b) instead, only one param!

g = p7;

b = p8;

speed = p9;

boost = 0; //initially zero

}

void setup() {

frameRate(200);

size(800,600); //feel free to change this, all the code will change relative to it

setConstants(); //initialize the tank size

f = new Fish [10];

for (int i=0; i<f.length; i++)

f[i] = makeFish();

bub = new Bubble [5];

for (int i=0; i<bub.length;i++)

bub[i] = makeBubble();

}

/*The setConstants() method sets the size of the tank

relative to the size of the canvas. If the canvas is

too small the program exits with a warning message*/

void setConstants(){

if(height<250 || width < 200){

println("Sorry, needs a bigger canvas");

exit();

}

TANK_LEFT = int(width*.15);

TANK_RIGHT = width-int(width*.15);

TANK_BOTTOM = height-100;

TANK_TOP = height - TANK_BOTTOM;

WATER_TOP = TANK_TOP + int((TANK_BOTTOM-TANK_TOP)*.2);

}

/*The draw method is the simulation loop of our program. It

simply moves the fish, and then redraws the scene*/

void draw(){

drawBackground();

for (int i=0; i<f.length;i++)

moveFish (f[i]);

for (int i=0; i<f.length;i++)

drawFish (f[i]);

for (int i=0; i<bub.length;i++)

drawBubble (bub[i]);

drawForeground();

}

/*The makeFish() method generates some random values, and then

creates a fish object based on those values.

Returns:

Fish - A fish object with randomized parameters*/

Bubble makeBubble(){

Fish.Bubble.x = Fish.x;

Fish.Bubble.y = Fish.y;

Fish.Bubble.w = 5;

Fish.bubble.h = 5;

return new Bubble (Fish.x,Fish.y,5,5);

}

void drawBubble (Bubble bub){

if (Fish.dir = 0){

ellipse (Fish.x+Fish.w,Fish.y,5,5);

Bubble.y = Bubble.y + 1;

}else{

ellipse (Fish.x-Fish.w,Fish.y,5,5);

}

Fish makeFish(){

//generate random values

int randw = (int) random (20 , 50);

int randh = (int)random(randw-20, randw);

int randD = (int)(random(360));

int randx = (int)random(TANK_LEFT+randw, TANK_RIGHT-randw);;

int randy = (int)random(WATER_TOP, TANK_BOTTOM-(randh/2));

int randr = (int)random(0, 256);

int randg = (int)random(0, 256);

int randb = (int)random(0, 256);

float randSpeed = random(3) + 3;

//call the constructor, and return the Fish object it returns

return new Fish(randx,randy,randw,randh,randD,randr,randg,randb,randSpeed,Bubble[5]);

}

/*moveFish() updates the location of a given fish based on

the bouncing ball mechanics discussed in class

Parameters:

Fish f - a fish object to be moved*/

void moveFish(Fish f){

f.x = f.x + (int)((f.speed+f.boost)*cos(radians(f.dir)));

f.y = f.y + (int)((f.speed+f.boost)*sin(radians(f.dir)));

f.boost = f.boost*0.96;

if(f.x-(f.w/2) <= TANK_LEFT){

f.dir = (180-f.dir) % 360;

f.x = TANK_LEFT+f.w;

}

if(f.x+(f.w/2) >= TANK_RIGHT) {

f.dir = (180-f.dir) % 360;

f.x = TANK_RIGHT - f.w;

}

if(f.y <= WATER_TOP){

f.dir = -f.dir;

f.y=WATER_TOP;

}

if(f.y+(f.h/2) >= TANK_BOTTOM) {

f.dir = -f.dir;

f.y=TANK_BOTTOM - f.h/2;

}

/*drawBackground() organizes any background drawing that must

be done*/

void drawBackground() {

//wall

background(128, 50, 50);

//floor

stroke(0);

fill(100, 56, 0);

rect(0, int(height*.7), width, int(height*.3));

drawTable();

drawAquariumBack();

}

/*The drawTable method draws a 3d table beneath where the

fish tank will go*/

void drawTable() {

//table legs

stroke(0);

fill(160, 116, 60); //shade

//back left leg

rect(TANK_LEFT, TANK_BOTTOM+50, 25, 15);

triangle(TANK_LEFT+25, TANK_BOTTOM+50, TANK_LEFT+35, TANK_BOTTOM+50, TANK_LEFT+25, TANK_BOTTOM+65);

//back right leg

rect(TANK_RIGHT+40, TANK_BOTTOM-50, 25, 115);

fill(200, 156, 100); //unshaded

quad(TANK_RIGHT+65, TANK_BOTTOM+65, TANK_RIGHT+75, TANK_BOTTOM+40, TANK_RIGHT+75, TANK_BOTTOM-100, TANK_RIGHT+65, TANK_BOTTOM-100);

//front left leg

rect(TANK_LEFT-50, TANK_BOTTOM+50, 25, 50);

fill(160, 116, 60);

quad(TANK_LEFT-25, TANK_BOTTOM+50, TANK_LEFT-15, TANK_BOTTOM+50, TANK_LEFT-15, TANK_BOTTOM+100, TANK_LEFT-25, TANK_BOTTOM+100);

//front right leg

fill(200, 156, 100);

rect(TANK_RIGHT, TANK_BOTTOM+50, 25, 50);

quad(TANK_RIGHT+25, TANK_BOTTOM, TANK_RIGHT+35, TANK_BOTTOM, TANK_RIGHT+35, TANK_BOTTOM+100, TANK_RIGHT+25, TANK_BOTTOM+100);

//table top

quad(TANK_LEFT-50, TANK_BOTTOM+25, TANK_LEFT+30, TANK_BOTTOM-100, TANK_RIGHT+75, TANK_BOTTOM-100, TANK_RIGHT+25, TANK_BOTTOM+25); //top

rect(TANK_LEFT-50, TANK_BOTTOM+25, (TANK_RIGHT+25)-(TANK_LEFT-50), 25); //front

quad(TANK_RIGHT+25, TANK_BOTTOM+25, TANK_RIGHT+75, TANK_BOTTOM-100, TANK_RIGHT+75, TANK_BOTTOM-75, TANK_RIGHT+25, TANK_BOTTOM+50); //side

}

/*drawAquariumBack draws the bottom, back, and left panes of

the fish tank.*/

void drawAquariumBack() {

//aquarium

stroke(255);

fill(255, 255, 255, 20); //faint white tint

rect(TANK_LEFT+40, TANK_TOP-60, (TANK_RIGHT+25)-(TANK_LEFT+40), (TANK_BOTTOM-60)-(TANK_TOP-60)); //back

quad(TANK_LEFT, TANK_BOTTOM, TANK_LEFT+40, TANK_BOTTOM-60, TANK_RIGHT+25, TANK_BOTTOM-60, TANK_RIGHT, TANK_BOTTOM); //bottom

quad(TANK_LEFT, TANK_BOTTOM, TANK_LEFT+40, TANK_BOTTOM-60, TANK_LEFT+40, TANK_TOP-60, TANK_LEFT, TANK_TOP);//back-left

}

/*drawFish draws a fish based on the provided parameters.

Parameters:

Fish f - The fish to be drawn

void drawFish(Fish f) {

stroke(0);

fill(f.r, f.g, f.b);

ellipse(f.x, f.y, f.w, f.h);

int tail;

if ((f.dir <90 && f.dir>=-90)||f.dir>=270||f.dir<-270) { //right

tail = -(f.w/2);

fill(255);

ellipse(f.x+(f.w*0.25), f.y-(f.h*0.25), 10, 10);

fill(0);

ellipse(f.x+(f.w*0.25), f.y-(f.h*0.25), 5, 5);

}

else {

tail = (f.w/2);

fill(255);

ellipse(f.x-(f.w*0.25), f.y-(f.h*0.25), 10, 10);

fill(0);

ellipse(f.x-(f.w*0.25), f.y-(f.h*0.25), 5, 5);

}

fill(f.r, f.g, f.b);

triangle(f.x+tail, f.y, (f.x+(2*tail)), (f.y+(f.h/2)), (f.x+(2*tail)), (f.y-(f.h/2)));

}

/*drawForeground organizes all the items that need to be drawn

after the fish*/

void drawForeground() {

drawWater();

drawAquariumFront();

}

/*drawWater draws 3 panes of water on top of the fish to imitate

a rectangular prism. Water is tinted translucent blue.*/

void drawWater() {

noStroke();

fill(50, 100, 255, 100); //translucent blue

rect(TANK_LEFT, WATER_TOP, TANK_RIGHT-TANK_LEFT, TANK_BOTTOM-WATER_TOP); //front face

quad(TANK_RIGHT, WATER_TOP, TANK_RIGHT+25, WATER_TOP-60, TANK_RIGHT+25, TANK_BOTTOM-60, TANK_RIGHT, TANK_BOTTOM); //right face

stroke(0, 0, 56); //dark blue surface line

quad(TANK_LEFT,WATER_TOP,TANK_LEFT+40,WATER_TOP-60, TANK_RIGHT+25, WATER_TOP-60, TANK_RIGHT,WATER_TOP);//top face

}

/*drawAquariumFront() draws the front and right panes of the aquarium*/

void drawAquariumFront() {

//aquarium

stroke(255);

fill(255, 255, 255, 20);

rect(TANK_LEFT, TANK_TOP, TANK_RIGHT-TANK_LEFT, TANK_BOTTOM - TANK_TOP); //front

quad(TANK_RIGHT, TANK_TOP, TANK_RIGHT+25, TANK_TOP-60, TANK_RIGHT+25, TANK_BOTTOM-60, TANK_RIGHT, TANK_BOTTOM);//front-right

noFill();

quad(TANK_LEFT, TANK_TOP, TANK_LEFT+40, TANK_TOP-60, TANK_RIGHT+25, TANK_TOP - 60, TANK_RIGHT, TANK_TOP); //top

}

/*mousePressed() is an event handler called by Processing whenever

the user clicks the mouse. If the location of the mouse is within

the bounds of the aquarium's front face, a simulation of tapping

the glass takes place. A circle is drawn around the mouse, and

the fish speed away from the mouse*/

void mousePressed(){

if(mouseX<TANK_RIGHT && mouseX>TANK_LEFT &&

mouseY>WATER_TOP && mouseY<TANK_BOTTOM){

noFill();

stroke(255);

ellipse(mouseX,mouseY,25,25);

for (int i=0; i<f.length;i++)

scareFish(f[i]);

}

/*scareFish is a wrapper method to clean the repitition of

code five times with different fish variables.

It turns the given fish away from the mouse, and gives it

a boost to it's speed.

Parameters:

Fish f - the fish to scare*/

void scareFish(Fish f){

float tapDir = atan2(mouseY-f.y,mouseX-f.x);

f.dir = (int)(degrees(tapDir) + 180) % 360;

f.boost = f.speed;

}

PhiLho

Re: Array Problem

1 year ago

No need to repost the whole code each time, I suppose the tank drawing won't change. It would help to concentrate of the things that changed.

My advices are made to make the code less confusing and easier to manage, not to annoy you...
If you build the Fish variables in the constructor (the function named Fish()), it would make less stuff to pass around. Make the for loop creating the bubbles there.

return new Fish(randx,randy,randw,randh,randD,randr,randg,randb,randSpeed, Bubble[5]);
Bubble[5] doesn't make any sense there. You have to pass an array, which is an object (almost) like the others.
Beside, your constructor doesn't have such parameter!
Again, make a parameterless constructor and assign the Fish variables with the random calls there.

for (int i=0; i<f.length; i++)

f[i] = makeFish();

bub = new Bubble [5];

for (int i=0; i<bub.length;i++)

bub[i] = makeBubble();

bub doesn't exists, because it belongs to Fish, it isn't a global variable. If you put the last three lines in the Fish constructor (see a pattern there?), it will work.
But don't use makeFish or makeBubble functions! Use the constructors: f[i] = new Fish(); and bub[i] = new Bubble(x, y, w, h); <-- inside Fish's constructor, it will take its variables.

Bubble makeBubble(){

Fish.Bubble.x = Fish.x;

Fish.Bubble.y = Fish.y;

Fish.Bubble.w = 5;

Fish.bubble.h = 5;

return new Bubble (Fish.x,Fish.y,5,5);

}

void drawBubble (Bubble bub){

if (Fish.dir = 0){

ellipse (Fish.x+Fish.w,Fish.y,5,5);

Bubble.y = Bubble.y + 1;

}else{

ellipse (Fish.x-Fish.w,Fish.y,5,5);

}

In general, you cannot use Fish.x or Bubble.y
Fish and Bubble are classes, kind of blueprints, they have no real existence. Only after doing f = new Fish() you have a real object with values, and then you can use f.x, the x value of this specific instance.

Classes aren't simple structures to hold data. They have constructor and methods (internal functions) that can use the values of the current object. That's why makeFish, moveFish and similar belong to these classes.

See From several arrays to classes article for more explanation.

amusingfu..

Re: Array Problem

1 year ago

Hey.. I tried using your guide in this matter and as i understood.

can you tell me how can i give bubble x the value of fish x and bubble y the fish y value.

also it is giving me just one bubble where as i want to create 5 bubbles for each fish

thanks for your support

Chrisir

Re: Array Problem

1 year ago

maybe you got 5 bubbles and they are just on top of one another

bub[i] = makeBubble();

better

bub[i] = makeBubble(19);

and here

Bubble makeBubble(){
Fish.Bubble.x = Fish.x;
Fish.Bubble.y = Fish.y;
Fish.Bubble.w = 5;
Fish.bubble.h = 5;
return new Bubble (Fish.x,Fish.y,5,5);
}

better

Bubble makeBubble(int offsetY){
Fish.Bubble.x = Fish.x;
Fish.Bubble.y = Fish.y+offsetY;
Fish.Bubble.w = 5;
Fish.bubble.h = 5;
return new Bubble (Fish.x,Fish.y+offsetY,5,5);
}

PhiLho

Re: Array Problem

1 year ago

OK, I suppose I have confused you enough with my explanations...

And since you made heroic attempts at fixing this, I give the version applying my suggested changes, and more.
Study my changes attentively. If you are wondering about some changes I made, just ask.
I won't paste the background/foreground drawings, as I haven't changed them.

//some useful constants (initialized in the setup)
int TANK_LEFT;
int TANK_RIGHT;
int TANK_TOP;
int TANK_BOTTOM;
int WATER_TOP;
Fish[] fishes; // For global variables, explicit longer names are better
class Fish { // Be consistent in your naming conventions!
int x, y, w, h, dir, r, g, b;
float speed, boost;
Bubble[] bubbles = new Bubble[5];
Fish() {
//generate random values
w = (int) random (20, 50);
h = (int)random(w-20, w);
dir = (int)(random(360));
x = (int)random(TANK_LEFT+w, TANK_RIGHT-w);
y = (int)random(WATER_TOP, TANK_BOTTOM-h/2);
r = (int)random(0, 256);
g = (int)random(0, 256);
b = (int)random(0, 256);
speed = random(3) + 3;
// boost remains at 0
for (int i = 0; i < bubbles.length; i++) {
// posX and posY are relative to the fish's x and y
int posX = int(random(-3, 3)); // Put a little randomness in the bubble positions
int posY = -2 - int(5 * i * random(1, 2));
bubbles[i] = new Bubble(posX, posY, 5, 5);
}
}
/* Updates the location of a given fish based on
the bouncing ball mechanics discussed in class
*/
void move() { // Was moveFish()
x += (int)((speed+boost)*cos(radians(dir)));
y += (int)((speed+boost)*sin(radians(dir)));
boost *= 0.96;
if (x-w/2 <= TANK_LEFT) {
dir = (180-dir) % 360;
x = TANK_LEFT+w;
}
if (x+w/2 >= TANK_RIGHT) {
dir = (180-dir) % 360;
x = TANK_RIGHT - w;
}
if (y <= WATER_TOP) {
dir = -dir;
y = WATER_TOP;
}
if (y+h/2 >= TANK_BOTTOM) {
dir = -dir;
y = TANK_BOTTOM - h/2;
}
}
void draw() { // Was drawFish()
stroke(0);
fill(r, g, b);
ellipse(x, y, w, h);
int tail;
if (isFacingRight()) {
tail = -w/2;
fill(255);
ellipse(x+w*0.25, y-h*0.25, 10, 10);
fill(0);
ellipse(x+w*0.25, y-h*0.25, 5, 5);
}
else {
tail = w/2;
fill(255);
ellipse(x-w*0.25, y-h*0.25, 10, 10);
fill(0);
ellipse(x-w*0.25, y-h*0.25, 5, 5);
}
fill(r, g, b);
triangle(x+tail, y, x+2*tail, y+h/2, x+2*tail, y-h/2);
// Don't forget to draw the bubbles!
for (Bubble bubble : bubbles) {
bubble.draw();
}
}
/* Turns the given fish away from the mouse, and gives it
a boost to its speed.
*/
void scare() {
float tapDir = atan2(mouseY-y, mouseX-x);
dir = (int)(degrees(tapDir) + 180) % 360;
boost = speed;
}
boolean isFacingRight() {
int adir = abs(dir);
return adir <= 90 || adir >= 270;
}
// I put this class inside the Fish one since it isn't used elsewhere.
// Thus, a bubble accesses the fish parameters without needing a reference to it.
class Bubble {
int bx, by, bw, bh; // But we need a means to distinguish the bubble's variables from the fish's one
int disp; // displacement
Bubble (int b1, int b2, int b3, int b4) {
bx = b1;
by = b2;
bw = b3;
bh = b4;
}
void draw() { // Was drawBubble()
fill(0, 200, 220, 120); // Green-blue with transparency
// Use x and y from Fish
int posX;
if (isFacingRight()) {
posX = x + w/2 + 5;
} else {
posX = x - w/2 - 5;
}
ellipse(posX + bx, y + by + disp, bw, bh);
disp -= 1;
if (disp < -25) {
disp = 0; // Like a new bubble
// For a more realistic effect, shift the bubble positions in the array...
}
}
}
}
void setup() {
size(800, 600); //feel free to change this, all the code will change relative to it
frameRate(200);
setConstants(); //initialize the tank size
fishes = new Fish[10];
for (int i = 0; i < fishes.length; i++) {
fishes[i] = new Fish();
}
}
/*The setConstants() method sets the size of the tank
relative to the size of the canvas. If the canvas is
too small the program exits with a warning message*/
void setConstants() {
if (height < 250 || width < 200) {
println("Sorry, needs a bigger canvas");
exit();
}
TANK_LEFT = int(width*.15);
TANK_RIGHT = width-int(width*.15);
TANK_BOTTOM = height-100;
TANK_TOP = height - TANK_BOTTOM;
WATER_TOP = TANK_TOP + int((TANK_BOTTOM-TANK_TOP)*.2);
}
/*The draw method is the simulation loop of our program. It
simply moves the fish, and then redraws the scene*/
void draw() {
drawBackground();
// Shortcut for :
// for (int i = 0; i < fishes.length; i++) { Fish fish = fishes[i];
// Use whatever form you want
for (Fish fish : fishes) {
fish.move();
fish.draw();
}
drawForeground();
}
/*mousePressed() is an event handler called by Processing whenever
the user clicks the mouse. If the location of the mouse is within
the bounds of the aquarium's front face, a simulation of tapping
the glass takes place. A circle is drawn around the mouse, and
the fish speed away from the mouse*/
void mousePressed() {
if (mouseX < TANK_RIGHT && mouseX > TANK_LEFT &&
mouseY > WATER_TOP && mouseY < TANK_BOTTOM) {
noFill();
stroke(255);
ellipse(mouseX, mouseY, 25, 25);
for (Fish fish : fishes)
fish.scare();
}
}

amusingfu..

Re: Array Problem

1 year ago

Hey i am trying to do it with my file but it is still giving me errors

can you check it out

attacheced is the code thanks

int TANK_LEFT;
int TANK_RIGHT;
int TANK_TOP;
int TANK_BOTTOM;
int WATER_TOP;
/*The Fish class holds all the info pertinent to a single
fish: location, size, direction, colour, and speed.*/
Fish[] f;
class Fish {
int x, y, w, h, dir, r, g, b;
float speed, boost;
Bubble[] bub = new Bubble[5];
Fish(int p1, int p2, int p3, int p4, int p5, int p6, int p7, int p8, float p9 ) {
x = p1;
y = p2;
w = p3;
h = p4;
dir = p5;
r = p6;
b = p8;
speed = p9;
boost = 0; //initially zero
for (int i = 0; i < bub.length; i++) {
int posX = x + w;
int posY = y;
bub[i] = new Bubble(posX, posY, 5, 5);
}
}
}
void setup() {
frameRate(200);
size(800, 600); //feel free to change this, all the code will change relative to it
setConstants(); //initialize the tank size
f = new Fish [10];
for (int i=0; i<f.length; i++)
f[i] = makeFish();
}
/*The setConstants() method sets the size of the tank
relative to the size of the canvas. If the canvas is
too small the program exits with a warning message*/
void setConstants() {
if (height<250 || width < 200) {
println("Sorry, needs a bigger canvas");
exit();
}
TANK_LEFT = int(width*.15);
TANK_RIGHT = width-int(width*.15);
TANK_BOTTOM = height-100;
TANK_TOP = height - TANK_BOTTOM;
WATER_TOP = TANK_TOP + int((TANK_BOTTOM-TANK_TOP)*.2);
}
/*The draw method is the simulation loop of our program. It
simply moves the fish, and then redraws the scene*/
void draw() {
drawBackground();
for (int i=0; i<f.length;i++)
moveFish (f[i]);
for (int i=0; i<f.length;i++)
drawFish (f[i]);
}
/*The makeFish() method generates some random values, and then
creates a fish object based on those values.
Returns:
Fish - A fish object with randomized parameters*/
Fish makeFish() {
//generate random values
int randw = (int) random (20, 50);
int randh = (int)random(randw-20, randw);
int randD = (int)(random(360));
int randx = (int)random(TANK_LEFT+randw, TANK_RIGHT-randw);
;
int randy = (int)random(WATER_TOP, TANK_BOTTOM-(randh/2));
int randr = (int)random(0, 256);
int randg = (int)random(0, 256);
int randb = (int)random(0, 256);
float randSpeed = random(3) + 3;
//call the constructor, and return the Fish object it returns
return new Fish(randx, randy, randw, randh, randD, randr, randg, randb, randSpeed);
}
boolean isFacingRight() {
int adir = abs(dir);
return adir <= 90 || adir >= 270;
}
class Bubble {
int bx, by, bw, bh; // But we need a means to distinguish the bubble's variables from the fish's one
int disp; // displacement
Bubble (int b1, int b2, int b3, int b4) {
bx = b1;
by = b2;
bw = b3;
bh = b4;
}
void draw() { // Was drawBubble()
fill(0, 200, 220, 120); // Green-blue with transparency
// Use x and y from Fish
int posX;
if (isFacingRight()) {
posX = x + w/2 + 5;
}
else {
posX = x - w/2 - 5;
}
ellipse(posX + bx, y + by + disp, bw, bh);
disp -= 1;
if (disp < -25) {
disp = 0; // Like a new bubble
// For a more realistic effect, shift the bubble positions in the array...
}
}
}
void moveFish(Fish f) {
f.x = f.x + (int)((f.speed+f.boost)*cos(radians(f.dir)));
f.y = f.y + (int)((f.speed+f.boost)*sin(radians(f.dir)));
f.boost = f.boost*0.96;
if (f.x-(f.w/2) <= TANK_LEFT) {
f.dir = (180-f.dir) % 360;
f.x = TANK_LEFT+f.w;
}
if (f.x+(f.w/2) >= TANK_RIGHT) {
f.dir = (180-f.dir) % 360;
f.x = TANK_RIGHT - f.w;
}
if (f.y <= WATER_TOP) {
f.dir = -f.dir;
f.y=WATER_TOP;
}
if (f.y+(f.h/2) >= TANK_BOTTOM) {
f.dir = -f.dir;
f.y=TANK_BOTTOM - f.h/2;
}
}
void drawFish(Fish f) {
stroke(0);
fill(f.r, f.g, f.b);
ellipse(f.x, f.y, f.w, f.h);
int tail;
if ((f.dir <90 && f.dir>=-90)||f.dir>=270||f.dir<-270) { //right
tail = -(f.w/2);
fill(255);
ellipse(f.x+(f.w*0.25), f.y-(f.h*0.25), 10, 10);
fill(0);
ellipse(f.x+(f.w*0.25), f.y-(f.h*0.25), 5, 5);
}
else {
tail = (f.w/2);
fill(255);
ellipse(f.x-(f.w*0.25), f.y-(f.h*0.25), 10, 10);
fill(0);
ellipse(f.x-(f.w*0.25), f.y-(f.h*0.25), 5, 5);
}
fill(f.r, f.g, f.b);
triangle(f.x+tail, f.y, (f.x+(2*tail)), (f.y+(f.h/2)), (f.x+(2*tail)), (f.y-(f.h/2)));
for (Bubble bubble : bub) {
bubble.draw();
}
}
void mousePressed() {
if (mouseX<TANK_RIGHT && mouseX>TANK_LEFT &&
mouseY>WATER_TOP && mouseY<TANK_BOTTOM) {
noFill();
stroke(255);
ellipse(mouseX, mouseY, 25, 25);
for (int i=0; i<f.length;i++)
scareFish(f[i]);
}
}
/*scareFish is a wrapper method to clean the repitition of
code five times with different fish variables.
It turns the given fish away from the mouse, and gives it
a boost to it's speed.
Parameters:
Fish f - the fish to scare*/
void scareFish(Fish f) {
float tapDir = atan2(mouseY-f.y, mouseX-f.x);
f.dir = (int)(degrees(tapDir) + 180) % 360;
f.boost = f.speed;
}

PhiLho

Re: Array Problem

1 year ago

It looks like you are stuck to use the out-of-class functions that were given to you.
I see at least you integrated most of my changes, but the difficult part was to make a link between the bubbles and the fish they belong to. This link is necessary so that they follow the fish! The trick is to pass the fish as parameter to the bubble. Alternatively, in a heavier style fitting with the other constraints, you can pass the necessary fish parameters (x, y, w) to the bubble's draw() method.

//some useful constants (initialized in the setup)
int TANK_LEFT;
int TANK_RIGHT;
int TANK_TOP;
int TANK_BOTTOM;
int WATER_TOP;
Fish[] fishes; // For global variables, explicit longer names are better
class Fish { // Be consistent in your naming conventions!
int x, y, w, h, dir, r, g, b;
float speed, boost;
Bubble[] bub = new Bubble[5];
Fish(int p1, int p2, int p3, int p4, int p5, int p6, int p7, int p8, float p9 ) {
x = p1;
y = p2;
w = p3;
h = p4;
dir = p5;
r = p6;
b = p8;
speed = p9;
boost = 0; //initially zero
for (int i = 0; i < bub.length; i++) {
// posX and posY are relative to the fish's x and y
int posX = 0; // or int(random(-3, 3)); // Put a little randomness in the bubble positions
int posY = -2 - 5*i; // or -2 - int(5 * i * random(1, 2));
// this is a reference to the current fish
bub[i] = new Bubble(this, posX, posY, 5, 5);
}
}
}
class Bubble {
Fish f; // The fish producing the bubbles
int x, y, w, h;
int disp; // displacement
Bubble(Fish bf, int b1, int b2, int b3, int b4) {
f = bf;
x = b1;
y = b2;
w = b3;
h = b4;
}
void draw() {
fill(0, 200, 220, 120); // Green-blue with transparency
int posX;
if (isFacingRight(f)) {
posX = f.x + f.w/2 + 5;
}
else {
posX = f.x - f.w/2 - 5;
}
ellipse(posX + x, f.y + y + disp, w, h);
disp -= 1;
if (disp < -25) {
disp = 0; // Like a new bubble
// For a more realistic effect, shift the bubble positions in the array...
}
}
}
void setup() {
size(800, 600); //feel free to change this, all the code will change relative to it
// frameRate(200);
setConstants(); //initialize the tank size
fishes = new Fish[10];
for (int i = 0; i < fishes.length; i++) {
fishes[i] = makeFish();
}
}
/*The setConstants() method sets the size of the tank
relative to the size of the canvas. If the canvas is
too small the program exits with a warning message*/
void setConstants() {
if (height < 250 || width < 200) {
println("Sorry, needs a bigger canvas");
exit();
}
TANK_LEFT = int(width*.15);
TANK_RIGHT = width-int(width*.15);
TANK_BOTTOM = height-100;
TANK_TOP = height - TANK_BOTTOM;
WATER_TOP = TANK_TOP + int((TANK_BOTTOM-TANK_TOP)*.2);
}
/*The draw method is the simulation loop of our program. It
simply moves the fish, and then redraws the scene*/
void draw() {
drawBackground();
for (int i = 0; i < fishes.length; i++) {
moveFish(fishes[i]);
drawFish(fishes[i]);
}
drawForeground();
}
/*mousePressed() is an event handler called by Processing whenever
the user clicks the mouse. If the location of the mouse is within
the bounds of the aquarium's front face, a simulation of tapping
the glass takes place. A circle is drawn around the mouse, and
the fish speed away from the mouse*/
void mousePressed() {
if (mouseX < TANK_RIGHT && mouseX > TANK_LEFT &&
mouseY > WATER_TOP && mouseY < TANK_BOTTOM) {
noFill();
stroke(255);
ellipse(mouseX, mouseY, 25, 25);
for (Fish fish : fishes)
scareFish(fish);
}
}
/*scareFish is a wrapper method to clean the repitition of
code five times with different fish variables.
It turns the given fish away from the mouse, and gives it
a boost to it's speed.
Parameters:
Fish f - the fish to scare*/
void scareFish(Fish f) {
float tapDir = atan2(mouseY-f.y, mouseX-f.x);
f.dir = (int)(degrees(tapDir) + 180) % 360;
f.boost = f.speed;
}
/*The makeFish() method generates some random values, and then
creates a fish object based on those values.
Returns:
Fish - A fish object with randomized parameters*/
Fish makeFish() {
//generate random values
int randw = (int) random (20, 50);
int randh = (int)random(randw-20, randw);
int randD = (int)(random(360));
int randx = (int)random(TANK_LEFT+randw, TANK_RIGHT-randw);
int randy = (int)random(WATER_TOP, TANK_BOTTOM-(randh/2));
int randr = (int)random(0, 256);
int randg = (int)random(0, 256);
int randb = (int)random(0, 256);
float randSpeed = random(3) + 3;
//call the constructor, and return the Fish object it returns
return new Fish(randx, randy, randw, randh, randD, randr, randg, randb, randSpeed);
}
boolean isFacingRight(Fish f) {
int adir = abs(f.dir);
return adir <= 90 || adir >= 270;
}
void moveFish(Fish f) {
f.x = f.x + (int)((f.speed+f.boost)*cos(radians(f.dir)));
f.y = f.y + (int)((f.speed+f.boost)*sin(radians(f.dir)));
f.boost = f.boost*0.96;
if (f.x-(f.w/2) <= TANK_LEFT) {
f.dir = (180-f.dir) % 360;
f.x = TANK_LEFT+f.w;
}
if (f.x+(f.w/2) >= TANK_RIGHT) {
f.dir = (180-f.dir) % 360;
f.x = TANK_RIGHT - f.w;
}
if (f.y <= WATER_TOP) {
f.dir = -f.dir;
f.y=WATER_TOP;
}
if (f.y+(f.h/2) >= TANK_BOTTOM) {
f.dir = -f.dir;
f.y=TANK_BOTTOM - f.h/2;
}
}
void drawFish(Fish f) {
stroke(0);
fill(f.r, f.g, f.b);
ellipse(f.x, f.y, f.w, f.h);
int tail;
if (isFacingRight(f)) { //right
tail = -(f.w/2);
fill(255);
ellipse(f.x+(f.w*0.25), f.y-(f.h*0.25), 10, 10);
fill(0);
ellipse(f.x+(f.w*0.25), f.y-(f.h*0.25), 5, 5);
}
else {
tail = (f.w/2);
fill(255);
ellipse(f.x-(f.w*0.25), f.y-(f.h*0.25), 10, 10);
fill(0);
ellipse(f.x-(f.w*0.25), f.y-(f.h*0.25), 5, 5);
}
fill(f.r, f.g, f.b);
triangle(f.x+tail, f.y, (f.x+(2*tail)), (f.y+(f.h/2)), (f.x+(2*tail)), (f.y-(f.h/2)));
for (Bubble bubble : f.bub) {
bubble.draw();
}
}

amusingfu..

Re: Array Problem

1 year ago

Hey

can somebody help me sort the fish in size wise in the array

following if the code

//some useful constants (initialized in the setup)
int TANK_LEFT;
int TANK_RIGHT;
int TANK_TOP;
int TANK_BOTTOM;
int WATER_TOP;

final int NUM_FISH = 10;    //number of fish
final int BUBBLE_RATE = 50; //number of cycles between bubbles
final int BUBBLE_SIZE = 10; //size of the bubbles

/*The Fish class holds all the info pertinent to a single
fish: location, size, direction, colour, and speed.*/
class Fish{
int x,y,w,h,dir,r,g,b;
float speed,boost;
int bubbleTimer;
Bubble[] bubbles;

/*The default constructor creates a new fish object
with some random values*/
Fish(){
    //generate random values
    w = (int)random(30, 50);
    h = (int)random(w-20,w);
    dir = (int)(random(360));
    x = (int)random(TANK_LEFT+w, TANK_RIGHT-w);
    y = (int)random(WATER_TOP, TANK_BOTTOM-(h/2));
    r = (int)random(0, 256);
    g = (int)random(0, 256);
    b = (int)random(0, 256);

    speed = random(3) + 3;

    boost = 0; //initially zero
    bubbleTimer = 0;
    bubbles = new Bubble[5];


}
}

class Bubble{
int x,y;

Bubble(int X, int Y){
     x = X;
     y = Y;
}
}

Fish[] school;    //A small school of Fish objects

/*The setup method initializes the canvas and a school of fish*/
void setup() {
size(800,600); //feel free to change this, all the code will change relative to it
setConstants(); //initialize the tank size

//initialize and fill the school array
school = new Fish[NUM_FISH];
for(int i=0;i<school.length;i++)
    school[i] = new Fish();
}

/*The setConstants() method sets the size of the tank
relative to the size of the canvas. If the canvas is
too small the program exits with a warning message*/
void setConstants(){
    if(height<250 || width < 200){
    println("Sorry, needs a bigger canvas");
    exit();
}
TANK_LEFT = int(width*.15);
TANK_RIGHT = width-int(width*.15);
TANK_BOTTOM = height-100;
TANK_TOP = height - TANK_BOTTOM;
WATER_TOP = TANK_TOP + int((TANK_BOTTOM-TANK_TOP)*.2);
}

/*The draw method is the simulation loop of our program. It
simply moves the fish, and then redraws the scene*/
void draw(){
drawBackground();
moveSchool();
drawSchool();
drawForeground();
}

/*The moveSchool method is just a wrapper method to
call moveFish() on the various fish objects*/
void moveSchool(){
for(int i=0;i<school.length;i++)
    moveFish(school[i]);
}

/*moveFish() updates the location of a given fish based on
the bouncing ball mechanics discussed in class
Parameters:
Fish f - a fish object to be moved*/
void moveFish(Fish f){

f.x = f.x + (int)((f.speed+f.boost)*cos(radians(f.dir)));
f.y = f.y + (int)((f.speed+f.boost)*sin(radians(f.dir)));
f.boost = f.boost*0.96;


if(f.x-(f.w/2) <= TANK_LEFT){
     f.dir = (180-f.dir) % 360;
     f.x = TANK_LEFT+f.w;
}
if(f.x+(f.w/2) >= TANK_RIGHT) {
     f.dir = (180-f.dir) % 360;
     f.x = TANK_RIGHT - f.w;
}
if(f.y <= WATER_TOP){
    f.dir = -f.dir;
    f.y=WATER_TOP;
}
if(f.y+(f.h/2) >= TANK_BOTTOM) {
    f.dir = -f.dir;
    f.y=TANK_BOTTOM - (f.h/2 + 1) ;
}

if(f.bubbleTimer == 0){ //time to release a bubble!
    for(int i=0;i<f.bubbles.length;i++){ //search for null
      if(f.bubbles[i]==null){ //if we found an empty spot

        int bubbleX = f.x; //make bubble come out of the fish's face
        if ((f.dir <90 && f.dir>=-90)||f.dir>=270||f.dir<-270)
           bubbleX += (f.w/2) + 2;
        else
           bubbleX -= (f.w/2) + 2;

        //adjust bubbles to not go out of the tank
        if(bubbleX+BUBBLE_SIZE/2>=TANK_RIGHT)
          bubbleX = TANK_RIGHT-BUBBLE_SIZE;
        if(bubbleX-BUBBLE_SIZE/2<=TANK_LEFT)
          bubbleX = TANK_LEFT+BUBBLE_SIZE;

        //create the bubble
        f.bubbles[i] = new Bubble(bubbleX,f.y);

        break; //don't create any more bubbles
      }
    }
}

//increment bubble timer, max value of 50
f.bubbleTimer = (f.bubbleTimer+1)%BUBBLE_RATE;

//make bubbles float
for(int i=0;i<f.bubbles.length;i++){
    f.bubbles[i] = moveBubble(f.bubbles[i]);
}
}

Bubble moveBubble(Bubble b){
if(b!=null) {

    //draw bubble
    stroke(200,200,255);
    fill(200,200,255,128);//light blue
    ellipse(b.x,b.y,BUBBLE_SIZE,BUBBLE_SIZE);

    //move bubble
    b.y--;
    if(b.y<=WATER_TOP){
      return null;
    }
}
return b;
}

/*drawBackground() organizes any background drawing that must
be done*/
void drawBackground() {
//wall
background(128, 50, 50);
//floor
stroke(0);
fill(100, 56, 0);
rect(0, int(height*.7), width, int(height*.3));

drawTable();
drawAquariumBack();
}

/*The drawTable method draws a 3d table beneath where the
fish tank will go*/
void drawTable() {
//table legs
stroke(0);
fill(160, 116, 60); //shade
//back left leg
rect(TANK_LEFT, TANK_BOTTOM+50, 25, 15);
triangle(TANK_LEFT+25, TANK_BOTTOM+50, TANK_LEFT+35, TANK_BOTTOM+50, TANK_LEFT+25, TANK_BOTTOM+65);
//back right leg
rect(TANK_RIGHT+40, TANK_BOTTOM-50, 25, 115);
fill(200, 156, 100); //unshaded
quad(TANK_RIGHT+65, TANK_BOTTOM+65, TANK_RIGHT+75, TANK_BOTTOM+40, TANK_RIGHT+75, TANK_BOTTOM-100, TANK_RIGHT+65, TANK_BOTTOM-100);
//front left leg
rect(TANK_LEFT-50, TANK_BOTTOM+50, 25, 50);
fill(160, 116, 60);
quad(TANK_LEFT-25, TANK_BOTTOM+50, TANK_LEFT-15, TANK_BOTTOM+50, TANK_LEFT-15, TANK_BOTTOM+100, TANK_LEFT-25, TANK_BOTTOM+100);
//front right leg
fill(200, 156, 100);
rect(TANK_RIGHT, TANK_BOTTOM+50, 25, 50);
quad(TANK_RIGHT+25, TANK_BOTTOM, TANK_RIGHT+35, TANK_BOTTOM, TANK_RIGHT+35, TANK_BOTTOM+100, TANK_RIGHT+25, TANK_BOTTOM+100);

//table top
quad(TANK_LEFT-50, TANK_BOTTOM+25, TANK_LEFT+30, TANK_BOTTOM-100, TANK_RIGHT+75, TANK_BOTTOM-100, TANK_RIGHT+25, TANK_BOTTOM+25); //top
rect(TANK_LEFT-50, TANK_BOTTOM+25, (TANK_RIGHT+25)-(TANK_LEFT-50), 25); //front
quad(TANK_RIGHT+25, TANK_BOTTOM+25, TANK_RIGHT+75, TANK_BOTTOM-100, TANK_RIGHT+75, TANK_BOTTOM-75, TANK_RIGHT+25, TANK_BOTTOM+50); //side
}

/*drawAquariumBack draws the bottom, back, and left panes of
the fish tank.*/
void drawAquariumBack() {
//aquarium
stroke(255);
fill(255, 255, 255, 20); //faint white tint
rect(TANK_LEFT+40, TANK_TOP-60, (TANK_RIGHT+25)-(TANK_LEFT+40), (TANK_BOTTOM-60)-(TANK_TOP-60)); //back
quad(TANK_LEFT, TANK_BOTTOM, TANK_LEFT+40, TANK_BOTTOM-60, TANK_RIGHT+25, TANK_BOTTOM-60, TANK_RIGHT, TANK_BOTTOM); //bottom
quad(TANK_LEFT, TANK_BOTTOM, TANK_LEFT+40, TANK_BOTTOM-60, TANK_LEFT+40, TANK_TOP-60, TANK_LEFT, TANK_TOP);//back-left

//draw top of water, moved here to make the flakes look better
fill(50, 100, 255, 100); //translucent blue
stroke(0, 0, 56); //dark blue surface line
quad(TANK_LEFT,WATER_TOP-1,TANK_LEFT+40,WATER_TOP-60, TANK_RIGHT+25, WATER_TOP-60, TANK_RIGHT,WATER_TOP-1);//top face
}

/*drawSchool() organizes the drawing of individual fish objects.
It simply calls drawFish() on the various Fish variables.*/
void drawSchool() {
for(int i=0;i<school.length;i++)
    drawFish(school[i]);
}

/*drawFish draws a fish based on the provided parameters.
Parameters:
Fish f - The fish to be drawn
*/
void drawFish(Fish f) {
stroke(0);
fill(f.r, f.g, f.b);
ellipse(f.x, f.y, f.w, f.h);

int tail;
if ((f.dir <90 && f.dir>=-90)||f.dir>=270||f.dir<-270) { //right
    tail = -(f.w/2);

    fill(255);
    ellipse(f.x+(f.w*0.25), f.y-(f.h*0.25), 10, 10);
    fill(0);
    ellipse(f.x+(f.w*0.25), f.y-(f.h*0.25), 5, 5);
}
else {
    tail = (f.w/2);
    fill(255);
    ellipse(f.x-(f.w*0.25), f.y-(f.h*0.25), 10, 10);
    fill(0);
    ellipse(f.x-(f.w*0.25), f.y-(f.h*0.25), 5, 5);
}
fill(f.r, f.g, f.b);
triangle(f.x+tail, f.y, (f.x+(2*tail)), (f.y+(f.h/2)), (f.x+(2*tail)), (f.y-(f.h/2)));
}

/*drawForeground organizes all the items that need to be drawn
after the fish*/
void drawForeground() {
drawWater();
drawAquariumFront();
}

/*drawWater draws 3 panes of water on top of the fish to imitate
a rectangular prism. Water is tinted translucent blue.*/
void drawWater() {
noStroke();
fill(50, 100, 255, 100); //translucent blue
rect(TANK_LEFT, WATER_TOP, TANK_RIGHT-TANK_LEFT, TANK_BOTTOM-WATER_TOP); //front face
quad(TANK_RIGHT, WATER_TOP, TANK_RIGHT+25, WATER_TOP-60, TANK_RIGHT+25, TANK_BOTTOM-60, TANK_RIGHT, TANK_BOTTOM); //right face
stroke(0, 0, 56); //dark blue surface line
line(TANK_LEFT,WATER_TOP-1,TANK_RIGHT,WATER_TOP-1);
}

/*drawAquariumFront() draws the front and right panes of the aquarium*/
void drawAquariumFront() {
//aquarium
stroke(255);
fill(255, 255, 255, 20);
rect(TANK_LEFT, TANK_TOP, TANK_RIGHT-TANK_LEFT, TANK_BOTTOM - TANK_TOP); //front
quad(TANK_RIGHT, TANK_TOP, TANK_RIGHT+25, TANK_TOP-60, TANK_RIGHT+25, TANK_BOTTOM-60, TANK_RIGHT, TANK_BOTTOM);//front-right

}

////////////////User Interaction//////////////////////

/*mousePressed() is an event handler called by Processing whenever
the user clicks the mouse. If the location of the mouse is within
the bounds of the aquarium's front face, a simulation of tapping
the glass takes place. A circle is drawn around the mouse, and
the fish speed away from the mouse*/
void mousePressed(){
if(mouseX<TANK_RIGHT && mouseX>TANK_LEFT &&
      mouseY>WATER_TOP && mouseY<TANK_BOTTOM){
      noFill();
      stroke(255);
      ellipse(mouseX,mouseY,25,25);

      for(int i=0;i<school.length;i++)
        scareFish(school[i]);
   }
}

/*scareFish is a wrapper method to clean the repitition of
code five times with different fish variables.
It turns the given fish away from the mouse, and gives it
a boost to it's speed.
Parameters:
    Fish f - the fish to scare*/
void scareFish(Fish f){
    float tapDir = atan2(mouseY-f.y,mouseX-f.x);
    f.dir = (int)(degrees(tapDir) + 180) % 360;
    f.boost = f.speed;
}

thanks for the help in advance

PhiLho

Re: Array Problem

1 year ago

What do you mean by "sort the fishes"? It won't change anything in the display.

Anyway, search the forum, keywords: Comparable sort
You have to add the Comparable interface to your fishes, and to provide there a compareTo() method, comparing the current fish with the provided one, depending on whatever criteria you want (here, the size).

Array Problem

Replies(10)

Re: Array Problem

Re: Array Problem

Re: Array Problem

Re: Array Problem

Re: Array Problem

Re: Array Problem

Re: Array Problem

Re: Array Problem

Re: Array Problem

Re: Array Problem

Statistics

Tags

Actions

Related Posts