Add color x to color y if event A occurs

Programming Questions

newtoproc..

Add color x to color y if event A occurs

in Programming Questions • 2 years ago

Hello,

What I am trying to do is to tell the program to fill the rectangle with color #F9C5D7 if the word "love" is used in the loaded txt file. Then, if the word "sky" is used, add color #A7A72E to #F9C5D7; else do not add it.

int value = 0;

...........

void setup()

...........

if(key.equals("love") ){
value = #F9C5D7;

}
if(key.equals("sky")){
value = #F9C5D7 + #A7A72E;

void draw()
{
fill(value);
rect(50,50,50,50);

}

However, even though both words are within the text content, the program always colors the rectangle in #F9C5D7 (the color corresponding to the first word) and does not add the second color

The other way I tried, which gives the same results is:

color c1 = #F9C5D7;
color c2 = #A7A72E;
color c;

...........

void setup()

...........

if(key.equals("love") ){
c = c1;

}
if(key.equals("sky")){
c = c + c2;

void draw()
{
fill(c);
rect(50,50,50,50);

}

This example mixes the colors correctly but I do not know how to adapt it in order to fit the requirement for present within the text word

color c1 = #A7A72E;
color c2 = #F9C5D7;
color c = c1+c2;

void setup() {
size(400,400);
}
void draw() {

fill(c);
rect(50,50,50,50);
}

Any insight into how to adapt the code so that it mixes the colors when the events occur would be highly appreciated!

Replies(18)

allonestr..

Re: Add color x to color y if event A occurs

2 years ago

Try something like this:

if(weather == "SUNNY")
{
println("It's sunny");
}
else if(weather == "RAINING")
{
println("It's raining");
}
else
{
println("What's the weather today?");
}

What do you plan to do with your colours if they add to more than FFFFFF?

PhiLho

Re: Re: Add color x to color y if event A occurs

2 years ago

Don't show equality of strings with ==, it won't work in most cases...

newtoproc..

Re: Add color x to color y if event A occurs

2 years ago

Hi and thanks for taking the time to provide me with some insight!

However, what I want the program to do is to add 'green' if 'grass' is mentioned to 'red' if 'love' is mentioned to 'yellow' if 'sun' is mentioned and so on and so on

PhiLho

Re: Add color x to color y if event A occurs

2 years ago

You should predefine the colors, including the result of the mixes. As allonestring pointed out, you will have unexpected results because of integer overflow. Basically, you can really mix colors this way (in a reliable way) only if each channel is below 128 (ie. 80h).

And since we miss most of the code (how key is defined), it is hard to tell why it isn't working. But key can't be equal to "love" and "sky" at the same time.

newtoproc..

Re: Re: Add color x to color y if event A occurs

2 years ago

I made the following corrections and now it is mixing the colors. However, another issue arouse

color c1 = #a70841; //red
color c2 = #ffec82; //yellow
color c = 0;

......

if(key.equals("mature") ){
c = c1; // fill with red ??(else do not fill with anything; or fill with white)??
}
else if(key.equals("happy")){
c = c += c2; // add yellow to the previous outcome (red or white) ??(else do not add anything; or add white)??
}

Right now, the word mature (red) is not within the text, only the word happy (yellow); however, the fill is the result of adding yellow to red; not just yellow
Could you give me an insight into how to include "if (the word is not within the text) {do not add anything or add white} command

allonestr..

Re: Add color x to color y if event A occurs

2 years ago

I'm having a problem working out your sequencing.

- Are you stepping through the text file checking to see if word_n == one of your chosen words, and if so changing the colour? In which case the result might be to see colour changes as you find chosen words

- Or are you reading in the whole text file and accumulating the colour changes for one big splat?

I'm not sure where you should be reading through the text file. Are you doing it within setup() at the mo? That doesn't feel right to me.

In lieu of importing a text file, I had no problem writing code to add colours when I pressed various keys.

Have you noticed that you haven't closed your curly brackets in your ifs in your original post?

I'm going to dare to disagree with phi.lho, I compare strings a lot, particularly for states:

if(ballState == "BOUNCING")

for example.

if(word not found), try else!

PhiLho

Re: Add color x to color y if event A occurs

2 years ago

" I'm going to dare to disagree with phi.lho, I compare strings a lot, particularly for states:"
It works if the string is defined in the applet itself, because strings are interned, so they share the same reference. Try to compare with a string read from a file, or constructed from two strings, and see by yourself...

Such comparison can work, but unless you are aware of the issues, you can get some surprises...

And, again, I have trouble understanding your code, newtoprocessing. Can you show the whole code, if it isn't too long?

newtoproc..

Re: Add color x to color y if event A occurs

2 years ago

Any help on why this expression is not working?

for(float w = 0; key.equals("more"); w = w + 4) {
strokeWeight(w);
}

It does not give an error but it does not run the sketch (only when the word "more" is present within the text, otherwise, it does run the sketch)

PhiLho

Re: Add color x to color y if event A occurs

2 years ago

You assign 0 to w, check if key equals "more", and if so, enter the loop, where you set the strokeWeight. Then you increment w of 4, and check again key. As it is unlikely it has changed, you get an infinite loop. If key isn't equal, you don't enter the loop.
So, it is roughly like a simple loop:
float w = 0;
while (key.equals("more")) { strokeWeight(w); w += 4; } // No drawing occurs before the end of the loop!

newtoproc..

Re: Re: Add color x to color y if event A occurs

2 years ago

You are right! Now when I try drawing a line, nothing happens...how can I separate the two parts or what to do in this case?

void draw()
{
while(key.equals("more"))
{strokeWeight(w); w+=4;}

stroke(0);

beginShape();
for (int i = 0; i < x.length; i++) {
      vertex(x[i], y[i]);
}
   // Show the next segment to be added
if (x.length >= 1) {
    stroke(12);

}
endShape();

}

void mousePressed() {

x = append(x, mouseX);
y = append(y, mouseY);

Many thanks!!
}

Greger

Re: Add color x to color y if event A occurs

2 years ago

while(key.equals("more"))
{
strokeWeight(w); w+=4;
}

key is never updated in this loop, so it will never get out of the loop.
So you'll never get a line.
You need to update key with a new value for every iteration.

PhiLho

Re: Add color x to color y if event A occurs

2 years ago

Go back to an if, and use draw() as the iterative loop.
So, basically, replace
while(key.equals("more"))
{strokeWeight(w); w+=4;}
with
if (key.equals("more"))
{ strokeWeight(w); w += 4; }
and w will increase on each frame.

newtoproc..

Re: Add color x to color y if event A occurs

2 years ago

Gregersn,

You are right.

with

if(key.equals("more"))
{strokeWeight(w); w+=4;}

I did not get a line – rather, when I clicked, I got one enlarging itself circle

It does not follow the command – increase strokeWeight by 4, every time you encounter the word ‘more’

Can I somehow adapt it after bringing the command up in setup()?

Many thanks!

Greger

Re: Re: Add color x to color y if event A occurs

2 years ago

I hope I am not being rude, but it seems like you might want to go through the code you have, and make sure you understand what happens on each line.

Or maybe start with some easier task.

OR, at least try to be more clear on what you are doing, and what you want to do. Cause I am not sure what you are trying to achieve here.

A programming trick is to write down what you want your program to do, in natural language, first. Then replace each point on your list with code as you go. E.g.

* Open window
* Fill background
* Draw point at mouse pointer if mouse is clicked

And then start write code to accomplish each of those tasks.

You seem to be going a lot back and forth here.

PhiLho

Re: Add color x to color y if event A occurs

2 years ago

key must be updated somehow, otherwise the test will always be false or true, but won't change. Again, we have a partial view of your sketch, so it is hard to tell.
And gregersn's advice is excellent: a good exercise is to put yourself at the place of the computer, and try to run the program in your head. Look at the succession of lines, what are roughly the values you get at each point, etc.
Programming is matter of logic, mostly.

PhiLho

Re: Add color x to color y if event A occurs

2 years ago

OK, here is it quite obvious: you test if (key.equals("cool") || key.equals("calm")|| key.equals("young") || key.equals("faithful")|| key.equals("protective") || key.equals("constant") || key.equals("peaceful") || key.equals("impressive")|| key.equals("open") || key.equals("confident")) and if so, you test if key.equals("more"). Obviously, it is always false...

newtoproc..

Re: Re: Add color x to color y if event A occurs

2 years ago

So you mean there is no way to make this work: if key.equals("more")?

PhiLho

Re: Add color x to color y if event A occurs

2 years ago

If you need it at the place you have put it, just add also || key.equals("more") to your long list of comparisons: thus it will enter the block with this word, among others, and you can special case it inside.

Top Reply